fix(uploads): simple download glob fix

lucky_router latest release does not work with globs properly

Author: stakach

OPENAPI_DOC.yml

@@ -18540,7 +18540,7 @@ paths:
             application/json:
               schema:
                 $ref: '#/components/schemas/PlaceOS__Api__Application__ContentError'
-  /api/engine/v2/uploads/{id}/download/{api_key}/{file_name}:
+  /api/engine/v2/uploads/{id}/download/{api_key}/{inline}/{file_name}:
     get:
       summary: a traditional looking route for downloading files
       description: 'a traditional looking route for downloading files
@@ -18563,9 +18563,13 @@ paths:
         required: true
         schema:
           type: string
+      - name: inline
+        in: path
+        required: true
+        schema:
+          type: boolean
       - name: file_name
         in: query
-        required: true
         schema:
           type: string
       responses:

shard.lock

@@ -141,9 +141,9 @@ shards:
     git: https://github.com/spider-gazelle/crystal-loki-client.git
     version: 0.1.0+git.commit.ed3c0ab5b6f3da6103f6aed680fdcd171680feca
 
-  lucky_router:
+  lucky_router: # Overridden
     git: https://github.com/luckyframework/lucky_router.git
-    version: 0.6.0
+    version: 0.6.0+git.commit.670df15727fc0a7b0ac8749dc0be75b59b8f174b
 
   murmur3:
     git: https://github.com/aca-labs/murmur3.git

shard.override.yml

@@ -9,8 +9,8 @@ dependencies:
     github: place-labs/CrystalEmail
     version: ~> 0.2
 
-  opentelemetry-sdk:
-    github: wyhaines/opentelemetry-sdk.cr
+  lucky_router:
+    github: luckyframework/lucky_router
     branch: main
 
   # For core client

src/placeos-rest-api/controllers/uploads.cr

@@ -283,16 +283,17 @@ module PlaceOS::Api
     # a traditional looking route for downloading files
     #
     # the API key route param can be Base64 encoded.
-    @[AC::Route::GET("/:id/download/:api_key/*:file_name")]
-    def download_simple_route(api_key : String, file_name : String)
+    @[AC::Route::GET("/:id/download/:api_key/:inline/*:file_name")]
+    def download_simple_route(api_key : String, inline : Bool, file_name : String = "file")
       # decode the API key
       api_key = Base64.decode_string(api_key).strip rescue api_key
 
       # check api key
       request.headers["X-API-Key"] = api_key
       authorize!
+      set_user_id
 
-      response.headers["Content-Disposition"] = %(attachment; filename="#{file_name}")
+      response.headers["Content-Disposition"] = %(attachment; filename="#{file_name}") if inline
       download_proxy_file_contents
     end