Error in Card.find

[RodolfoFerro]

I am using the SDK to find some cards and I found an error running the following code:

from pokemontcgsdk import RestClient
from pokemontcgsdk import Set
from pokemontcgsdk import Card


API_KEY = "XXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX"
RestClient.configure(API_KEY)


# Original card:
#  * 1 Crobat V PR-SW 98
set_from_ptcgo = "PR-SW"
card_number = "98"

sets = Set.where(q=f"ptcgoCode:{set_from_ptcgo}")
set_ = sets[0].id

card_id = set_ + "-" + card_number
print(card_id)
# swshp-98

card = Card.find(card_id)
print(card)
# The previous line returns the following:
"""
Traceback (most recent call last):
  File "/Users/rodolfoferro/miniforge3/envs/streamlit/lib/python3.8/site-packages/pokemontcgsdk/restclient.py", line 36, in get
    response = json.loads(urlopen(req).read().decode("utf-8"))
  File "/Users/rodolfoferro/miniforge3/envs/streamlit/lib/python3.8/urllib/request.py", line 222, in urlopen
    return opener.open(url, data, timeout)
  File "/Users/rodolfoferro/miniforge3/envs/streamlit/lib/python3.8/urllib/request.py", line 531, in open
    response = meth(req, response)
  File "/Users/rodolfoferro/miniforge3/envs/streamlit/lib/python3.8/urllib/request.py", line 640, in http_response
    response = self.parent.error(
  File "/Users/rodolfoferro/miniforge3/envs/streamlit/lib/python3.8/urllib/request.py", line 569, in error
    return self._call_chain(*args)
  File "/Users/rodolfoferro/miniforge3/envs/streamlit/lib/python3.8/urllib/request.py", line 502, in _call_chain
    result = func(*args)
  File "/Users/rodolfoferro/miniforge3/envs/streamlit/lib/python3.8/urllib/request.py", line 649, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 404: Not Found

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "find_error.py", line 22, in <module>
    card = Card.find(card_id)
  File "/Users/rodolfoferro/miniforge3/envs/streamlit/lib/python3.8/site-packages/pokemontcgsdk/card.py", line 50, in find
    return QueryBuilder(Card, Card.transform).find(id)
  File "/Users/rodolfoferro/miniforge3/envs/streamlit/lib/python3.8/site-packages/pokemontcgsdk/querybuilder.py", line 21, in find
    response = RestClient.get(url)['data']
  File "/Users/rodolfoferro/miniforge3/envs/streamlit/lib/python3.8/site-packages/pokemontcgsdk/restclient.py", line 40, in get
    raise PokemonTcgException(err.read())
pokemontcgsdk.restclient.PokemonTcgException: <exception str() failed>
"""

I'm not sure if I'm doing something wrong, but the API is not returning any response for that card.

[RodolfoFerro]

I've checked and I think that this error occurs only with promo cards.

[RodolfoFerro]

UPDATE: I've noticed that a commit adding some missing promos to the database has been added yesterday. ➡️ PokemonTCG/pokemon-tcg-data@05b4ea3

[JacobKnox]

I think the issue here is that you're assuming the card id will always be of the form setid-cardnumber when that's not the case. The Crobat V you're trying to find, for example, has an id of swshp-SWSH098 whereas you're trying to find a card with id swshp-98 (which doesn't exist, as far as I can tell).

Edit: I notice the car number for Crobat V actually is SWSH098, so I suppose it is of the form setid-cardnumber. You just had the wrong card number.

[RodolfoFerro]

Thanks, this actually helps a lot.

So bad I had to use another service for this, since I was struggling with this a year ago. :(

[JacobKnox]

For some reason, I forgot it's 2023 now. I thought this issue was from this month lol.