update limit order expiration handling

Author: cesarenaldi

packages/client/src/actions/orders.test.ts

@@ -143,7 +143,6 @@ describe('Orders', () => {
 
     it('allows to place a limit order for the desired size and price', async () => {
       const result = await prepareLimitOrder(secureClient, {
-        orderType: OrderType.GTC,
         price: minPrice,
         side: OrderSide.BUY,
         size: minSize,
@@ -157,7 +156,6 @@ describe('Orders', () => {
 
     it('carries post-only submission options onto the prepared order', async () => {
       const order = await prepareLimitOrder(secureClient, {
-        orderType: OrderType.GTC,
         postOnly: true,
         price: minPrice,
         side: OrderSide.BUY,
@@ -186,7 +184,6 @@ describe('Orders', () => {
         .then((handle) => handle.wait());
 
       const response = await prepareLimitOrder(gaslessClient, {
-        orderType: OrderType.GTC,
         price: minPrice,
         side: OrderSide.BUY,
         size: minSize,
@@ -213,7 +210,6 @@ describe('Orders', () => {
 
     it('creates, signs, and posts a limit order in one workflow', async () => {
       const response = await prepareLimitOrderPosting(secureClient, {
-        orderType: OrderType.GTC,
         postOnly: true,
         price: minPrice,
         side: OrderSide.BUY,
@@ -321,7 +317,6 @@ async function createRestingLimitOrder(): Promise<{
   const tickSize = expectPresent(market.orderPriceMinTickSize);
   const size = expectPresent(market.orderMinSize);
   const response = await prepareLimitOrderPosting(secureClient, {
-    orderType: OrderType.GTC,
     price: tickSize,
     side: OrderSide.BUY,
     size,
@@ -345,7 +340,6 @@ async function createSignedRestingLimitOrder() {
   const size = expectPresent(market.orderMinSize);
 
   return prepareLimitOrder(secureClient, {
-    orderType: OrderType.GTC,
     price: tickSize,
     side: OrderSide.BUY,
     size,

packages/client/src/actions/orders/limit.ts

@@ -28,48 +28,26 @@ import {
 import type { OrderDraft, PrepareLimitOrderRequest } from './types';
 
 export const PrepareLimitOrderParamsSchema = z
-  .object({
+  .strictObject({
     tokenId: TokenIdSchema,
     price: z.number().positive(),
     size: z.number().positive(),
     side: OrderSideSchema,
     taker: EvmAddressSchema.optional(),
     postOnly: z.boolean().default(false),
     expiration: z.number().int().nonnegative().optional(),
-    orderType: z
-      .union([z.literal(OrderType.GTC), z.literal(OrderType.GTD)])
-      .default(OrderType.GTC),
   })
   .superRefine((params, context) => {
-    if (params.orderType === OrderType.GTD) {
-      if (params.expiration === undefined) {
-        context.addIssue({
-          code: 'custom',
-          message: 'GTD orders require an expiration timestamp.',
-          path: ['expiration'],
-        });
-        return;
-      }
-
+    if (params.expiration !== undefined) {
       const minimumExpiration = Math.floor(Date.now() / 1000) + 60;
 
       if (params.expiration <= minimumExpiration) {
         context.addIssue({
           code: 'custom',
-          message: 'GTD expiration must be at least 60 seconds in the future.',
+          message: 'Expiration must be at least 60 seconds in the future.',
           path: ['expiration'],
         });
       }
-
-      return;
-    }
-
-    if (params.expiration !== undefined) {
-      context.addIssue({
-        code: 'custom',
-        message: 'Expiration is only supported for GTD orders.',
-        path: ['expiration'],
-      });
     }
   }) satisfies z.ZodType<PrepareLimitOrderRequest>;
 
@@ -104,7 +82,7 @@ export async function prepareLimitOrderDraft(
     feeRateBps: context.feeRateBps,
     funderAddress: context.funderAddress,
     offeredAmount: amounts.offeredAmount,
-    orderType: params.orderType,
+    orderType: params.expiration === undefined ? OrderType.GTC : OrderType.GTD,
     side: params.side,
     signer: context.signerAddress,
     allowedTaker: params.taker,

packages/client/src/actions/orders/types.ts

@@ -62,17 +62,15 @@ export type PrepareLimitOrderRequest = {
    */
   postOnly?: boolean;
 
-  /** Timestamp after which the order is expired. Required for GTD orders. */
-  expiration?: number;
-
   /**
-   * Specifies the type of order execution.
-   * - GTC (Good-Til-Cancelled): rests on the book until filled or cancelled
-   * - GTD (Good-Til-Date): active until the specified expiration timestamp
+   * Unix timestamp in seconds after which the order expires.
    *
-   * @defaultValue OrderType.GTC
+   * When provided, the SDK prepares a Good-Til-Date (GTD) limit order that
+   * expires at the given timestamp.
+   *
+   * When omitted, the SDK prepares a Good-Til-Cancelled (GTC) limit order.
    */
-  orderType?: OrderType.GTC | OrderType.GTD;
+  expiration?: number;
 };
 
 export type OrderDraft = {

packages/client/src/ethers-v5.test.ts

@@ -1,7 +1,6 @@
 import {
   type AcceptedOrderResponse,
   OrderSide,
-  OrderType,
 } from '@polymarket/bindings/clob';
 import { expectPresent } from '@polymarket/types';
 import { ethers } from 'ethers-v5';
@@ -60,7 +59,6 @@ describe('ethers-v5', () => {
         .then(authenticateWith(signer));
 
       const response = await prepareLimitOrderPosting(secureClient, {
-        orderType: OrderType.GTC,
         price,
         size,
         side: OrderSide.BUY,