Skip to content

Commit 66e67d7

Browse files
committed
nit
1 parent b2caf26 commit 66e67d7

2 files changed

Lines changed: 4 additions & 7 deletions

File tree

internal/xds/httpfilter/ext_authz/ext_authz.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -913,7 +913,7 @@ func (i *serverInterceptor) InterceptRPC(ss grpc.ServerStream) (grpc.ServerStrea
913913
// will add a x-envoy-auth-failure-mode-allowed: true header to the data
914914
// plane RPC.
915915
appendFailureModeHeader(incomingMD, i.config.failureModeAllowHeaderAdd)
916-
return newWrappedServerStream(ss, metadata.NewIncomingContext(ctx, incomingMD), nil), nil
916+
return newWrappedServerStream(metadata.NewIncomingContext(ctx, incomingMD), ss, nil), nil
917917
}
918918

919919
// When the external authorization server denies the RPC, we terminate the
@@ -938,7 +938,7 @@ func (i *serverInterceptor) InterceptRPC(ss grpc.ServerStream) (grpc.ServerStrea
938938
return nil, status.Errorf(i.config.statusOnError, "extauthz: error applying header mutation rules on denied response: %v", err)
939939
}
940940
appendFailureModeHeader(incomingMD, i.config.failureModeAllowHeaderAdd)
941-
return newWrappedServerStream(ss, metadata.NewIncomingContext(ctx, incomingMD), nil), nil
941+
return newWrappedServerStream(metadata.NewIncomingContext(ctx, incomingMD), ss, nil), nil
942942
}
943943
ss.SetTrailer(trailers)
944944
}
@@ -972,7 +972,7 @@ func (i *serverInterceptor) InterceptRPC(ss grpc.ServerStream) (grpc.ServerStrea
972972
}
973973
// Return a wrapped server stream with mutated incoming metadata and
974974
// lazy response header injection for subsequent handlers.
975-
return newWrappedServerStream(ss, metadata.NewIncomingContext(ctx, incomingMD), responseHeaders), nil
975+
return newWrappedServerStream(metadata.NewIncomingContext(ctx, incomingMD), ss, responseHeaders), nil
976976
}
977977

978978
// If the response does not contain an OkResponse message despite having
@@ -1045,7 +1045,7 @@ func (w *wrappedServerStream) SendMsg(m any) error {
10451045
// stream, context, and response headers to apply. If a ServerTransportStream
10461046
// is present in the incoming context, it is wrapped so that unary RPC handlers
10471047
// calling grpc.SendHeader will also trigger ext_authz response header mutations.
1048-
func newWrappedServerStream(ss grpc.ServerStream, ctx context.Context, responseHeaders metadata.MD) *wrappedServerStream {
1048+
func newWrappedServerStream(ctx context.Context, ss grpc.ServerStream, responseHeaders metadata.MD) *wrappedServerStream {
10491049
w := &wrappedServerStream{
10501050
ServerStream: ss,
10511051
responseHeaders: responseHeaders,

internal/xds/httpfilter/ext_authz/ext_authz_server_test.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,6 @@ type testServerStream struct {
3838
}
3939

4040
func (s *testServerStream) Context() context.Context {
41-
if s.ctx == nil {
42-
return context.Background()
43-
}
4441
return s.ctx
4542
}
4643

0 commit comments

Comments
 (0)