Add auth token to ZMQ env server#1123
Open
teilomillet wants to merge 1 commit intoPrimeIntellect-ai:mainfrom
Open
Add auth token to ZMQ env server#1123teilomillet wants to merge 1 commit intoPrimeIntellect-ai:mainfrom
teilomillet wants to merge 1 commit intoPrimeIntellect-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Environment.start_server()Testing
Note
Medium Risk
Changes the ZMQ wire protocol (optional extra frame) and makes
Environment.start_server()always start auth-protected servers, so mismatched/legacy clients can fail withUnauthorizedand break server connectivity.Overview
Adds optional transport-level authentication to the ZMQ env server/client by introducing an
auth_tokenframe in request/health-check multipart messages and rejecting unauthorized requests before they reach the router.Environment.start_server()now generates a shared random token and wires it into both the spawnedZMQEnvServerprocess and theZMQEnvClient. Tests are extended to cover allowed/denied request dispatch and health-check behavior when auth is enabled, plus server-startup wiring of the shared token.Reviewed by Cursor Bugbot for commit 3458eb0. Bugbot is set up for automated code reviews on this repo. Configure here.