Update project configuration and tests for .NET compatibility

- Update dotnet.yml to include bugfix branches
- Modify Changelog.md to reflect changes in framework support
- Change default framework from net461 to net462 in Directory.Build.props
- Update EasyConsoleApplication.Tests.csproj to support multiple target frameworks
- Refactor MenuRendererTests to use MSTest and update assertions
- Enhance ConsoleHelpers to check for input redirection
- Upgrade Microsoft.SourceLink.GitHub package to version 10.0.301

Author: AGiorgetti

.github/workflows/dotnet.yml

@@ -5,7 +5,7 @@ name: .NET
 
 on:
   push:
-    branches: [ "main", "master", "develop", "feature/*", "release/*", "hotfix/*", "support/*" ]
+    branches: [ "main", "master", "develop", "feature/*", "release/*", "hotfix/*", "support/*", "bugfix/*" ]
   pull_request:
     branches: [ "main", "master" ]
   workflow_dispatch:

Changelog.md

@@ -1,7 +1,13 @@
 ## vNext
 
+- Removed support for net461
+- Added support for net462
 - Avoid clearing the console when output is redirected or the console is unavailable.
 
+### Breaking Changes
+
+- Removed support for net461, use net462 instead.
+
 ## 0.8.0
 
 - Added support for net10.0

src/Directory.Build.props

@@ -6,7 +6,7 @@
 		<Nullable>enable</Nullable>
 
 		<!-- Defaults (can be overridden with /p:netCoreMinimum=... etc) -->
-		<NetFullFramework Condition="'$(NetFullFramework)'==''">net461</NetFullFramework>
+		<NetFullFramework Condition="'$(NetFullFramework)'==''">net462</NetFullFramework>
 		<NetCoreMinimum Condition="'$(NetCoreMinimum)'==''">net8.0</NetCoreMinimum>
 		<NetCorePrevious Condition="'$(NetCorePrevious)'==''">net9.0</NetCorePrevious>
 		<NetCoreCurrent Condition="'$(NetCoreCurrent)'==''">net10.0</NetCoreCurrent>

src/EasyConsoleApplication.Tests/EasyConsoleApplication.Tests.csproj

@@ -1,14 +1,14 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFrameworks>$(NetFullFramework);$(NetCoreFrameworks)</TargetFrameworks>
     <IsPackable>false</IsPackable>
   </PropertyGroup>
   <ItemGroup>
     <ProjectReference Include="..\EasyConsoleApplication\EasyConsoleApplication.csproj" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
-    <PackageReference Include="xunit" Version="2.9.3" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="3.0.2">
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.8.1" />
+    <PackageReference Include="MSTest.TestAdapter" Version="4.3.3">
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
+    <PackageReference Include="MSTest.TestFramework" Version="4.3.3" />
   </ItemGroup>
 </Project>

src/EasyConsoleApplication.Tests/MenuRendererTests.cs

@@ -1,11 +1,13 @@
 using EasyConsoleApplication.Menus;
-using Xunit;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
 
 namespace EasyConsoleApplication.Tests;
 
+[TestClass]
+[DoNotParallelize]
 public sealed class MenuRendererTests
 {
-	[Fact]
+	[TestMethod]
 	public void Render_does_not_clear_redirected_output()
 	{
 		var originalOut = Console.Out;
@@ -27,7 +29,7 @@ public void Render_does_not_clear_redirected_output()
 		}
 	}
 
-	[Fact]
+	[TestMethod]
 	public void Render_stops_when_input_reaches_eof()
 	{
 		var originalOut = Console.Out;
@@ -49,7 +51,7 @@ public void Render_stops_when_input_reaches_eof()
 		}
 	}
 
-	[Fact]
+	[TestMethod]
 	public void Key_prompts_do_not_require_interactive_input()
 	{
 		var originalOut = Console.Out;
@@ -62,7 +64,7 @@ public void Key_prompts_do_not_require_interactive_input()
 			var answer = ConsoleHelpers.AskToUserYesNoQuestion(ConsoleColor.Gray, "Continue?");
 			ConsoleHelpers.HitEnterToContinue();
 
-			Assert.Equal(ConsoleKey.Y, answer.Key);
+			Assert.AreEqual(ConsoleKey.Y, answer.Key);
 		}
 		finally
 		{

src/EasyConsoleApplication/ConsoleHelpers.cs

@@ -95,7 +95,7 @@ public static void WriteRed(string message, bool newLine = true)
 		public static ConsoleKeyInfo AskToUserYesNoQuestion(ConsoleColor color, string question, bool newLine = true)
 		{
 			Write(color, question + " [y/n] ", false);
-			if (Console.IsInputRedirected)
+			if (IsInputRedirected())
 			{
 				// ReadKey requires an interactive terminal, so consume redirected input as a line.
 				while (true)
@@ -132,6 +132,23 @@ public static ConsoleKeyInfo AskToUserYesNoQuestion(ConsoleColor color, string q
 			return key;
 		}
 
+		private static bool IsInputRedirected()
+		{
+			try
+			{
+				_ = Console.KeyAvailable;
+				return Console.IsInputRedirected || Console.IsOutputRedirected;
+			}
+			catch (InvalidOperationException)
+			{
+				return true;
+			}
+			catch (IOException)
+			{
+				return true;
+			}
+		}
+
 		/// <summary>
 		/// Reads a line of input from the console with the specified color.
 		/// </summary>
@@ -156,7 +173,7 @@ public static ConsoleKeyInfo AskToUserYesNoQuestion(ConsoleColor color, string q
 		public static void HitEnterToContinue()
 		{
 			Write(ConsoleSettings.HitEnterToContinueColor, "Hit 'Enter' to continue.", newLine: true);
-			if (Console.IsInputRedirected)
+			if (IsInputRedirected())
 			{
 				// There is no key event to wait for when stdin is redirected.
 				return;

src/EasyConsoleApplication/EasyConsoleApplication.csproj

@@ -22,7 +22,7 @@
     <AnalysisLevel>latest-recommended</AnalysisLevel>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0">
+    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="10.0.301">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>