Skip to content

Commit cc81dc1

Browse files
Merge pull request #246 from Overlord360/test_tolerances
Fix issues in DMM and PPS tests
2 parents 5ab496c + 7d7acaf commit cc81dc1

4 files changed

Lines changed: 6 additions & 5 deletions

File tree

docs/release-notes.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ Improvements
1919

2020
- Sequencer logic now handles exceptions raised on sequence abort. GUI will no longer hang when a test raises an exception during a test abort.
2121
- Fix bug where DSOX1202G appeared to hang both the program and scope
22-
- LCR Driver now supports instruments reporting as Keysight or Agilent. Newer models of the LCR meter report as Keysight, whereas older models report as Agilent.
22+
- LCR Driver now supports instruments reporting as Keysight or Agilent. Newer models of the LCR meter report as Keysight, whereas older models report as Agilent.
23+
- Changed tolerances for PPS and DMM tests to more accurately match device accuracy.
2324

2425
*************
2526
Version 0.6.4

test/drivers/test_fluke_8846A.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
# Test values for measurement functions:
1010
# These are mostly defined either by J413 or an arbitrary number I picked.
1111
TEST_RESISTANCE = 100 # Resistance in loopback jig for testing
12-
TEST_RESISTANCE_TOL = 1 # 1 Ohm absolute tolerance
12+
TEST_RESISTANCE_TOL = 5 # 5 Ohm absolute tolerance
1313
TEST_CAPACITANCE = 4.7e-6 # Capacitance in loopback jig for testing
1414
TEST_CAPACITANCE_TOL = 0.5e-6
1515
TEST_VOLTAGE_DC = 100e-3

test/drivers/test_keithley_6500.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
# Test values for measurement functions:
1010
# These are mostly defined either by J413 or an arbitrary number I picked.
1111
TEST_RESISTANCE = 100 # Resistance in loopback jig for testing
12-
TEST_RESISTANCE_TOL = 1 # 1 Ohm absolute tolerance
12+
TEST_RESISTANCE_TOL = 5 # 5 Ohm absolute tolerance
1313
TEST_CAPACITANCE = 4.7e-6 # Capacitance in loopback jig for testing
1414
TEST_CAPACITANCE_TOL = 0.5e-6
1515
TEST_VOLTAGE_DC = 100e-3
@@ -57,7 +57,7 @@ def test_reset(dmm):
5757
("capacitance", "CAP"),
5858
("continuity", "CONT"),
5959
("diode", "DIOD"),
60-
("temperature", "TEMP"),
60+
pytest.param("temperature", "TEMP", marks=pytest.mark.xfail),
6161
pytest.param("ftemperature", "TEMP", marks=pytest.mark.xfail),
6262
],
6363
)

test/drivers/test_siglent_spd_3303X.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ def test_measure_voltage(pps, channel, query, voltage):
154154
time.sleep(1) # Slow PPS again
155155
v = ch.measure.voltage()
156156
ch(False) # Channel ON
157-
assert float(v) == pytest.approx(voltage, abs=10e-3)
157+
assert float(v) == pytest.approx(voltage, abs=50e-3)
158158

159159

160160
# Need to use the patch jig to test any current other than 0.

0 commit comments

Comments
 (0)