Skip to content

Commit a0d050d

Browse files
mmckyclaude
andcommitted
ci: bump Node to 20 for css-minimizer-webpack-plugin@8 engine requirement
css-minimizer-webpack-plugin@8 and serialize-javascript@7 require Node >= 20. Bumps sphinx-theme-builder's nodeenv pin from 18.18.0 to 20.18.0 and the matching setup-node version across CI/docs/update-snapshots workflows. Without this, the editable install fails with 'ReferenceError: crypto is not defined' inside serialize-javascript. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent b42948b commit a0d050d

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
- name: Setup Node.js
4444
uses: actions/setup-node@v6
4545
with:
46-
node-version: '18'
46+
node-version: '20'
4747
cache: 'npm'
4848
- name: Install Playwright
4949
run: |

.github/workflows/docs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
- name: Set up Node.js
3535
uses: actions/setup-node@v6
3636
with:
37-
node-version: "18"
37+
node-version: "20"
3838
cache: "npm"
3939

4040
- name: Install Node.js dependencies and build assets

.github/workflows/update-snapshots.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
- name: Setup Node.js
6363
uses: actions/setup-node@v6
6464
with:
65-
node-version: '18'
65+
node-version: '20'
6666
cache: 'npm'
6767

6868
- name: Install Playwright
@@ -169,7 +169,7 @@ jobs:
169169
- name: Setup Node.js
170170
uses: actions/setup-node@v6
171171
with:
172-
node-version: '18'
172+
node-version: '20'
173173
cache: 'npm'
174174

175175
- name: Install Playwright

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ requires = ["sphinx-theme-builder >= 0.2.0a7"]
33
build-backend = "sphinx_theme_builder"
44

55
[tool.sphinx-theme-builder]
6-
node-version = "18.18.0"
6+
node-version = "20.18.0"
77
theme-name = "quantecon_book_theme"
88
additional-compiled-static-assets = [
99
"locales/"

0 commit comments

Comments
 (0)