FIX: Inline math collide#96
Conversation
|
Will do extensive cross-browser testing as this is a major tweak across all lectures. Hey @mmcky, any clues as to what I might have done incorrectly to cause pre-commit failure for me here? https://github.com/QuantEcon/quantecon-book-theme/pull/96/checks?check_run_id=2257589125 |
|
thanks @DrDrij -- let me know how you go with the cross-browser testing. @AakashGfude can you please update the pre-commit failure. |
|
thanks @AakashGfude |
|
@AakashGfude please go ahead and merge in |
…theme into inline-math-collide
|
thanks @AakashGfude for tidying this up. @DrDrij can you let me know when you're ready with the cross-platform checks. Thanks. |
|
@DrDrij I might merge this today and then do some testing on |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #96 +/- ##
=======================================
Coverage 73.12% 73.12%
=======================================
Files 2 2
Lines 227 227
=======================================
Hits 166 166
Misses 61 61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR changes the MathJax font size setting. Rather than using CSS we now set relative size (92%) using JS in the MathJax config. This is to hopefully fix the Safari rendering issue, where the element size was smaller than the rendered equation - causing overlaps (QuantEcon/lecture-python.myst#117).