Skip to content

FIX: Inline math collide#96

Merged
mmcky merged 3 commits into
QuantEcon:masterfrom
DrDrij:inline-math-collide
Apr 9, 2021
Merged

FIX: Inline math collide#96
mmcky merged 3 commits into
QuantEcon:masterfrom
DrDrij:inline-math-collide

Conversation

@DrDrij

@DrDrij DrDrij commented Apr 3, 2021

Copy link
Copy Markdown
Member

This PR changes the MathJax font size setting. Rather than using CSS we now set relative size (92%) using JS in the MathJax config. This is to hopefully fix the Safari rendering issue, where the element size was smaller than the rendered equation - causing overlaps (QuantEcon/lecture-python.myst#117).

@DrDrij

DrDrij commented Apr 3, 2021

Copy link
Copy Markdown
Member Author

Will do extensive cross-browser testing as this is a major tweak across all lectures.

Hey @mmcky, any clues as to what I might have done incorrectly to cause pre-commit failure for me here? https://github.com/QuantEcon/quantecon-book-theme/pull/96/checks?check_run_id=2257589125

@mmcky

mmcky commented Apr 5, 2021

Copy link
Copy Markdown
Contributor

thanks @DrDrij -- let me know how you go with the cross-browser testing.

@AakashGfude can you please update the pre-commit failure.

@AakashGfude

Copy link
Copy Markdown
Member

@mmcky the following PR should fix it #99 . we can update this branch after merging?

@mmcky

mmcky commented Apr 6, 2021

Copy link
Copy Markdown
Contributor

thanks @AakashGfude

@mmcky

mmcky commented Apr 7, 2021

Copy link
Copy Markdown
Contributor

@AakashGfude please go ahead and merge in main to update this branch. Thanks.

@mmcky mmcky changed the title Inline math collide FIX: Inline math collide Apr 7, 2021
@mmcky

mmcky commented Apr 7, 2021

Copy link
Copy Markdown
Contributor

thanks @AakashGfude for tidying this up. @DrDrij can you let me know when you're ready with the cross-platform checks. Thanks.

@mmcky

mmcky commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

@DrDrij I might merge this today and then do some testing on python.quantecon.org. It would be nice to have this fixed as the site is now live.

@mmcky mmcky merged commit b425870 into QuantEcon:master Apr 9, 2021
@codecov

codecov Bot commented Apr 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.12%. Comparing base (46c534e) to head (4544996).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   73.12%   73.12%           
=======================================
  Files           2        2           
  Lines         227      227           
=======================================
  Hits          166      166           
  Misses         61       61           
Flag Coverage Δ
pytests 73.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants