Skip to content

Commit 74e98a1

Browse files
Copilotaborgna-q
andauthored
ci: build qis-compiler Windows wheels on windows-2025 (#1974)
The `qis-compiler wheels (windows-2022)` job fails when linking `selene_hugr_qis_compiler.dll`, with `LNK1120: 11 unresolved externals` referenced from `libllvm_sys-*.rlib`: ``` libllvm_sys-*.rlib(SymbolSet.cpp.obj) : error LNK2001: unresolved external symbol __std_rotate libllvm_sys-*.rlib(DXILResource.cpp.obj) : error LNK2019: unresolved external symbol __std_min_element_4u libllvm_sys-*.rlib(StringRef.cpp.obj) : error LNK2019: unresolved external symbol __std_find_not_ch_1 ... ``` These `__std_*` symbols are the vectorized STL algorithm helpers provided by the MSVC runtime import libraries. The prebuilt LLVM shipped by hugrenv was compiled against a newer MSVC toolset than the 14.44 toolset available on the `windows-2022` image, so the symbols it references do not exist in that image's runtime libs. ### Changes - `.github/workflows/python-qis-wheels.yml`: switch the Windows entry of the wheel build matrix from `windows-2022` to `windows-2025`, which ships a newer MSVC toolset. This aligns with the runner already used for the Windows target in `python-wheels.yml`. - Added a short comment recording why the newer image is required, so a future downgrade isn't made accidentally. Note that the uploaded artifact name is derived from `matrix.os`, so it changes to `qis-compiler-wheels-windows-2025`; the release job merges all artifacts by path and is unaffected. Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: aborgna-q <121866228+aborgna-q@users.noreply.github.com>
1 parent 8eace06 commit 74e98a1

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

‎.github/workflows/python-qis-wheels.yml‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,10 @@ jobs:
4747
- ubuntu-24.04-arm
4848
- macos-15
4949
- macos-15-intel
50-
- windows-2022
50+
# `windows-2025` ships a newer MSVC toolset, required to link against
51+
# the prebuilt LLVM libraries (which need the vectorized STL symbols
52+
# `__std_rotate`, `__std_min_element_*`, `__std_unique_*`, ...).
53+
- windows-2025
5154
name: "qis-compiler wheels (${{matrix.os}})"
5255
runs-on: ${{ matrix.os }}
5356
steps:

0 commit comments

Comments
 (0)