ci: Cleanup change filters for CI triggers (#2034)

- Adds the workspace rust config to the changes that trigger pg-lib
checks
- Renames the `rust` and `rust-core` groups to `tket` and `tket-core`
- Triggers `rs-semver-checks` when `pg-libs` has changes, not just
`tket`
- drive-by: Re-enables the temporarily disabled `extension-versions`
required check

Author: aborgna-q

.github/actions/check-changes/action.yml

@@ -18,12 +18,15 @@ outputs:
   pg-libs:
     description: "The pg-libs crates or shared workspace configuration have changed"
     value: ${{ steps.override.outputs.out == 'true' || steps.change-filters.outputs.pg-libs == 'true' }}
-  rust:
-    description: "Rust files have changed"
-    value: ${{ steps.override.outputs.out == 'true' || steps.change-filters.outputs.rust == 'true' }}
   rust-core:
-    description: "The main tket rust library has changed"
+    description: "The shared Rust workspace configuration has changed"
     value: ${{ steps.override.outputs.out == 'true' || steps.change-filters.outputs.rust-core == 'true' }}
+  tket:
+    description: "The tket Rust crates or shared workspace configuration have changed"
+    value: ${{ steps.override.outputs.out == 'true' || steps.change-filters.outputs.tket == 'true' }}
+  tket-core:
+    description: "The main tket Rust library or shared workspace configuration has changed"
+    value: ${{ steps.override.outputs.out == 'true' || steps.change-filters.outputs.tket-core == 'true' }}
   python:
     description: "Python files have changed"
     value: ${{ steps.override.outputs.out == 'true' || steps.change-filters.outputs.python == 'true' }}

.github/change-filters.yml

@@ -2,14 +2,17 @@
 # to detect changes in each subproject, and only run the corresponding jobs.
 
 rust-core: &rust-core
-  - "tket/tket-rs/**"
   - "Cargo.toml"
   - "Cargo.lock"
   - "rust-toolchain.toml"
   - "hugrenv.lock"
 
-rust:
+tket-core: &tket-core
   - *rust-core
+  - "tket/tket-rs/**"
+
+tket:
+  - *tket-core
   - "tket/tket-qsystem/**"
   - "tket/badger-optimiser/**"
   - "tket/compile-rewriter/**"
@@ -18,17 +21,15 @@ rust:
   - "tket/qis-compiler/Cargo.toml"
 
 pg-libs:
+  - *rust-core
   - "pg-libs/**"
   - "justfile"
   - "devenv.nix"
-  - "Cargo.toml"
-  - "Cargo.lock"
-  - "rust-toolchain.toml"
   - "pyproject.toml"
   - "uv.lock"
 
 python:
-  - *rust-core
+  - *tket-core
   - "test_files/**"
   - "tket/tket-py/**"
   - "tket/tket-eccs/**"
@@ -37,7 +38,7 @@ python:
   - "uv.lock"
 
 qis:
-  - *rust-core
+  - *tket-core
   - "tket/qis-compiler/**"
   - "pyproject.toml"
   - "uv.lock"

.github/workflows/ci.yml

@@ -34,7 +34,7 @@ jobs:
       pull-requests: read
     outputs:
       pg-libs: ${{ steps.filter.outputs.pg-libs }}
-      rust: ${{ steps.filter.outputs.rust }}
+      tket: ${{ steps.filter.outputs.tket }}
       python: ${{ steps.filter.outputs.python }}
       extensions: ${{ steps.filter.outputs.extensions }}
       qis: ${{ steps.filter.outputs.qis }}
@@ -46,7 +46,7 @@ jobs:
   check-rs:
     name: Check Rust code 🦀
     needs: [changes]
-    if: ${{ needs.changes.outputs.rust == 'true' }}
+    if: ${{ needs.changes.outputs.tket == 'true' }}
     runs-on: ubuntu-latest
     env:
       # Fail on rust compiler warnings.
@@ -204,7 +204,7 @@ jobs:
   benches:
     name: Continuous benchmarking 🏋️
     needs: changes
-    if: ${{ needs.changes.outputs.rust == 'true' && github.event_name != 'merge_group' }}
+    if: ${{ needs.changes.outputs.tket == 'true' && github.event_name != 'merge_group' }}
     runs-on: ubuntu-latest
     permissions:
       checks: write
@@ -233,7 +233,7 @@ jobs:
   # Run tests on Rust stable
   tests-rs-stable-no-features:
     needs: changes
-    if: ${{ needs.changes.outputs.rust == 'true' }}
+    if: ${{ needs.changes.outputs.tket == 'true' }}
     runs-on: ubuntu-latest
     name: tests (Rust stable, no features)
     steps:
@@ -255,7 +255,7 @@ jobs:
   # Run tests on Rust stable
   tests-rs-stable-all-features:
     needs: [changes]
-    if: ${{ needs.changes.outputs.rust == 'true' }}
+    if: ${{ needs.changes.outputs.tket == 'true' }}
     runs-on: ubuntu-latest
     name: tests (Rust stable, all features)
     steps:
@@ -279,7 +279,7 @@ jobs:
   # Run tests on other toolchains
   tests-rs-other:
     needs: [changes]
-    if: ${{ needs.changes.outputs.rust == 'true' && github.event_name != 'merge_group' }}
+    if: ${{ needs.changes.outputs.tket == 'true' && github.event_name != 'merge_group' }}
     runs-on: ubuntu-latest
     strategy:
       fail-fast: true
@@ -314,7 +314,7 @@ jobs:
   tests-nightly-coverage:
     needs: [changes]
     # Run only if there are changes in the relevant files
-    if: ${{ needs.changes.outputs.rust == 'true' && github.event_name != 'merge_group' }}
+    if: ${{ needs.changes.outputs.tket == 'true' && github.event_name != 'merge_group' }}
     runs-on: ubuntu-latest
     name: tests (Rust nightly, coverage)
     steps:
@@ -349,7 +349,7 @@ jobs:
   # Run tests on the minimum supported rust version, with minimal dependency versions
   tests-msrv:
     needs: changes
-    if: ${{ needs.changes.outputs.rust == 'true' && github.event_name != 'merge_group' }}
+    if: ${{ needs.changes.outputs.tket == 'true' && github.event_name != 'merge_group' }}
     runs-on: ubuntu-latest
     name: tests (Rust MSRV, min dependencies)
     steps:
@@ -468,7 +468,7 @@ jobs:
   # Ensure that serialized extensions match rust implementation
   tket-extensions:
     needs: [changes, tests-rs-stable-all-features]
-    if: ${{ needs.changes.outputs.rust == 'true' && github.event_name != 'merge_group' }}
+    if: ${{ needs.changes.outputs.tket == 'true' && github.event_name != 'merge_group' }}
     name: Check standard extensions
     runs-on: ubuntu-latest
     steps:
@@ -524,7 +524,8 @@ jobs:
   # even if they are skipped due to no changes in the relevant files.
   required-checks:
     name: Required checks 🦀+🐍
-    needs: [
+    needs:
+      [
         changes,
         check-pg-libs-rs,
         check-pg-libs-py,
@@ -536,16 +537,19 @@ jobs:
         tests-rs-stable-all-features,
         tests-py,
         tket-extensions,
-        #extension-versions,
+        extension-versions,
         tests-qis-compiler,
       ]
     if: ${{ !cancelled() }}
     runs-on: ubuntu-latest
     steps:
       - name: Debug changes step output
         run: |
-          echo "Rust: ${{ needs.changes.outputs.rust }}"
-          echo "Python: ${{ needs.changes.outputs.python }}"
+          echo "pg-libs: ${{ needs.changes.outputs.pg-libs }}"
+          echo "tket: ${{ needs.changes.outputs.tket }}"
+          echo "python: ${{ needs.changes.outputs.python }}"
+          echo "extensions: ${{ needs.changes.outputs.extensions }}"
+          echo "qis: ${{ needs.changes.outputs.qis }}"
       - name: Fail if required checks failed
         if: ${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') }}
         run: |

.github/workflows/semver-checks.yml

@@ -20,16 +20,16 @@ jobs:
     permissions:
       pull-requests: read
     outputs:
-      rust: ${{ steps.filter.outputs.rust }}
-      python: ${{ steps.filter.outputs.python }}
+      pg-libs: ${{ steps.filter.outputs.pg-libs }}
+      tket: ${{ steps.filter.outputs.tket }}
     steps:
       - uses: actions/checkout@v7
       - uses: ./.github/actions/check-changes
         id: filter
 
   rs-semver-checks:
     needs: [changes]
-    if: ${{ needs.changes.outputs.rust == 'true' }}
+    if: ${{ needs.changes.outputs.tket == 'true' || needs.changes.outputs.pg-libs == 'true' }}
     runs-on: ubuntu-latest
     env:
       # Path to the cached tket-c-api library