Skip to content

Commit 8528140

Browse files
committed
Fix qvm-service names
'@' is not allowed character in qvm-service, use '-' instead. Plus, make the default service react to the plain 'dummy-psu' name, as set by the salt formula.
1 parent 6f1e246 commit 8528140

5 files changed

Lines changed: 11 additions & 4 deletions

File tree

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,4 +47,5 @@ install:
4747
install -m 755 receiver/20-dummy-psu.sh $(DESTDIR)/etc/qubes/post-install.d
4848
install -m 755 receiver/qubes-psu-client $(DESTDIR)/usr/bin
4949
install -m 644 receiver/qubes-psu-client@.service receiver/module-load-dummy-psu.service $(DESTDIR)/usr/lib/systemd/system
50+
install -D -m 644 receiver/qubes-psu-client@default.service-default.conf \
5051
$(DESTDIR)/usr/lib/systemd/system/qubes-psu-client@default.service.d/30-default.conf

dummy-psu.spec.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ make client
7474
/etc/qubes/post-install.d/20-dummy-psu.sh
7575
/usr/bin/qubes-psu-client
7676
/usr/lib/systemd/system/qubes-psu-client@.service
77+
/usr/lib/systemd/system/qubes-psu-client@default.service.d/30-default.conf
7778
/usr/lib/systemd/system/module-load-dummy-psu.service
7879

7980

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[Unit]
22
Description=Dummy psu module loader service
3-
ConditionPathExistsGlob=/var/run/qubes-service/dummy-psu@*
3+
ConditionPathExistsGlob=/var/run/qubes-service/dummy-psu*
44

55
[Service]
66
Type=oneshot
@@ -9,4 +9,4 @@ ExecStart=/sbin/modprobe dummy-psu
99
ExecStop=/sbin/rmmod dummy-psu
1010

1111
[Install]
12-
WantedBy=multi-user.target
12+
WantedBy=multi-user.target

receiver/qubes-psu-client@.service

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
[Unit]
22
Description=Dummy power supply client service
3-
ConditionPathExists=/var/run/qubes-service/dummy-psu@%i
3+
ConditionPathExists=/var/run/qubes-service/dummy-psu-%i
44
After=qubes-qrexec-agent.service module-load-dummy-psu.service
55

66
[Service]
77
ExecStart=/usr/bin/qubes-psu-client %i
88

99
[Install]
10-
WantedBy=multi-user.target
10+
WantedBy=multi-user.target
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
[Unit]
2+
# replace /var/run/qubes-service/dummy-psu-default with just
3+
# /var/run/qubes-service/dummy-psu
4+
ConditionPathExists=
5+
ConditionPathExists=/var/run/qubes-service/dummy-psu

0 commit comments

Comments
 (0)