In the SiegeConsequences method in BKSettlementBehaviour class, an infinite loop could occur when attempting to reduce the population after a siege, resulting the game freezing. This happened due to a specific edge case in population type selection:

1. The game selects which population type to decrease using weighted random selection.
2. One of the population types had a weight of 0, meaning it could never be chosen.
3. All other types had non-zero weights but had a population count of 0.
4. Since ChooseWeighted() only picks from weighted options, it never selected the only type that had remaining population.
5. This resulted in an infinite loop where finalNum = 0 every iteration, preventing toKill from decreasing.

weights is apparently derived from demand, and it is possible for a type to have 0 from the returned number

example of values of this case hapenning from debugger

The fix changes the way population is decreased. Instead of iteratively, now the kill distribution is calculated based on the weight proportions of each population type, still adhering to weights used before. Previously, If a population type runs out, the while loop continues which contributes to the issue discussed above. Now instead of loop, any unallocated kills due to low population counts (i.e. when kill for a type is more than that type count) are redistributed proportionally across all remaining population classes, to deal with edge cases like above.