Skip to content

Commit 9de4799

Browse files
lumachadclaude
andcommitted
Add extended testing support with testing:extended label
Add support for triggering extended test suite when testing:extended label is added to a PR. Five additional test jobs run serially after the standard build, each with different test options: --parallel, --optimization=-O3, --check-type check-read1, --check-type check-readmore, and a HIP board test with --runtestflags=--target_board=hip --tests gdb.base/break.exp. Extended test jobs use `if: success() || failure()` to ensure all tests run even if one fails, while still showing which tests failed in the UI. This provides complete test coverage on demand without slowing down the standard CI pipeline. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent ae20ab8 commit 9de4799

1 file changed

Lines changed: 86 additions & 0 deletions

File tree

.github/workflows/therock-ci.yml

Lines changed: 86 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ on:
66
- amd-staging
77
- amd-staging-rocgdb-*
88
pull_request:
9+
types: [opened, synchronize, reopened, labeled]
910
branches:
1011
- amd-staging
1112
- amd-staging-rocgdb-*
@@ -60,12 +61,97 @@ jobs:
6061
-DTHEROCK_USE_EXTERNAL_ROCGDB=ON
6162
-DTHEROCK_ROCGDB_SOURCE_DIR=./rocgdb_under_test
6263
64+
extended-test-check-read1:
65+
name: "--check-type check-read1"
66+
if: (success() || failure()) && github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'testing:extended')
67+
needs: extended-test-optimization
68+
permissions:
69+
contents: read
70+
id-token: write
71+
uses: ./.github/workflows/therock-test-packages.yml
72+
secrets: inherit
73+
with:
74+
amdgpu_families: gfx94X-dcgpu
75+
artifact_group: gfx94X-dcgpu
76+
test_runs_on: linux-gfx942-1gpu-ossci-rocm
77+
artifact_run_id: ${{ github.run_id }}
78+
test_options: "--check-type check-read1 --parallel"
79+
80+
extended-test-check-readmore:
81+
name: "--check-type check-readmore"
82+
if: (success() || failure()) && github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'testing:extended')
83+
needs: extended-test-check-read1
84+
permissions:
85+
contents: read
86+
id-token: write
87+
uses: ./.github/workflows/therock-test-packages.yml
88+
secrets: inherit
89+
with:
90+
amdgpu_families: gfx94X-dcgpu
91+
artifact_group: gfx94X-dcgpu
92+
test_runs_on: linux-gfx942-1gpu-ossci-rocm
93+
artifact_run_id: ${{ github.run_id }}
94+
test_options: "--check-type check-readmore --parallel"
95+
96+
extended-test-parallel:
97+
name: "--parallel"
98+
if: github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'testing:extended')
99+
needs: therock-ci-linux
100+
permissions:
101+
contents: read
102+
id-token: write
103+
uses: ./.github/workflows/therock-test-packages.yml
104+
secrets: inherit
105+
with:
106+
amdgpu_families: gfx94X-dcgpu
107+
artifact_group: gfx94X-dcgpu
108+
test_runs_on: linux-gfx942-1gpu-ossci-rocm
109+
artifact_run_id: ${{ github.run_id }}
110+
test_options: "--parallel"
111+
112+
extended-test-hip-board:
113+
name: "hip board gdb.base/break.exp"
114+
if: (success() || failure()) && github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'testing:extended')
115+
needs: extended-test-check-readmore
116+
permissions:
117+
contents: read
118+
id-token: write
119+
uses: ./.github/workflows/therock-test-packages.yml
120+
secrets: inherit
121+
with:
122+
amdgpu_families: gfx94X-dcgpu
123+
artifact_group: gfx94X-dcgpu
124+
test_runs_on: linux-gfx942-1gpu-ossci-rocm
125+
artifact_run_id: ${{ github.run_id }}
126+
test_options: "--runtestflags=--target_board=hip --tests gdb.base/break.exp"
127+
128+
extended-test-optimization:
129+
name: "--optimization=-O3"
130+
if: (success() || failure()) && github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'testing:extended')
131+
needs: extended-test-parallel
132+
permissions:
133+
contents: read
134+
id-token: write
135+
uses: ./.github/workflows/therock-test-packages.yml
136+
secrets: inherit
137+
with:
138+
amdgpu_families: gfx94X-dcgpu
139+
artifact_group: gfx94X-dcgpu
140+
test_runs_on: linux-gfx942-1gpu-ossci-rocm
141+
artifact_run_id: ${{ github.run_id }}
142+
test_options: "--optimization=-O3 --max-failed-retries=0 --parallel"
143+
63144
therock_ci_summary:
64145
name: TheRock CI Summary
65146
if: always()
66147
needs:
67148
- setup
68149
- therock-ci-linux
150+
- extended-test-check-read1
151+
- extended-test-check-readmore
152+
- extended-test-parallel
153+
- extended-test-hip-board
154+
- extended-test-optimization
69155
runs-on: ubuntu-24.04
70156
steps:
71157
- name: Output failed jobs

0 commit comments

Comments
 (0)