Skip to content

Commit 41013ff

Browse files
Jim Wuclaude
andcommitted
ci(gfx11): use "multiarch" spelling in comments and scripts
Follow-up to the package rename: drop the hyphenated "multi-arch" prose in comments, echoes, and the release body for one consistent spelling. The upstream nightlies endpoint (tarball-multi-arch) and the therock-dist-linux- multiarch- filenames are external names and left untouched. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
1 parent 2079b94 commit 41013ff

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

.github/workflows/build-gfx11-rocm.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
build-ubuntu:
3434
runs-on: ubuntu-24.04
3535
# Single multiarch build: one fat binary covering all current CI arches,
36-
# sourced from TheRock's multi-arch tarball (arch-neutral host + per-arch
36+
# sourced from TheRock's multiarch tarball (arch-neutral host + per-arch
3737
# Tensile DBs). gfx1100-1103 (RDNA3 desktop + Hawk Point/Phoenix 760M/780M),
3838
# gfx1150/1151/1153 (RDNA3.5 Strix APUs).
3939
env:
@@ -71,14 +71,14 @@ jobs:
7171
ninja --version
7272
echo "Build dependencies installation completed"
7373
74-
- name: Download and extract multi-arch ROCm directly to /opt/rocm
74+
- name: Download and extract multiarch ROCm directly to /opt/rocm
7575
run: |
7676
rocm_version="${{ env.ROCM_VERSION }}"
7777
base_url="https://rocm.nightlies.amd.com/tarball-multi-arch"
7878
7979
if [ "$rocm_version" = "latest" ]; then
80-
echo "Auto-detecting latest multi-arch ROCm version"
81-
# The multi-arch host serves an HTML index (not S3 XML); scrape the
80+
echo "Auto-detecting latest multiarch ROCm version"
81+
# The multiarch host serves an HTML index (not S3 XML); scrape the
8282
# multiarch tarball names from it.
8383
files=$(curl -s "$base_url/" \
8484
| grep -oE 'therock-dist-linux-multiarch-[0-9]+\.[0-9]+\.[0-9]+(a|rc)[0-9]+\.tar\.gz' \
@@ -144,7 +144,7 @@ jobs:
144144
rocm_url="$base_url/therock-dist-linux-multiarch-${rocm_version}.tar.gz"
145145
echo "DETECTED_ROCM_VERSION=$rocm_version" >> $GITHUB_ENV
146146
147-
# The multi-arch tarball (~11.5 GB) ships device code for ALL 26 GPU
147+
# The multiarch tarball (~11.5 GB) ships device code for ALL 26 GPU
148148
# arches: every arch's .kpack plus per-arch rocBLAS/hipBLASLt Tensile DBs.
149149
# This consumer build only needs the 7 RDNA3/3.5 arches in GPU_TARGETS and
150150
# uses the GEMM (Tensile) path, which works without .kpack files. So we
@@ -163,7 +163,7 @@ jobs:
163163
excludes+=("--exclude=./lib/*/library/*${a}*")
164164
done
165165
166-
echo "Streaming multi-arch ROCm from: $rocm_url (pruning .kpack + non-target arches)"
166+
echo "Streaming multiarch ROCm from: $rocm_url (pruning .kpack + non-target arches)"
167167
sudo mkdir -p /opt/rocm
168168
curl -sL "$rocm_url" | sudo tar --use-compress-program=gzip -xf - \
169169
-C /opt/rocm --strip-components=1 "${excludes[@]}"
@@ -327,7 +327,7 @@ jobs:
327327
needs: build-ubuntu
328328
if: needs.build-ubuntu.result == 'success'
329329
# Single hardware test of the multiarch artifact on gfx1151. This is the
330-
# end-to-end safety net for the Tensile-only multi-arch package: a real
330+
# end-to-end safety net for the Tensile-only multiarch package: a real
331331
# llama-cli inference exercising the rocBLAS/hipBLASLt GEMM path on-device.
332332
runs-on: linux-gfx1151-gpu-rocm
333333

@@ -535,9 +535,9 @@ jobs:
535535
--notes "**Build**: $TAG
536536
**OS**: ubuntu
537537
**GPU Target(s)**: gfx1100, gfx1101, gfx1102, gfx1103, gfx1150, gfx1151, gfx1153 (single multiarch binary)
538-
**ROCm Version**: $ROCM_VERSION (multi-arch)
538+
**ROCm Version**: $ROCM_VERSION (multiarch)
539539
**Llama.cpp Commit**: $LLAMACPP_COMMIT_HASH
540540
**Build Date**: $(date -u '+%Y-%m-%d %H:%M:%S UTC')
541541
542-
Prebuilt llama.cpp ROCm binaries — one multiarch package covering the RDNA3 gfx110X family incl. Hawk Point/Phoenix (Radeon 760M/780M) and the RDNA3.5 gfx115x APUs (gfx1150/gfx1151/gfx1153). Built from TheRock's multi-arch ROCm runtime, pruned to the CI target arches (per-arch Tensile databases bundled)." \
542+
Prebuilt llama.cpp ROCm binaries — one multiarch package covering the RDNA3 gfx110X family incl. Hawk Point/Phoenix (Radeon 760M/780M) and the RDNA3.5 gfx115x APUs (gfx1150/gfx1151/gfx1153). Built from TheRock's multiarch ROCm runtime, pruned to the CI target arches (per-arch Tensile databases bundled)." \
543543
*.tar.gz

0 commit comments

Comments
 (0)