Fix(io): track RDMA notification completions in transfer status#434
Open
amd-dlimpus wants to merge 2 commits into
Open
Fix(io): track RDMA notification completions in transfer status#434amd-dlimpus wants to merge 2 commits into
amd-dlimpus wants to merge 2 commits into
Conversation
When transfer chunking rewrites batch accounting from request count to final WR count, keep the notification SEND completions in the total so success cannot be skipped or reported early when CQEs arrive out of order. Signed-off-by: dlimpus <dlimpus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Mori can use a separate network message to tell the remote side that a data transfer has finished. Before this change, a transfer could be marked successful as soon as the data write completed, even though that completion message was still in progress.
That created a race: the sender could report success, but the receiver might never get the completion message if that later send failed. In that case, both sides could disagree about whether the transfer was actually complete.
Technical Details
This change makes the data write and its completion message part of the same tracked operation.
The transfer is now marked successful only after both pieces have completed:
If sending the completion message fails, the transfer status is updated as a failure instead of being left as a prior success.
The implementation reuses the existing submission tracking path for completion-message sends, so these sends are handled the same way as other network work requests. A small fallback remains for older completion-message identifiers.
Test Plan
Added a focused C++ regression test that verifies:
Also ran editor diagnostics on the touched files.
Test Result
Editor diagnostics passed.
A local C++ syntax check could not complete in this environment because a required Boost header is missing:
boost/predef/other/endian.h.Submission Checklist