fix(gossip): validate attestations against attestation slot state

Author: perfogic

crates/networking/manager/src/gossipsub/handle.rs

@@ -134,10 +134,13 @@ async fn import_gossip_attestation(
     let (attestation, should_process_attestation) = {
         let store = beacon_chain.store.lock().await;
         let head_root = store.get_head()?;
-        let state =
+        let mut state =
             store.db.state_provider().get(head_root)?.ok_or_else(|| {
                 anyhow::anyhow!("No beacon state found for head root: {head_root}")
             })?;
+        if state.slot < single_attestation.data.slot {
+            state.process_slots(single_attestation.data.slot)?;
+        }
         let attestation = single_attestation_to_attestation(single_attestation, &state)?;
 
         store

crates/networking/manager/src/gossipsub/validate/beacon_attestation.rs

@@ -25,12 +25,26 @@ pub async fn validate_beacon_attestation(
     let store = beacon_chain.store.lock().await;
 
     let head_root = store.get_head()?;
-    let state: BeaconState = store
+    let mut state: BeaconState = store
         .db
         .state_provider()
         .get(head_root)?
         .ok_or_else(|| anyhow!("No beacon state found for head root: {head_root}"))?;
 
+    let current_slot = store.get_current_slot()?;
+
+    // [IGNORE] attestation.data.slot is equal to or earlier than the current_slot (with a
+    // MAXIMUM_GOSSIP_CLOCK_DISPARITY allowance)
+    if attestation.data.slot > current_slot {
+        return Ok(ValidationResult::Ignore(
+            "Attestation is from a future slot".to_string(),
+        ));
+    }
+
+    if state.slot < attestation.data.slot {
+        state.process_slots(attestation.data.slot)?;
+    }
+
     let committee_index = attestation.committee_index;
     let committees_per_slot = state.get_committee_count_per_slot(attestation.data.target.epoch);
 
@@ -58,27 +72,11 @@ pub async fn validate_beacon_attestation(
         ));
     }
 
-    let block = store
-        .db
-        .block_provider()
-        .get(head_root)?
-        .ok_or_else(|| anyhow!("Could not get block for head root: {head_root}"))?;
-
-    let current_slot = block.message.slot;
-
-    // [IGNORE] attestation.data.slot is equal to or earlier than the current_slot (with a
-    // MAXIMUM_GOSSIP_CLOCK_DISPARITY allowance)
-    if attestation.data.slot > current_slot {
-        return Ok(ValidationResult::Ignore(
-            "Attestation is from a future slot".to_string(),
-        ));
-    }
-
     // [IGNORE] the epoch of attestation.data.slot is either the current or previous epoch (with a
     // MAXIMUM_GOSSIP_CLOCK_DISPARITY allowance)
     let attestation_epoch = compute_epoch_at_slot(attestation.data.slot);
-    let current_epoch = state.get_current_epoch();
-    let previous_epoch = state.get_previous_epoch();
+    let current_epoch = compute_epoch_at_slot(current_slot);
+    let previous_epoch = current_epoch.saturating_sub(1);
 
     if attestation_epoch != current_epoch && attestation_epoch != previous_epoch {
         return Ok(ValidationResult::Ignore(