fix tests

Author: cekk

src/design/plone/policy/restapi/form_data/csv.py

@@ -1,4 +1,6 @@
-from collective.volto.formsupport.restapi.services.form_data.csv import FormDataExportGet as BaseFormDataExportGet
+from collective.volto.formsupport.restapi.services.form_data.csv import (
+    FormDataExportGet as BaseFormDataExportGet,
+)
 from io import StringIO
 
 import csv

src/design/plone/policy/restapi/submit_form/post.py

@@ -1,6 +1,8 @@
 from collective.volto.formsupport import _
 from collective.volto.formsupport.interfaces import IFormDataStore
-from collective.volto.formsupport.restapi.services.submit_form.post import SubmitPost as BaseSubmitPost
+from collective.volto.formsupport.restapi.services.submit_form.post import (
+    SubmitPost as BaseSubmitPost,
+)
 from plone import api
 from zExceptions import BadRequest
 from zope.component import getMultiAdapter
@@ -12,7 +14,6 @@ def reply(self):
         Append waiting_list to response
         """
         res = super().reply()
-
         submit_limit = int(self.block.get("limit", "-1"))  # this is the patch
         waiting_list = (
             submit_limit is not None and -1 < submit_limit < self.count_data()

src/design/plone/policy/testing.py

@@ -40,7 +40,6 @@ def setUpZope(self, app, configurationContext):
         # layer.
 
         super().setUpZope(app, configurationContext)
-        self.loadZCML(package=design.plone.policy)
         self.loadZCML(package=collective.feedback)
         self.loadZCML(package=collective.volto.formsupport)
         self.loadZCML(package=collective.volto.dropdownmenu)
@@ -56,6 +55,7 @@ def setUpZope(self, app, configurationContext):
         self.loadZCML(package=souper.plone)
         self.loadZCML(package=redturtle.faq)
         self.loadZCML(package=collective.volto.contactsblock)
+        self.loadZCML(package=design.plone.policy)
 
     def setUpPloneSite(self, portal):
         super().setUpPloneSite(portal)
@@ -102,9 +102,6 @@ def setUpPloneSite(self, portal):
         super().setUpPloneSite(portal)
         request = portal.REQUEST
         setRequest(request)
-        import pdb
-
-        pdb.set_trace()
         applyProfile(portal, "design.plone.policy.limit_root_addables:default")
 
 
@@ -140,6 +137,7 @@ def setUpZope(self, app, configurationContext):
         self.loadZCML(package=souper.plone)
         self.loadZCML(package=redturtle.faq)
         self.loadZCML(package=collective.volto.contactsblock)
+        self.loadZCML(package=design.plone.policy)
 
     def setUpPloneSite(self, portal):
         super().setUpPloneSite(portal)

src/design/plone/policy/tests/test_limit_submit_form.py

@@ -1,4 +1,4 @@
-from collective.volto.formsupport.testing import VOLTO_FORMSUPPORT_API_FUNCTIONAL_TESTING  # noqa: E501,
+from design.plone.policy.testing import DESIGN_PLONE_POLICY_API_FUNCTIONAL_TESTING
 from plone import api
 from plone.app.testing import setRoles
 from plone.app.testing import SITE_OWNER_NAME
@@ -13,7 +13,7 @@
 
 
 class TestLimitMailStore(unittest.TestCase):
-    layer = VOLTO_FORMSUPPORT_API_FUNCTIONAL_TESTING
+    layer = DESIGN_PLONE_POLICY_API_FUNCTIONAL_TESTING
 
     def setUp(self):
         self.app = self.layer["app"]
@@ -113,6 +113,7 @@ def test_limit_submit(self):
         )
         transaction.commit()
         self.assertEqual(response.status_code, 200)
+
         self.assertTrue(response.json()["waiting_list"])
 
     def test_unique_field(self):
@@ -156,7 +157,10 @@ def test_unique_field(self):
         response = self.submit_form(data=data)
         transaction.commit()
 
-        self.assertEqual(response.status_code, 500)
+        self.assertEqual(response.status_code, 400)
         # test message is not fair because it's a translation, in another package
         message = response.json()["message"]
-        self.assertTrue("Value not unique" in message or "non sono univoci" in message)
+        self.assertEqual(
+            message,
+            'Unable to save data. The value of field "Name" is already stored in previous submissions.',
+        )

src/design/plone/policy/tests/test_setup.py

@@ -1,7 +1,9 @@
 # -*- coding: utf-8 -*-
 """Setup tests for this package."""
 from design.plone.policy.testing import DESIGN_PLONE_POLICY_INTEGRATION_TESTING
-from design.plone.policy.testing import DESIGN_PLONE_POLICY_LIMIT_ROOT_ADDABLES_INTEGRATION_TESTING
+from design.plone.policy.testing import (
+    DESIGN_PLONE_POLICY_LIMIT_ROOT_ADDABLES_INTEGRATION_TESTING,
+)
 from plone import api
 from plone.app.testing import setRoles
 from plone.app.testing import TEST_USER_ID