fix(ApexChainx#244): address review feedback - use should_panic for test, fix accept_admin/accept_operator auth classification

Author: iyanumajekodunmi756

apexchainx_calculator/src/lib.rs

@@ -1639,8 +1639,11 @@ impl SLACalculatorContract {
 
         // All public methods added in alphabetical order for deterministic output.
         // Lifecycle:
-        methods.push_back(method("accept_admin", true, "admin", "adm_acc"));
-        methods.push_back(method("accept_operator", true, "operator", "op_acc"));
+        // Note: accept_admin/accept_operator are called by the proposed address
+        // (not the current role holder), so auth is "none" — only an address
+        // equality check against the pending slot is performed.
+        methods.push_back(method("accept_admin", true, "none", "adm_acc"));
+        methods.push_back(method("accept_operator", true, "none", "op_acc"));
         // Calculation:
         methods.push_back(method("calculate_sla", true, "operator", "sla_calc"));
         methods.push_back(method("calculate_sla_view", false, "none", ""));

apexchainx_calculator/src/tests.rs

@@ -7386,15 +7386,14 @@ fn test_get_public_api_is_deterministic() {
 }
 
 #[test]
+#[test]
+#[should_panic]
 fn test_get_public_api_requires_initialization() {
     let env = Env::default();
     env.mock_all_auths();
     let cid = env.register_contract(None, SLACalculatorContract);
     let client = SLACalculatorContractClient::new(&env, &cid);
 
-    // Without initialization, get_public_api should return NotInitialized error
-    let result = std::panic::catch_unwind(std::panic::AssertUnwindSafe(|| {
-        client.get_public_api();
-    }));
-    assert!(result.is_err(), "get_public_api should fail before initialization");
+    // Without initialization, get_public_api should panic with NotInitialized
+    client.get_public_api();
 }