bad boy createchannel punished and identity changed

changed a lot of the code inside create channel, created new func called channelisBeingCreated

Author: Nishikiyama

src/main/java/net/sacredlabyrinth/phaed/simpleclans/hooks/discord/DiscordHook.java

@@ -361,40 +361,67 @@ public Category createCategory() {
      * @throws CategoriesLimitException if categories reached the limit.
      * @throws ChannelsLimitException   if discord reached the channels limit.
      */
-    public void createChannel(@NotNull String clanTag)
-            throws InvalidChannelException, CategoriesLimitException, ChannelsLimitException, ChannelExistsException {
-        validateChannel(clanTag);
-        Map<ClanPlayer, Member> discordClanPlayers = getDiscordPlayers(clanManager.getClan(clanTag));
-
-        if (getChannels().size() >= settingsManager.getInt(DISCORDCHAT_TEXT_LIMIT)) {
-            throw new ChannelsLimitException("Discord reached the channels limit", "discord.reached.channels.limit");
-        }
-
-        Category availableCategory = getCachedCategories().stream().
-                filter(category -> category.getTextChannels().size() < MAX_CHANNELS_PER_CATEGORY).
-                findAny().orElseGet(this::createCategory);
-
-        if (availableCategory == null) {
-            throw new CategoriesLimitException("Discord reached the categories limit", "discord.reached.category.limit");
-        }
-
-        try {
-            availableCategory.createTextChannel(clanTag).complete();
-            SimpleClans.debug(String.format("[%s] Creating a discord text channel for %s clan", Thread.currentThread().getId(), clanTag));
-        } catch (ErrorResponseException ex) {
-            Response response = ex.getResponse();
-            plugin.getLogger().warning(String.format("Could not create a channel for clan %s, error %d - %s",
-                    clanTag, response.code, response.message));
-            return;
-        }
-
-        for (Map.Entry<ClanPlayer, Member> entry : discordClanPlayers.entrySet()) {
-            // The map is formed from clan#getMembers (so the clan exists)
-            //noinspection ConstantConditions
-            updateViewPermission(entry.getValue(), entry.getKey().getClan(), ADD);
-            updateLeaderRole(entry.getValue(), entry.getKey(), ADD);
-        }
-    }
+    private final Set<String> channelIsBeingCreated = java.util.concurrent.ConcurrentHashMap.newKeySet();
+	public void createChannel(@NotNull String clanTag)
+			throws InvalidChannelException, CategoriesLimitException, ChannelsLimitException, ChannelExistsException {
+
+		// validate it, perchance it exists dont do anything just chill
+		if (channelExists(clanTag)) {
+			return;
+		}
+
+		// prevent duplicate creation (this might genuinely be useless but i felt like making it)
+		if (!channelIsBeingCreated.add(clanTag)) {
+			return;
+		}
+
+		try {
+
+			// double validation!!! 
+			if (channelExists(clanTag)) {
+				return;
+			}
+
+			validateChannel(clanTag);
+
+			Map<ClanPlayer, Member> discordClanPlayers = getDiscordPlayers(clanManager.getClan(clanTag));
+
+			if (getChannels().size() >= settingsManager.getInt(DISCORDCHAT_TEXT_LIMIT)) {
+				throw new ChannelsLimitException("Discord reached the channels limit", "discord.reached.channels.limit");
+			}
+
+			Category availableCategory = getCachedCategories().stream()
+					.filter(category -> category.getTextChannels().size() < MAX_CHANNELS_PER_CATEGORY)
+					.findAny()
+					.orElseGet(this::createCategory);
+
+			if (availableCategory == null) {
+				throw new CategoriesLimitException("Discord reached the categories limit", "discord.reached.category.limit");
+			}
+
+			TextChannel createdChannel;
+			try {
+				createdChannel = availableCategory.createTextChannel(clanTag).complete();
+				SimpleClans.debug(String.format("[%s] Creating a discord text channel for %s clan",
+						Thread.currentThread().getId(), clanTag));
+			} catch (ErrorResponseException ex) {
+				Response response = ex.getResponse();
+				plugin.getLogger().warning(String.format(
+						"Could not create a channel for clan %s, error %d - %s",
+						clanTag, response.code, response.message));
+				return;
+			}
+
+			for (Map.Entry<ClanPlayer, Member> entry : discordClanPlayers.entrySet()) {
+				updateViewPermission(entry.getValue(), entry.getKey().getClan(), ADD);
+				updateLeaderRole(entry.getValue(), entry.getKey(), ADD);
+			}
+
+		} finally {
+			// unlock channel creation for this clantag, perchance.
+			channelsBeingCreated.remove(clanTag);
+		}
+	}
 
     /**
      * Retrieves channel in SimpleClans categories.