JavaScript: Replace numerical capture groups

[stefanhaerter]

All RegExp static properties that expose the last match state globally are deprecated.

Source: MDN

See e.g.:

otobo/var/httpd/htdocs/js/Core.Agent.Admin.DynamicFieldDB.js

Lines 45 to 48 in 282ea49

	// get the number of the selector id and
	// use it as the select key
	/.*?_(\d+)/.exec(IDSelector);
	IdentifierKey = RegExp.$1;

otobo/var/httpd/htdocs/js/Core.Agent.DynamicFieldDBSearch.js

Lines 758 to 761 in 282ea49

	// Get field key and name by reg exp.
	/(\d+)_(.+)/.exec($('#SelectFieldList option:selected').val());
	FieldKey = RegExp.$1;
	FieldName = RegExp.$2;

Related to #4824

[stefanhaerter]

At time of writing, 3 files are affected in rel-10_1:

• var/httpd/htdocs/js/Core.Agent.Admin.DynamicFieldDB.js
• var/httpd/htdocs/js/Core.Agent.DynamicFieldDBSearch.js
• var/httpd/htdocs/js/Core.UI.Popup.js

[bschmalhofer]

Out of curiosity I looked up how the static accessors can be avoid. Looks like it is done in the same way as in Perl. exec and match return arrays. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/exec and https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/match .

[stefanhaerter]

Yes - we already have those in place in OTOBO. Decision was to postpone the task until after the upcoming release.