cli: error in Maint::Log::CommunicationLog lists unknown parameter

[73]

Environment

• OTOBO version: 11.0.16

Expected behavior

Options and Error message should fit.

Actual behavior

otobo@542227a0f0f6:~$ bin/otobo.Console.pl Maint::Log::CommunicationLog --force-delete --delete-by-hours-old 0
Management of communication logs.

Usage:
 otobo.Console.pl Maint::Log::CommunicationLog [--force-delete] [--purge] [--delete-by-hours-old ...] [--delete-by-date ...] [--delete-by-id ...] [--verbose]

Options:
 [--force-delete]               - Delete even if still processing.
 [--purge]                      - Purge successful communications older than a week and all communications older than a month. These durations are specified in SysConfig.
 [--delete-by-hours-old ...]    - Delete logs older than these number of hours. Example: --delete-by-hours-old="7"
 [--delete-by-date ...]         - Delete from specific date. Example: --delete-by-date="2001-12-01"
 [--delete-by-id ...]           - Delete logs from CommunicationID. Example: --delete-by-id="abcdefg12345"
 [--verbose]                    - Display debug information (can be used with --purge). Example: --purge --verbose
 [--help|h]                     - Display help for this command.
 [--no-ansi]                    - Do not perform ANSI terminal output coloring.
 [--quiet]                      - Suppress informative output, only retain error messages.

Error: Either --purge, --delete-by-id, --delete-by-date or --delete-by-days-old must be given!

The errors --delete-by-days-old is not listet in the options, should that be --delete-by-hours-old?

How to reproduce

Run the command with --delete-by-hours-old 0

[stefanhaerter]

I suppose that actually your value of 0 causes the problem, as the command expects true values for its options:

otobo/Kernel/System/Console/Command/Maint/Log/CommunicationLog.pm

Lines 82 to 85 in 75f3271

	my %Options;
	for my $Option (qw(delete-by-id delete-by-date delete-by-hours-old purge)) {
	$Options{$Option} = 1 if $Self->GetOption($Option);
	}

It should be discussed if a value of 0 is sensible and if so, it should be handled properly.

[stefanhaerter]

Updated the milestone to 10.1 as the respective code is already in place there.

[73]

I suppose that actually your value of 0 causes the problem, as the command expects true values for its options:

I think I did not make myself incredibly clear.
My problem is not whether the value of 0 is valid.
Try this: Please find all parameters given in the error message in the usage message.

[stefanhaerter]

How to reproduce

Run the command with --delete-by-hours-old 0

I did just that. But when I have time again, I'll give it a look