Skip to content

Commit 4468405

Browse files
committed
fix(desktop-release): don't pass empty APPLE_* — build unsigned (no Apple certs yet)
tauri-action tried 'security import' with an empty APPLE_CERTIFICATE and failed. The APPLE_* secrets aren't set up, so drop them and build an unsigned .dmg; re-add them when Apple notarization is configured.
1 parent ad4a537 commit 4468405

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

.github/workflows/desktop-release.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,13 @@ jobs:
6161
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6262
TAURI_SIGNING_PRIVATE_KEY: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY }}
6363
TAURI_SIGNING_PRIVATE_KEY_PASSWORD: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY_PASSWORD }}
64-
APPLE_CERTIFICATE: ${{ secrets.APPLE_CERTIFICATE }}
65-
APPLE_CERTIFICATE_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }}
66-
APPLE_SIGNING_IDENTITY: ${{ secrets.APPLE_SIGNING_IDENTITY }}
67-
APPLE_ID: ${{ secrets.APPLE_ID }}
68-
APPLE_PASSWORD: ${{ secrets.APPLE_PASSWORD }}
69-
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
64+
# Apple code-signing / notarization is intentionally OFF for now: the
65+
# APPLE_* secrets aren't set, and passing them EMPTY makes tauri-action
66+
# try `security import` with an empty cert and fail. Result: an UNSIGNED
67+
# .dmg (right-click → Open to bypass Gatekeeper). To enable notarized
68+
# builds later, add the APPLE_CERTIFICATE / APPLE_CERTIFICATE_PASSWORD /
69+
# APPLE_SIGNING_IDENTITY / APPLE_ID / APPLE_PASSWORD / APPLE_TEAM_ID
70+
# repository secrets and re-add them as env here (see docs/14-releases.md).
7071
with:
7172
projectPath: clients/desktop
7273
tagName: ${{ github.ref_name }}

0 commit comments

Comments
 (0)