Skip to content

Commit 92ac75d

Browse files
committed
fix(ios): unbreak Xcode Cloud archive — stop shipping a machine-local NODE_BINARY
The Release archive failed (exit 65) bundling JS: ios/.xcode.env.local was committed and pinned NODE_BINARY to a path that only exists on one dev's Mac (/Users/.../.nvm/.../node). RN's "Bundle React Native code and images" phase sources .xcode.env then .xcode.env.local, so on the CI runner it used the dead path and couldn't find node. (Builds locally because that path is real there.) - Untrack .xcode.env.local (git rm --cached; it's already in .gitignore and stays on disk for local builds). CI now uses .xcode.env's command -v node. - Symlink node@22 into /usr/local/bin in ci_post_clone.sh so the build phase can actually resolve it — node@22 is keg-only and off the phase's PATH. Mirrors the existing Go 1.22 symlink.
1 parent b9aa936 commit 92ac75d

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

clients/mobile/ios/.xcode.env.local

Lines changed: 0 additions & 1 deletion
This file was deleted.

clients/mobile/ios/ci_scripts/ci_post_clone.sh

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,14 @@ brew install node@22 || true
1313
export PATH="$(brew --prefix node@22)/bin:$PATH"
1414
corepack enable
1515

16+
# node@22 is keg-only, so it is NOT on the PATH the Xcode "Bundle React Native
17+
# code and images" build phase runs with. That phase sources ios/.xcode.env,
18+
# which resolves `command -v node` — so node must be findable at a stable path.
19+
# Symlink it into /usr/local/bin (already on the build-phase PATH; same trick as
20+
# the Go symlink below). Without this the Release archive fails to bundle JS.
21+
NODE22="$(brew --prefix node@22)/bin"
22+
ln -sf "$NODE22/node" /usr/local/bin/node || sudo ln -sf "$NODE22/node" /usr/local/bin/node || true
23+
1624
# --- shared core: the RN bundle imports @cumulusvpn/core via its built dist ---
1725
yarn install --immutable
1826
yarn workspace @cumulusvpn/core build

0 commit comments

Comments
 (0)