bug6232: added comment regarding instruction order in updateSettings

axeluhl · axeluhl · commit 88f051aa78ba · 2026-04-10T01:03:08.000+02:00
diff --git a/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/leaderboard/SingleRaceLeaderboardPanel.java b/java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/leaderboard/SingleRaceLeaderboardPanel.java
@@ -329,6 +329,8 @@ public SafeHtmlHeader getHeader() {
     
     @Override
     public void updateSettings(SingleRaceLeaderboardSettings newSettings) {
+        // Note: it's important to update showRaceRankColumn *before* calling super.updateSettings(newSettings)
+        // because the base class implementation then also ensures all columns are displayed according to settings 
         showRaceRankColumn = newSettings.isShowRaceRankColumn();
         super.updateSettings(newSettings);
     }

Original file line number	Diff line number	Diff line change
`@@ -329,6 +329,8 @@ public SafeHtmlHeader getHeader() {`
`329`	`329`
`330`	`330`	`@Override`
`331`	`331`	`public void updateSettings(SingleRaceLeaderboardSettings newSettings) {`
	`332`	`+ // Note: it's important to update showRaceRankColumn before calling super.updateSettings(newSettings)`
	`333`	`+ // because the base class implementation then also ensures all columns are displayed according to settings`
`332`	`334`	`showRaceRankColumn = newSettings.isShowRaceRankColumn();`
`333`	`335`	`super.updateSettings(newSettings);`
`334`	`336`	`}`