Relax the failure mode for missing releases

Author: eXpl0it3r

.github/workflows/release-clang-tools.yml

@@ -127,14 +127,26 @@ jobs:
         df -h /
 
     - name: Download clang-format and clang-tidy for ${{ matrix.llvm_tag }}
+      id: fetch
       if: steps.precheck.outputs.skip != 'true'
       env:
         GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         LLVM_TAG: ${{ matrix.llvm_tag }}
-      run: bash ./scripts/fetch-clang-tools.sh "${LLVM_TAG}" "artifacts/${LLVM_TAG}"
+      run: |
+        set +e
+        bash ./scripts/fetch-clang-tools.sh "${LLVM_TAG}" "artifacts/${LLVM_TAG}"
+        rc=$?
+        set -e
+        # Exit code 3 means upstream has not published this release yet. Not an
+        # error: leave the tag unprocessed so a later run picks it up.
+        if [ "${rc}" -eq 3 ]; then
+          echo "nothing_to_publish=true" >> "$GITHUB_OUTPUT"
+          exit 0
+        fi
+        exit "${rc}"
 
     - name: Publish release ${{ matrix.llvm_tag }}
-      if: steps.precheck.outputs.skip != 'true'
+      if: steps.precheck.outputs.skip != 'true' && steps.fetch.outputs.nothing_to_publish != 'true'
       env:
         GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         LLVM_TAG: ${{ matrix.llvm_tag }}

README.md

@@ -104,9 +104,10 @@ and, for each new one, runs the extraction script and publishes a release.
 2. Matches each target platform against a list of archive-name patterns, most preferred first
 3. Downloads the first match and pulls just `bin/clang-format` and `bin/clang-tidy` out of it
 
-A platform upstream never published is skipped quietly. A platform whose archive exists but
-yields no binary is a hard error, so a future rename fails the build loudly rather than
-producing an empty release.
+A platform upstream never published is skipped quietly.
+
+Set `STRICT=true` or `STRICT=false` to override the age heuristic, or `STRICT_WINDOW_DAYS`
+to move the cutoff.
 
 ## Maintenance
 

scripts/fetch-clang-tools.sh

@@ -26,6 +26,12 @@ VERSION=${LLVM_TAG#llvmorg-}
 
 TOOLS=(clang-format clang-tidy)
 
+# Distinct exit code when LLVM has not published a release yet
+EXIT_NO_RELEASE=3
+
+# A release younger than this is held to the strict error standard
+STRICT_WINDOW_DAYS=${STRICT_WINDOW_DAYS:-30}
+
 PLATFORMS=(linux-x64 linux-arm64 macos-x64 macos-arm64 windows-x64 windows-x86 windows-arm64)
 
 # Archive name patterns per platform, most preferred first. Matched as shell globs
@@ -93,21 +99,57 @@ WORK_DIR=$(mktemp -d)
 trap 'rm -rf "${WORK_DIR}"' EXIT
 
 echo "Reading asset list for ${LLVM_TAG}..."
+RELEASE_JSON="${WORK_DIR}/release.json"
 ASSET_LIST="${WORK_DIR}/assets.txt"
+
 if command -v gh >/dev/null 2>&1; then
-    gh api "repos/llvm/llvm-project/releases/tags/${LLVM_TAG}" -q '.assets[].name' > "${ASSET_LIST}"
+    if ! gh api "repos/llvm/llvm-project/releases/tags/${LLVM_TAG}" > "${RELEASE_JSON}" 2>/dev/null; then
+        echo "No GitHub release published for ${LLVM_TAG}; nothing to download."
+        exit ${EXIT_NO_RELEASE}
+    fi
 else
-    curl -sSL -H 'Accept: application/vnd.github+json' \
-        "https://api.github.com/repos/llvm/llvm-project/releases/tags/${LLVM_TAG}" |
-        grep -oE '"name": *"[^"]+"' | sed 's/.*": *"//; s/"$//' > "${ASSET_LIST}"
+    http_code=$(curl -sSL -H 'Accept: application/vnd.github+json' -w '%{http_code}' \
+        -o "${RELEASE_JSON}" \
+        "https://api.github.com/repos/llvm/llvm-project/releases/tags/${LLVM_TAG}")
+    if [ "${http_code}" = "404" ]; then
+        echo "No GitHub release published for ${LLVM_TAG}; nothing to download."
+        exit ${EXIT_NO_RELEASE}
+    fi
+fi
+
+# jq emits CRLF on Windows, which would leave a stray \r on every asset name and
+# stop the glob matching below from ever hitting. Strip it on every path.
+if command -v jq >/dev/null 2>&1; then
+    jq -r '.assets[].name' < "${RELEASE_JSON}" | tr -d '\r' > "${ASSET_LIST}"
+    published_at=$(jq -r '.published_at // empty' < "${RELEASE_JSON}" | tr -d '\r')
+else
+    # The download URL percent-encodes the + in clang+llvm-*, so decode it back.
+    grep -oE '"browser_download_url": *"[^"]+"' < "${RELEASE_JSON}" |
+        sed 's|.*/||; s/"$//; s/%2[Bb]/+/g' | tr -d '\r' > "${ASSET_LIST}"
+    published_at=$(grep -oE '"published_at": *"[^"]+"' < "${RELEASE_JSON}" |
+        head -1 | sed 's/.*": *"//; s/"$//' | tr -d '\r')
 fi
 
 if [ ! -s "${ASSET_LIST}" ]; then
-    echo "ERROR: no assets listed for ${LLVM_TAG}; is it a published release?" >&2
+    echo "ERROR: release ${LLVM_TAG} exists but lists no assets" >&2
     exit 1
 fi
 echo "Found $(wc -l < "${ASSET_LIST}") assets."
 
+# Severity depends on how recent the release is.
+if [ -z "${STRICT:-}" ]; then
+    STRICT=false
+    if [ -n "${published_at}" ]; then
+        published_epoch=$(date -u -d "${published_at}" +%s 2>/dev/null || echo "")
+        if [ -n "${published_epoch}" ]; then
+            age_days=$(( ( $(date -u +%s) - published_epoch ) / 86400 ))
+            echo "Release published ${age_days} day(s) ago."
+            [ "${age_days}" -le "${STRICT_WINDOW_DAYS}" ] && STRICT=true
+        fi
+    fi
+fi
+echo "Partial extraction is $([ "${STRICT}" = true ] && echo "fatal (recent release)" || echo "a warning (older release)")."
+
 # Pick the first asset matching one of the platform's patterns.
 select_asset() {
     local platform="$1" pattern asset
@@ -232,12 +274,21 @@ if [ -x "${OUTPUT_DIR}/clang-format-linux-x64" ] && [ "$(uname -s)-$(uname -m)"
     echo "smoke test: $("${OUTPUT_DIR}/clang-format-linux-x64" --version)"
 fi
 
-if [ ${#failed_platforms[@]} -gt 0 ]; then
-    echo "ERROR: archives existed but yielded no binaries for: ${failed_platforms[*]}" >&2
+if [ "${extracted_count}" -eq 0 ]; then
+    echo "ERROR: release ${LLVM_TAG} lists assets but no binaries could be extracted;" >&2
+    echo "       the archive naming patterns most likely need updating." >&2
     exit 1
 fi
 
-if [ "${extracted_count}" -eq 0 ]; then
-    echo "ERROR: no binaries extracted for ${LLVM_TAG}" >&2
-    exit 1
+if [ ${#failed_platforms[@]} -gt 0 ]; then
+    message="archives existed but yielded no binaries for: ${failed_platforms[*]}"
+    if [ "${STRICT}" = true ]; then
+        echo "ERROR: ${message}" >&2
+        echo "       This release is recent, so treating it as a regression." >&2
+        exit 1
+    fi
+    # A warning annotation still surfaces on the run without turning it red.
+    echo "::warning title=Incomplete extraction for ${LLVM_TAG}::${message}"
+    echo "WARNING: ${message}"
+    echo "         Release is older than ${STRICT_WINDOW_DAYS} days, publishing the ${extracted_count} binaries that did extract."
 fi