Merge pull request #146 from SUSE/revert-128-fix/warnings-and-linter-corrections

Revert "Clean up all ESLint warnings and harden lint git hook gate"

Author: leomiraanda

package-lock.json

@@ -5,9 +5,8 @@ module.exports = {
     node:    true
   },
   globals: {
-    NodeJS:      true,
-    Timer:       true,
-    RequestInit: true
+    NodeJS: true,
+    Timer:  true
   },
   parser: 'vue-eslint-parser',
   parserOptions: {
@@ -71,7 +70,7 @@ module.exports = {
     'no-eq-null':                    'off',
     'no-eval':                       'warn',
     'no-undef':                      'warn',
-    'no-unused-vars':                'off',
+    'no-unused-vars':                'warn',
     'no-whitespace-before-property': 'off',
     'object-curly-spacing':          'off',
     'object-shorthand':              'off',
@@ -93,7 +92,7 @@ module.exports = {
     'vue/v-slot-style':                   'off',
     'vue/component-tags-order':           'off',
     'vue/no-mutating-props':              'off',
-    '@typescript-eslint/no-unused-vars':  ['warn', { varsIgnorePattern: '^_', argsIgnorePattern: '^_', ignoreRestSiblings: true }],
+    '@typescript-eslint/no-unused-vars':  'off',
     '@typescript-eslint/no-var-requires': 'off',
     '@typescript-eslint/no-this-alias':   'off',
     'array-callback-return':              'off',

pkg/aif-ui/.eslintrc.js

@@ -6,9 +6,8 @@ import { PRODUCT, PAGE_TYPES } from '../config/suseai';
 defineProps<{ operatorError: string }>();
 defineEmits<{ retry: [] }>();
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-const vm      = getCurrentInstance()?.proxy as any; // Vue component proxy has $route but no type declaration in this context
-const cluster = (vm?.$route?.params?.cluster as string) || '_';
+const vm      = getCurrentInstance()!.proxy as any;
+const cluster = (vm.$route?.params?.cluster as string) || '_';
 
 const settingsRoute = {
   name:   `c-cluster-${ PRODUCT }-${ PAGE_TYPES.SETTINGS }`,
@@ -18,28 +17,17 @@ const settingsRoute = {
 </script>
 
 <template>
-  <Banner
-    color="error"
-    class="mb-20"
-  >
+  <Banner color="error" class="mb-20">
     <div class="operator-error-body">
       <div class="operator-error-text">
         <div>{{ operatorError }}</div>
         <div>
           Update <strong>Operator Namespace</strong> under
           <em>Settings → Advanced → Operator Connection</em>.
-          <RouterLink :to="settingsRoute">
-            Go to Settings →
-          </RouterLink>
+          <RouterLink :to="settingsRoute">Go to Settings →</RouterLink>
         </div>
       </div>
-      <button
-        class="btn-retry"
-        type="button"
-        @click="$emit('retry')"
-      >
-        Retry Connection
-      </button>
+      <button class="btn-retry" type="button" @click="$emit('retry')">Retry Connection</button>
     </div>
   </Banner>
 </template>

pkg/aif-ui/components/OperatorErrorBanner.vue

@@ -8,8 +8,7 @@ import { getCurrentInstance } from 'vue';
  * `getCurrentInstance()` resolves to the calling component.
  */
 export function useT() {
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  const store = (getCurrentInstance()?.proxy as any)?.$store; // Vue component proxy has $store but no type declaration in this context
+  const store = (getCurrentInstance()!.proxy as any)?.$store;
 
   return (key: string, fallback: string): string => store?.getters['i18n/t']?.(key) || fallback;
 }

pkg/aif-ui/composables/useT.ts

@@ -312,7 +312,7 @@ export function getDocLink(id: string): DocLink | null {
  * Get all categories with link counts
  */
 export function getCategoriesWithCounts(): Array<{ category: DocCategory; count: number; name: string }> {
-  const counts: Record<DocCategory, number> = {} as Record<DocCategory, number>;
+  const counts: Record<DocCategory, number> = {} as any;
 
   Object.values(DOCUMENTATION_LINKS).forEach(link => {
     counts[link.category] = (counts[link.category] || 0) + 1;

pkg/aif-ui/config/doc-links.ts

@@ -2,7 +2,6 @@
  * Internationalization configuration for SUSE AI Extension
  * Following Rancher UI patterns for consistent i18n implementation
  */
-import logger from '../utils/logger';
 
 export interface TranslationKey {
   [key: string]: string | TranslationKey;
@@ -225,11 +224,11 @@ export const translations: Translations = {
  * Get translated string by key
  * Supports nested keys with dot notation (e.g., 'suseai.apps.title')
  */
-export function t(key: string, params?: Record<string, unknown>, locale: string = DEFAULT_LOCALE): string {
+export function t(key: string, params?: Record<string, any>, locale: string = DEFAULT_LOCALE): string {
   const translation = getNestedValue(translations[locale] || translations[DEFAULT_LOCALE], key);
 
   if (typeof translation !== 'string') {
-    logger.warn(`Translation key not found: ${key}`);
+    console.warn(`Translation key not found: ${key}`);
     return key;
   }
 
@@ -246,12 +245,9 @@ export function t(key: string, params?: Record<string, unknown>, locale: string
 /**
  * Get nested value from object using dot notation
  */
-function getNestedValue(obj: unknown, path: string): unknown {
-  return path.split('.').reduce((current: unknown, key: string) => {
-    if (current && typeof current === 'object') {
-      return (current as Record<string, unknown>)[key];
-    }
-    return undefined;
+function getNestedValue(obj: any, path: string): any {
+  return path.split('.').reduce((current, key) => {
+    return current && current[key] !== undefined ? current[key] : undefined;
   }, obj);
 }
 
@@ -274,5 +270,5 @@ export function getAvailableLocales(): readonly string[] {
  * Validate locale
  */
 export function isValidLocale(locale: string): boolean {
-  return (AVAILABLE_LOCALES as readonly string[]).includes(locale);
+  return AVAILABLE_LOCALES.includes(locale as any);
 }