Replies: 2 comments
-
|
Hey, thanks a lot for the kind words and the thoughtful feedback! Good news: both of these landed in #123 which got merged earlier today. You now have Shadow Parts are in too. Pretty much everything is exposed: Would be awesome if you give it a try once it ships and let me know if anything is still missing for your setup! |
Beta Was this translation helpful? Give feedback.
-
|
Quick follow-up: full docs with the parts inventory and token cascade are here: https://samyssmile.github.io/notectl/guides/styling/ |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
First of all, huge fan of what you've built here. Super impressed, and even more grateful for the work you've put into this.
I was working on styling the editor to match my existing UI, and ran into some things that I think could be improved (and I'd be happy to contribute if that's something you're open to):
Border colors
The table component uses the
--notectl-bordervariable, with no way to override it for the table specifically, whereas there are variables for other components (like code-block). I have a use case where I am already rendering a border on the containing component and need to set the editor border to none, while retaining a visible border on the table component.Shadow dom parts
Using parts (https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Selectors/::part) would greatly improve customizability also. It would allow someone to target a specific element to modify the styles beyond just setting a variable. Think of it as the more hands-on/complex way to customize a theme...
That's it for possible enhancements I've come up with so far. I opted in to just creating a Plugin which injects the styles I want and that works beautifully, just figured the enhancements could still be useful to make it even easier for some folks.
Beta Was this translation helpful? Give feedback.
All reactions