fix(sell): stop stray polling, restore broadcast logs, drop dead fee

Author: wired-pasteque

lib/features/sell/domain/usecases/confirm_sell_payin_usecase.dart

@@ -9,7 +9,6 @@ import 'package:bb_mobile/core/utils/logger.dart';
 import 'package:bb_mobile/core/utils/result.dart';
 import 'package:bb_mobile/core/wallet/domain/entities/wallet.dart';
 import 'package:bb_mobile/core/wallet/domain/entities/wallet_utxo.dart';
-import 'package:bb_mobile/core/wallet/domain/usecases/calculate_bitcoin_absolute_fees_usecase.dart';
 import 'package:bb_mobile/core/wallet/domain/usecases/prepare_bitcoin_send_usecase.dart';
 import 'package:bb_mobile/features/labels/labels_facade.dart';
 import 'package:bb_mobile/features/sell/domain/sell_failure.dart';
@@ -33,21 +32,20 @@ Future<String> _defaultLiquidTxidFromPset(String pset) async =>
 
 /// Builds, signs and broadcasts the payin transaction for a sell order.
 ///
-/// The broadcast is the point of no return: once it succeeds the user's money
-/// has moved, so the payin is reported as a success even if the after-the-fact
+/// The broadcast is the point of no return: once it succeeds the money has
+/// moved, so the payin is reported as a success even if the after-the-fact
 /// bookkeeping (transaction labelling) fails — that is logged but never turned
 /// into a [SellSendPaymentFailure], which would otherwise invite a double-spend
 /// retry. Every failure before or during broadcast is mapped to a sealed
-/// [SellFailure], and the raw exception never leaves the boundary.
+/// [SellFailure]; the raw exception is logged for diagnosis but never carried
+/// in the failure value that reaches bloc state.
 class ConfirmSellPayinUsecase {
   final PrepareBitcoinSendUsecase _prepareBitcoinSendUsecase;
   final PrepareLiquidSendUsecase _prepareLiquidSendUsecase;
   final SignBitcoinTxUsecase _signBitcoinTxUsecase;
   final SignLiquidTxUsecase _signLiquidTxUsecase;
   final BroadcastBitcoinTransactionUsecase _broadcastBitcoinTransactionUsecase;
   final BroadcastLiquidTransactionUsecase _broadcastLiquidTransactionUsecase;
-  final CalculateBitcoinAbsoluteFeesUsecase
-  _calculateBitcoinAbsoluteFeesUsecase;
   final LabelsFacade _labelsFacade;
   final BitcoinTxidFromPsbt _bitcoinTxidFromPsbt;
   final LiquidTxidFromPset _liquidTxidFromPset;
@@ -59,15 +57,13 @@ class ConfirmSellPayinUsecase {
     required this._signLiquidTxUsecase,
     required this._broadcastBitcoinTransactionUsecase,
     required this._broadcastLiquidTransactionUsecase,
-    required this._calculateBitcoinAbsoluteFeesUsecase,
     required this._labelsFacade,
     this._bitcoinTxidFromPsbt = _defaultBitcoinTxidFromPsbt,
     this._liquidTxidFromPset = _defaultLiquidTxidFromPset,
   });
 
   @useResult
-  Future<Result<({String txid, int? updatedAbsoluteFees}), SellFailure>>
-  execute({
+  Future<Result<String, SellFailure>> execute({
     required Wallet wallet,
     required SellOrder sellOrder,
     required int? absoluteFees,
@@ -77,7 +73,6 @@ class ConfirmSellPayinUsecase {
     final payinAmountSat = ConvertAmount.btcToSats(sellOrder.payinAmount);
 
     final String txid;
-    final int? updatedAbsoluteFees;
     try {
       if (wallet.isLiquid) {
         final pset = await _prepareLiquidSendUsecase.execute(
@@ -94,7 +89,6 @@ class ConfirmSellPayinUsecase {
         // Derive the txid before broadcasting so nothing fallible runs after
         // the money has moved.
         txid = await _liquidTxidFromPset(signedPset);
-        updatedAbsoluteFees = null;
         await _broadcastLiquidTransactionUsecase.execute(signedPset);
       } else {
         if (absoluteFees == null) {
@@ -108,8 +102,6 @@ class ConfirmSellPayinUsecase {
           selectedInputs: selectedInputs.isNotEmpty ? selectedInputs : null,
           replaceByFee: replaceByFee,
         );
-        updatedAbsoluteFees = await _calculateBitcoinAbsoluteFeesUsecase
-            .execute(psbt: preparedSend.unsignedPsbt);
         final signedTx = await _signBitcoinTxUsecase.execute(
           psbt: preparedSend.unsignedPsbt,
           walletId: wallet.id,
@@ -121,19 +113,15 @@ class ConfirmSellPayinUsecase {
         );
       }
     } catch (e, st) {
-      log.severe(
-        message: 'sell confirm payin failed',
-        error: e.runtimeType,
-        trace: st,
-      );
+      log.severe(message: 'sell confirm payin failed', error: e, trace: st);
       return Err(SellSendPaymentFailure(e.runtimeType.toString()));
     }
 
     // Broadcast succeeded: the payin is done. Labelling is best-effort and must
     // never demote a completed payin to a failure.
     await _storeSellLabel(walletId: wallet.id, txid: txid);
 
-    return Ok((txid: txid, updatedAbsoluteFees: updatedAbsoluteFees));
+    return Ok(txid);
   }
 
   Future<void> _storeSellLabel({
@@ -151,7 +139,7 @@ class ConfirmSellPayinUsecase {
     } catch (e, st) {
       log.warning(
         'sell payin label store failed (payin already broadcast)',
-        error: e.runtimeType,
+        error: e,
         trace: st,
       );
     }

lib/features/sell/domain/usecases/estimate_sell_payin_fees_usecase.dart

@@ -18,7 +18,6 @@ import 'package:meta/meta.dart';
 /// order is created: fetches the exchange rate, derives the required amount,
 /// enforces the sufficient-balance rule, and computes the absolute network fee
 /// by building a throwaway transaction to a wallet-owned address.
-
 class EstimateSellPayinFeesUsecase {
   final ConvertSatsToCurrencyAmountUsecase _convertSatsToCurrencyAmountUsecase;
   final GetAddressAtIndexUsecase _getAddressAtIndexUsecase;

lib/features/sell/domain/usecases/get_sell_order_status_usecase.dart

@@ -6,7 +6,6 @@ import 'package:bb_mobile/features/sell/domain/sell_failure.dart';
 import 'package:meta/meta.dart';
 
 /// Fetches the latest state of a sell order while polling.
-
 class GetSellOrderStatusUsecase {
   final GetOrderUsecase _getOrderUsecase;
 

lib/features/sell/domain/usecases/recalculate_sell_payin_fees_usecase.dart

@@ -15,7 +15,6 @@ import 'package:meta/meta.dart';
 /// Recomputes the absolute network fee of an already-created sell payin when the
 /// user changes coin selection or RBF, by building a throwaway transaction to a
 /// wallet-owned address.
-
 class RecalculateSellPayinFeesUsecase {
   final GetAddressAtIndexUsecase _getAddressAtIndexUsecase;
   final GetNetworkFeesUsecase _getNetworkFeesUsecase;

lib/features/sell/domain/usecases/start_sell_usecase.dart

@@ -9,7 +9,6 @@ import 'package:meta/meta.dart';
 
 /// Loads the data needed to open the sell amount-input screen: the exchange user
 /// summary and the user's bitcoin unit.
-
 class StartSellUsecase {
   final GetExchangeUserSummaryUsecase _getExchangeUserSummaryUsecase;
   final GetSettingsUsecase _getSettingsUsecase;

lib/features/sell/presentation/bloc/sell_bloc.dart

@@ -254,9 +254,11 @@ class SellBloc extends Bloc<SellEvent, SellState> {
       orderId: paymentState.sellOrder.orderId,
     )) {
       case Ok(:final value):
-        emit(paymentState.copyWith(sellOrder: value));
-      case Err(:final failure):
-        emit(paymentState.copyWith(error: failure));
+        emit(paymentState.copyWith(sellOrder: value, error: null));
+      case Err():
+        // Background refresh: the use-case already logged it. Don't surface a
+        // transient failure; the next refresh heals it.
+        return;
     }
   }
 
@@ -276,9 +278,15 @@ class SellBloc extends Bloc<SellEvent, SellState> {
 
     final wallet = sellPaymentState.selectedWallet;
     if (wallet == null) {
+      log.severe(
+        error: 'no wallet selected to send payment',
+        trace: StackTrace.current,
+      );
       emit(
         sellPaymentState.copyWith(
-          error: const SellUnexpectedFailure(),
+          error: const SellUnexpectedFailure(
+            'no wallet selected to send payment',
+          ),
           isConfirmingPayment: false,
         ),
       );
@@ -299,13 +307,17 @@ class SellBloc extends Bloc<SellEvent, SellState> {
           sellPaymentState.copyWith(error: failure, isConfirmingPayment: false),
         );
         return;
-      case Ok(:final value):
-        final updatedState = value.updatedAbsoluteFees != null
-            ? sellPaymentState.copyWith(absoluteFees: value.updatedAbsoluteFees)
-            : sellPaymentState;
+      case Ok():
+        // The payin is broadcast; the payment flow is done. Stop the status
+        // poller so it doesn't keep firing no-op events on the success state.
+        _stopPolling();
         // 5s delay gives backend time to register the 0 conf
         await Future.delayed(const Duration(seconds: 5));
-        emit(updatedState.toSuccessState(sellOrder: updatedState.sellOrder));
+        emit(
+          sellPaymentState.toSuccessState(
+            sellOrder: sellPaymentState.sellOrder,
+          ),
+        );
     }
   }
 
@@ -323,8 +335,9 @@ class SellBloc extends Bloc<SellEvent, SellState> {
     )) {
       case Ok(:final value):
         latestOrder = value;
-      case Err(:final failure):
-        emit(sellPaymentState.copyWith(error: failure));
+      case Err():
+        // Background retry: the use-case already logged it. Don't paint a
+        // persistent error on a transient blip — the next poll heals it.
         return;
     }
 
@@ -336,11 +349,17 @@ class SellBloc extends Bloc<SellEvent, SellState> {
       _stopPolling();
       emit(
         sellPaymentState
-            .copyWith(sellOrder: latestOrder, isPolling: false)
+            .copyWith(sellOrder: latestOrder, isPolling: false, error: null)
             .toSuccessState(sellOrder: latestOrder),
       );
     } else {
-      emit(sellPaymentState.copyWith(sellOrder: latestOrder, isPolling: true));
+      emit(
+        sellPaymentState.copyWith(
+          sellOrder: latestOrder,
+          isPolling: true,
+          error: null,
+        ),
+      );
     }
   }
 

lib/features/sell/sell_locator.dart

@@ -106,8 +106,6 @@ class SellLocator {
             locator<BroadcastBitcoinTransactionUsecase>(),
         broadcastLiquidTransactionUsecase:
             locator<BroadcastLiquidTransactionUsecase>(),
-        calculateBitcoinAbsoluteFeesUsecase:
-            locator<CalculateBitcoinAbsoluteFeesUsecase>(),
         labelsFacade: locator<LabelsFacade>(),
       ),
     );

localization/app_hy.arb

@@ -1028,9 +1028,9 @@
   "sellWhichWalletQuestion": "Ո՞ր դրամապանակից եք ցանկանում վաճառել",
   "sellExternalWallet": "Արտաքին դրամապանակ",
   "sellFromAnotherWallet": "Վաճառել այլ Bitcoin դրամապանակից",
-  "sellAboveMaxAmountError": "Դուք փորձում եք վաճառել այս դրամապանակով թույլատրվող առավելագույն գումարից ավելի։",
-  "sellBelowMinAmountError": "Դուք փորձում եք վաճառել այս դրամապանակով թույլատրվող նվազագույն գումարից պակաս։",
-  "sellInsufficientBalanceError": "Ընտրված դրամապանակում բավարար մնացորդ չկա այս վաճառքի պատվերն ավարտելու համար։",
+  "sellAboveMaxAmountError": "Այս դրամապանակով վաճառքի առավելագույն գումարն է {amount}։",
+  "sellBelowMinAmountError": "Այս դրամապանակով վաճառքի նվազագույն գումարն է {amount}։",
+  "sellInsufficientBalanceError": "Ընտրված դրամապանակում բավարար մնացորդ չկա այս վաճառքի պատվերն ավարտելու համար։ Պահանջվում է՝ {amount}։",
   "sellUnauthenticatedError": "Դուք նույնականացված չեք։ Խնդրում ենք մուտք գործել՝ շարունակելու համար։",
   "sellOrderNotFoundError": "Վաճառքի պատվերը չի գտնվել։ Խնդրում ենք կրկին փորձել։",
   "sellOrderAlreadyConfirmedError": "Այս վաճառքի պատվերն արդեն հաստատված է։",

localization/app_ka.arb

@@ -1228,9 +1228,9 @@
   "sellWhichWalletQuestion": "რომელი საფულიდან გსურთ გაყიდვა?",
   "sellExternalWallet": "გარე საფულე",
   "sellFromAnotherWallet": "გაყიდეთ სხვა Bitcoin საფულედან",
-  "sellAboveMaxAmountError": "თქვენ ცდილობთ გაყიდოთ იმაზე მეტი, ვიდრე ამ საფულით ნებადართული მაქსიმალური თანხაა.",
-  "sellBelowMinAmountError": "თქვენ ცდილობთ გაყიდოთ იმაზე ნაკლები, ვიდრე ამ საფულით ნებადართული მინიმალური თანხაა.",
-  "sellInsufficientBalanceError": "არჩეულ საფულეში არასაკმარისი ბალანსია ამ გაყიდვის შეკვეთის დასასრულებლად.",
+  "sellAboveMaxAmountError": "ამ საფულით გასაყიდი მაქსიმალური თანხაა {amount}.",
+  "sellBelowMinAmountError": "ამ საფულით გასაყიდი მინიმალური თანხაა {amount}.",
+  "sellInsufficientBalanceError": "არჩეულ საფულეში არასაკმარისი ბალანსია ამ გაყიდვის შეკვეთის დასასრულებლად. საჭიროა: {amount}.",
   "sellUnauthenticatedError": "თქვენ არ ხართ ავთენტიფიცირებული. გასაგრძელებლად გთხოვთ შეხვიდეთ სისტემაში.",
   "sellOrderNotFoundError": "გაყიდვის შეკვეთა ვერ მოიძებნა. გთხოვთ, სცადოთ ხელახლა.",
   "sellOrderAlreadyConfirmedError": "ეს გაყიდვის შეკვეთა უკვე დადასტურებულია.",

localization/app_sw.arb

@@ -1045,9 +1045,9 @@
   "sellWhichWalletQuestion": "Ni pochi gani unayotaka kuuza kutoka?",
   "sellExternalWallet": "Pochi ya nje",
   "sellFromAnotherWallet": "Uza kutoka pochi nyingine ya Bitcoin",
-  "sellAboveMaxAmountError": "Unajaribu kuuza zaidi ya kiwango cha juu kinachoweza kuuzwa kwa pochi hii.",
-  "sellBelowMinAmountError": "Unajaribu kuuza chini ya kiwango cha chini kinachoweza kuuzwa kwa pochi hii.",
-  "sellInsufficientBalanceError": "Salio halitoshi kwenye pochi iliyochaguliwa kukamilisha agizo hili la kuuza.",
+  "sellAboveMaxAmountError": "Kiasi cha juu kinachoweza kuuzwa kwa pochi hii ni {amount}.",
+  "sellBelowMinAmountError": "Kiasi cha chini kinachoweza kuuzwa kwa pochi hii ni {amount}.",
+  "sellInsufficientBalanceError": "Salio halitoshi kwenye pochi iliyochaguliwa kukamilisha agizo hili la kuuza. Kinachohitajika: {amount}.",
   "sellUnauthenticatedError": "Hujathibitishwa. Tafadhali ingia ili kuendelea.",
   "sellOrderNotFoundError": "Agizo la kuuza halikupatikana. Tafadhali jaribu tena.",
   "sellOrderAlreadyConfirmedError": "Agizo hili la kuuza tayari limethibitishwa.",