Skip to content

Commit 0e08fae

Browse files
committed
fix(ci): unbreak bullock verdict script quoting
An apostrophe inside ${question:-word} was treated as a bash quoting char even under double quotes, leaving the last single-quote in the 88-line script unclosed. bash -n failed with 'unexpected EOF' on every Bullock run, so the whole 'Act on Bullock's verdict' step died at parse time before any instruction ran — including the clarifying comment this exact line was meant to post, so summons that should have gotten a question instead got a silent red run. Reword to avoid the apostrophe; no behavior change once it parses.
1 parent 53ed590 commit 0e08fae

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

.github/workflows/bullock.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,10 @@ jobs:
319319
320320
if [ "$sufficient" != "true" ]; then
321321
body="🐂 Bullock needs more info before implementing:"
322-
body="${body}"$'\n\n'"> ${question:-Please clarify what you'd like changed.}"
322+
# NB: no apostrophes inside ${var:-word} — bash treats a single
323+
# quote there as a quoting char even inside double quotes, which
324+
# made this whole script unparseable (exit 2 at EOF).
325+
body="${body}"$'\n\n'"> ${question:-Please clarify what you would like changed.}"
323326
comment "$body"
324327
echo "Insufficient info — asked for clarification, no PR opened."
325328
exit 0

0 commit comments

Comments
 (0)