refactor(bitbox): make sign/verify usecase params non-nullable, validate at call-site

Author: wired-pasteque

lib/core/bitbox/domain/usecases/sign_psbt_bitbox_usecase.dart

@@ -19,18 +19,10 @@ class SignPsbtBitBoxUsecase {
   @useResult
   Future<Result<String, BitBoxFailure>> execute(
     BitBoxDeviceEntity device, {
-    required String? psbt,
-    required String? derivationPath,
+    required String psbt,
+    required String derivationPath,
     required ScriptType scriptType,
   }) async {
-    if (psbt == null || derivationPath == null) {
-      return const Err(
-        InvalidParametersBitBoxFailure(
-          'sign requested without psbt/derivationPath',
-        ),
-      );
-    }
-
     final bool isTestnet;
     try {
       final settings = await _settingsRepository.fetch();

lib/core/bitbox/domain/usecases/verify_address_bitbox_usecase.dart

@@ -19,18 +19,10 @@ class VerifyAddressBitBoxUsecase {
   @useResult
   Future<Result<bool, BitBoxFailure>> execute({
     required BitBoxDeviceEntity device,
-    required String? address,
-    required String? derivationPath,
+    required String address,
+    required String derivationPath,
     required ScriptType scriptType,
   }) async {
-    if (address == null || derivationPath == null) {
-      return const Err(
-        InvalidParametersBitBoxFailure(
-          'verify requested without address/derivationPath',
-        ),
-      );
-    }
-
     final bool isTestnet;
     try {
       final settings = await _settingsRepository.fetch();

lib/features/bitbox/ui/screens/bitbox_action_screen.dart

@@ -351,10 +351,16 @@ class _BitBoxActionViewState extends State<_BitBoxActionView> {
       final derivationPath = widget.parameters?.derivationPath;
       final scriptType = widget.parameters?.scriptType ?? ScriptType.bip84;
 
-      if (address != null && derivationPath != null) {
-        cubit.showAddressVerification(address);
+      if (address == null || derivationPath == null) {
+        return const Err(
+          InvalidParametersBitBoxFailure(
+            'verify requested without address/derivationPath',
+          ),
+        );
       }
 
+      cubit.showAddressVerification(address);
+
       return locator<VerifyAddressBitBoxUsecase>().execute(
         device: device,
         address: address,
@@ -374,12 +380,22 @@ class _BitBoxActionViewState extends State<_BitBoxActionView> {
       }
 
       final device = cubit.state.connectedDevice!;
+      final psbt = widget.parameters?.psbt;
+      final derivationPath = widget.parameters?.derivationPath;
       final scriptType = widget.parameters?.scriptType ?? ScriptType.bip84;
 
+      if (psbt == null || derivationPath == null) {
+        return const Err(
+          InvalidParametersBitBoxFailure(
+            'sign requested without psbt/derivationPath',
+          ),
+        );
+      }
+
       return locator<SignPsbtBitBoxUsecase>().execute(
         device,
-        psbt: widget.parameters?.psbt,
-        derivationPath: widget.parameters?.derivationPath,
+        psbt: psbt,
+        derivationPath: derivationPath,
         scriptType: scriptType,
       );
     });

test/core_test/bitbox/bitbox_failure_test.dart

@@ -109,23 +109,6 @@ void main() {
         expect((result as Err).failure, isA<BitBoxUnexpectedFailure>());
       },
     );
-
-    test('validates missing psbt below presentation — no raw leak', () async {
-      final usecase = SignPsbtBitBoxUsecase(
-        repository: _MockRepository(),
-        settingsRepository: _MockSettingsRepository(),
-      );
-
-      final result = await usecase.execute(
-        _device,
-        psbt: null,
-        derivationPath: "m/84'/0'/0'",
-        scriptType: ScriptType.bip84,
-      );
-
-      expect(result, isA<Err>());
-      expect((result as Err).failure, isA<InvalidParametersBitBoxFailure>());
-    });
   });
 
   group('ConnectBitBoxDeviceUsecase', () {
@@ -174,23 +157,6 @@ void main() {
   });
 
   group('VerifyAddressBitBoxUsecase', () {
-    test('returns InvalidParameters on missing input — no raw leak', () async {
-      final usecase = VerifyAddressBitBoxUsecase(
-        repository: _MockRepository(),
-        settingsRepository: _MockSettingsRepository(),
-      );
-
-      final result = await usecase.execute(
-        device: _device,
-        address: null,
-        derivationPath: "m/84'/0'/0'",
-        scriptType: ScriptType.bip84,
-      );
-
-      expect(result, isA<Err>());
-      expect((result as Err).failure, isA<InvalidParametersBitBoxFailure>());
-    });
-
     test('maps an address mismatch to InvalidResponse', () async {
       final repo = _MockRepository();
       final settings = _MockSettingsRepository();