Commit 2e495dc
committed
fix(sell): close the post-broadcast double-payment window
After broadcasting, the confirm handler fetched the order; any failure
in that fetch re-enabled Confirm with the transaction already on the
wire, so a second tap re-ran prepare, sign and broadcast and could pay
the order twice. Concurrent handlers (fee recalculation, utxo load,
order poll, price-lock refresh) also emitted pre-await snapshots that
could silently revert in-flight state.
- Latch on broadcast: payinBroadcastTxid is emitted immediately after
the transaction is on the wire (bitcoin and liquid). A latched bloc
never re-enters the send path, never surfaces a retryable error, and
keeps Confirm disabled while the existing poll carries the order to
success.
- Merge concurrent emits into live state so the latch survives fee
recalculation, utxo loads and an order poll spanning the broadcast.
- Price-lock refresh no longer clears the in-flight flag; a failure
after the deadline re-arms the countdown so the price refreshes.
- Show an in-flight spinner and status next to Confirm; disable
Advanced settings during confirmation.
- Success state now carries the post-broadcast order instead of the
stale pre-broadcast snapshot.
- Sell success screen: adds 'You sold {amount} for {fiatAmount}', gates
the balance-credit message on balance payouts, and closes (button and
back gesture) to wallet home like buy, on a new shared success
scaffold widget.
- SINPE recipients: ownerName is optional, matching the server schema;
display falls back to label, then phone or IBAN. Recipients missing
the Ridivi-derived name are no longer dropped.
Closes #2522
Closes #2523
Closes #2529
Closes #25301 parent 33a1ff1 commit 2e495dc
11 files changed
Lines changed: 863 additions & 169 deletions
File tree
- lib
- core
- exchange/domain/entity
- widgets
- features
- recipients
- application/dtos
- domain/value_objects
- interface_adapters/presenters/models
- sell
- presentation/bloc
- ui/screens
- localization
- test/features/sell/presentation
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
231 | 231 | | |
232 | 232 | | |
233 | 233 | | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
234 | 249 | | |
235 | 250 | | |
236 | 251 | | |
| |||
562 | 577 | | |
563 | 578 | | |
564 | 579 | | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
565 | 584 | | |
566 | 585 | | |
567 | 586 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
Lines changed: 6 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
397 | 397 | | |
398 | 398 | | |
399 | 399 | | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
400 | 403 | | |
401 | 404 | | |
402 | 405 | | |
403 | 406 | | |
404 | | - | |
405 | | - | |
406 | | - | |
407 | 407 | | |
408 | 408 | | |
409 | 409 | | |
410 | 410 | | |
411 | 411 | | |
412 | | - | |
| 412 | + | |
413 | 413 | | |
414 | 414 | | |
415 | 415 | | |
416 | 416 | | |
417 | 417 | | |
418 | 418 | | |
419 | | - | |
420 | | - | |
421 | | - | |
422 | 419 | | |
423 | 420 | | |
424 | 421 | | |
425 | 422 | | |
426 | 423 | | |
427 | | - | |
| 424 | + | |
428 | 425 | | |
429 | 426 | | |
430 | 427 | | |
431 | 428 | | |
432 | 429 | | |
433 | 430 | | |
434 | | - | |
435 | | - | |
436 | | - | |
437 | 431 | | |
438 | 432 | | |
439 | 433 | | |
440 | 434 | | |
441 | 435 | | |
442 | | - | |
| 436 | + | |
443 | 437 | | |
444 | 438 | | |
445 | 439 | | |
| |||
Lines changed: 21 additions & 21 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
378 | 378 | | |
379 | 379 | | |
380 | 380 | | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
381 | 390 | | |
382 | 391 | | |
383 | 392 | | |
384 | | - | |
| 393 | + | |
385 | 394 | | |
386 | 395 | | |
387 | 396 | | |
388 | 397 | | |
389 | 398 | | |
390 | 399 | | |
391 | | - | |
| 400 | + | |
392 | 401 | | |
393 | 402 | | |
394 | 403 | | |
395 | 404 | | |
396 | 405 | | |
397 | 406 | | |
398 | 407 | | |
399 | | - | |
| 408 | + | |
400 | 409 | | |
401 | 410 | | |
402 | 411 | | |
403 | 412 | | |
404 | | - | |
405 | | - | |
406 | | - | |
407 | 413 | | |
408 | 414 | | |
409 | 415 | | |
410 | 416 | | |
411 | 417 | | |
412 | 418 | | |
413 | | - | |
| 419 | + | |
414 | 420 | | |
415 | 421 | | |
416 | 422 | | |
| |||
421 | 427 | | |
422 | 428 | | |
423 | 429 | | |
424 | | - | |
| 430 | + | |
425 | 431 | | |
426 | 432 | | |
427 | 433 | | |
428 | 434 | | |
429 | 435 | | |
430 | 436 | | |
431 | | - | |
| 437 | + | |
432 | 438 | | |
433 | 439 | | |
434 | 440 | | |
435 | 441 | | |
436 | 442 | | |
437 | 443 | | |
438 | 444 | | |
439 | | - | |
| 445 | + | |
440 | 446 | | |
441 | 447 | | |
442 | 448 | | |
443 | 449 | | |
444 | | - | |
445 | | - | |
446 | | - | |
447 | 450 | | |
448 | 451 | | |
449 | 452 | | |
450 | 453 | | |
451 | 454 | | |
452 | 455 | | |
453 | | - | |
| 456 | + | |
454 | 457 | | |
455 | 458 | | |
456 | 459 | | |
| |||
461 | 464 | | |
462 | 465 | | |
463 | 466 | | |
464 | | - | |
| 467 | + | |
465 | 468 | | |
466 | 469 | | |
467 | 470 | | |
468 | 471 | | |
469 | 472 | | |
470 | 473 | | |
471 | | - | |
| 474 | + | |
472 | 475 | | |
473 | 476 | | |
474 | 477 | | |
475 | 478 | | |
476 | 479 | | |
477 | 480 | | |
478 | 481 | | |
479 | | - | |
| 482 | + | |
480 | 483 | | |
481 | 484 | | |
482 | 485 | | |
483 | 486 | | |
484 | | - | |
485 | | - | |
486 | | - | |
487 | 487 | | |
488 | 488 | | |
489 | 489 | | |
490 | 490 | | |
491 | 491 | | |
492 | 492 | | |
493 | | - | |
| 493 | + | |
494 | 494 | | |
495 | 495 | | |
496 | 496 | | |
| |||
Lines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
| 141 | + | |
| 142 | + | |
141 | 143 | | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | 144 | | |
147 | 145 | | |
148 | 146 | | |
| 147 | + | |
149 | 148 | | |
150 | 149 | | |
151 | 150 | | |
152 | 151 | | |
153 | 152 | | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
154 | 156 | | |
155 | 157 | | |
156 | 158 | | |
| |||
0 commit comments