fix: drop unused dismissed_announcements table from v14 migration

Author: i5hi

lib/core/storage/migrations/schema_13_to_14.dart

@@ -1,5 +1,4 @@
 import 'package:bb_mobile/core/storage/sqlite_database.steps.dart';
-import 'package:bb_mobile/core/utils/logger.dart';
 import 'package:drift/drift.dart';
 
 /// Migration from version 13 to 14
@@ -26,10 +25,6 @@ import 'package:drift/drift.dart';
 ///   expiry with an original available) — see PayjoinStatus.aborted.
 ///   Previously this outcome was folded into 'is_completed', which made
 ///   every plain fallback broadcast display as a completed payjoin.
-///
-/// Adds the dismissed_announcements table:
-/// - Records which home announcements the user has dismissed (announcement id
-///   + dismissal timestamp). New table, created empty.
 class Schema13To14 {
   static Future<void> migrate(Migrator m, Schema14 schema14) async {
     try {
@@ -70,21 +65,5 @@ class Schema13To14 {
     } catch (e) {
       if (!e.toString().contains('duplicate column')) rethrow;
     }
-
-    // New dismissed_announcements table: one row per home announcement the
-    // user has dismissed (announcement id + dismissal timestamp). A brand-new
-    // table, so existing installs simply start with zero dismissals.
-    try {
-      await m.createTable(schema14.dismissedAnnouncements);
-    } catch (e) {
-      // Idempotency guard: only swallow "table already exists" (a re-run over a
-      // partially-applied migration) — log it so a driver wording change
-      // surfaces instead of silently becoming a hard failure.
-      if (!e.toString().contains('already exists')) rethrow;
-      log.warning(
-        'Schema13To14: dismissed_announcements already exists — skipping create',
-        error: e,
-      );
-    }
   }
 }

lib/core/storage/schemas/bull_database/drift_schema_v14.json

@@ -2038,43 +2038,6 @@
           "vout"
         ]
       }
-    },
-    {
-      "id": 16,
-      "references": [],
-      "type": "table",
-      "data": {
-        "name": "dismissed_announcements",
-        "was_declared_in_moor": false,
-        "columns": [
-          {
-            "name": "announcement_id",
-            "getter_name": "announcementId",
-            "moor_type": "string",
-            "nullable": false,
-            "customConstraints": null,
-            "default_dart": null,
-            "default_client_dart": null,
-            "dsl_features": []
-          },
-          {
-            "name": "dismissed_at",
-            "getter_name": "dismissedAt",
-            "moor_type": "dateTime",
-            "nullable": false,
-            "customConstraints": null,
-            "default_dart": null,
-            "default_client_dart": null,
-            "dsl_features": []
-          }
-        ],
-        "is_virtual": false,
-        "without_rowid": false,
-        "constraints": [],
-        "explicit_pk": [
-          "announcement_id"
-        ]
-      }
     }
   ],
   "fixed_sql": [
@@ -2221,15 +2184,6 @@
           "sql": "CREATE TABLE IF NOT EXISTS \"frozen_utxos\" (\"wallet_id\" TEXT NOT NULL, \"tx_id\" TEXT NOT NULL, \"vout\" INTEGER NOT NULL, PRIMARY KEY (\"wallet_id\", \"tx_id\", \"vout\"));"
         }
       ]
-    },
-    {
-      "name": "dismissed_announcements",
-      "sql": [
-        {
-          "dialect": "sqlite",
-          "sql": "CREATE TABLE IF NOT EXISTS \"dismissed_announcements\" (\"announcement_id\" TEXT NOT NULL, \"dismissed_at\" TEXT NOT NULL, PRIMARY KEY (\"announcement_id\"));"
-        }
-      ]
     }
   ]
 }

lib/core/storage/sqlite_database.dart

@@ -7,7 +7,6 @@ import 'package:bb_mobile/core/utils/logger.dart';
 import 'package:bb_mobile/core/utils/report.dart';
 import 'package:bb_mobile/core/storage/tables/auto_swap.dart';
 import 'package:bb_mobile/core/storage/tables/bip85_derivations_table.dart';
-import 'package:bb_mobile/core/storage/tables/dismissed_announcements_table.dart';
 import 'package:bb_mobile/core/storage/tables/electrum_servers_table.dart';
 import 'package:bb_mobile/core/storage/tables/electrum_settings_table.dart';
 import 'package:bb_mobile/core/storage/tables/frozen_utxos_table.dart';
@@ -50,7 +49,6 @@ part 'sqlite_database.g.dart';
     Recoverbull,
     Prices,
     FrozenUtxos,
-    DismissedAnnouncements,
   ],
 )
 class SqliteDatabase extends _$SqliteDatabase {

lib/core/storage/sqlite_database.steps.dart

@@ -6270,7 +6270,6 @@ final class Schema14 extends i0.VersionedSchema {
     recoverbull,
     prices,
     frozenUtxos,
-    dismissedAnnouncements,
   ];
   late final Shape0 transactions = Shape0(
     source: i0.VersionedTable(
@@ -6611,17 +6610,6 @@ final class Schema14 extends i0.VersionedSchema {
     ),
     alias: null,
   );
-  late final Shape43 dismissedAnnouncements = Shape43(
-    source: i0.VersionedTable(
-      entityName: 'dismissed_announcements',
-      withoutRowId: false,
-      isStrict: false,
-      tableConstraints: ['PRIMARY KEY(announcement_id)'],
-      columns: [_column_246, _column_247],
-      attachedDatabase: database,
-    ),
-    alias: null,
-  );
 }
 
 class Shape40 extends i0.VersionedTable {
@@ -6773,30 +6761,6 @@ class Shape42 extends i0.VersionedTable {
       columnsByName['is_aborted']! as i1.GeneratedColumn<int>;
 }
 
-class Shape43 extends i0.VersionedTable {
-  Shape43({required super.source, required super.alias}) : super.aliased();
-  i1.GeneratedColumn<String> get announcementId =>
-      columnsByName['announcement_id']! as i1.GeneratedColumn<String>;
-  i1.GeneratedColumn<String> get dismissedAt =>
-      columnsByName['dismissed_at']! as i1.GeneratedColumn<String>;
-}
-
-i1.GeneratedColumn<String> _column_246(String aliasedName) =>
-    i1.GeneratedColumn<String>(
-      'announcement_id',
-      aliasedName,
-      false,
-      type: i1.DriftSqlType.string,
-      $customConstraints: 'NOT NULL',
-    );
-i1.GeneratedColumn<String> _column_247(String aliasedName) =>
-    i1.GeneratedColumn<String>(
-      'dismissed_at',
-      aliasedName,
-      false,
-      type: i1.DriftSqlType.string,
-      $customConstraints: 'NOT NULL',
-    );
 i0.MigrationStepWithVersion migrationSteps({
   required Future<void> Function(i1.Migrator m, Schema2 schema) from1To2,
   required Future<void> Function(i1.Migrator m, Schema3 schema) from2To3,