Commit 47ddf76
committed
refactor(fees): extract preview use cases and cache value object
Unifies the fee-preview state machine that was duplicated between
SendCubit and TransferBloc — same parallel build with rate-dedupe,
same custom-rate debounce, same 11 nullable cache fields, identical
0.1-floor check.
New primitives in lib/core/fees/domain/:
- BitcoinFeePreviewSlot + BitcoinFeePreviewCache value objects
collapse the 11 nullable fields per state into one composite keyed
by FeeSelection.
- NetworkFeeRelayPolicy with a single minRelay constant.
- BitcoinFeePresetPolicy owns the Slow-pin (0.1 sat/vB) decision
instead of FeesDatasource.
New use cases in lib/features/send/domain/usecases/ (swap imports
them via the same pre-existing pattern it uses for
PrepareBitcoinSendUsecase):
- PreviewBitcoinFeeUsecase builds one PSBT and reports the real
psbt.fee() + cached bytes.
- PreviewBitcoinFeePresetsUsecase builds fastest/economic/slow in
parallel and dedupes by rate — same-rate presets share one PSBT so
a quiet mempool can't make Slow look more expensive than Economic.
Behaviour fixes folded in:
- Use case logs build failures instead of silently swallowing them.
- The custom-fee tile prefills the input with the previously
committed value on reopen.
- L10n key sendEstimatedDeliveryFewHours renamed to
sendEstimatedDeliveryHours; English value is now "hours". Other
locales keep their pre-rename strings (translation follow-up).
3 new test files cover the slot/cache invariants, the minRelay
policy boundary, and the preset-policy slow-pin. Widget tests gain
3 prefill cases. 192 tests pass; analyze --fatal-warnings
--fatal-infos clean.
Deferred:
- Single-modal widget unification across send/swap — needs careful
bloc-provider rewiring with a manual smoke test.
- Moving PrepareBitcoinSendUsecase + CalculateBitcoinAbsoluteFees-
Usecase to lib/core/wallet/ to fix the pre-existing swap → send
feature-isolation violation.
- Translating "hours" into the 25 non-English locales.1 parent 50385e6 commit 47ddf76
45 files changed
Lines changed: 1765 additions & 712 deletions
File tree
- lib
- core
- fees
- data
- domain
- widgets
- dropdown
- fees
- features
- send
- domain/usecases
- presentation/bloc
- ui/widgets
- swap
- presentation
- ui/widgets
- localization
- test
- core_test
- fees
- widgets/fees
- features/send/presentation/bloc
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
55 | 54 | | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
60 | 59 | | |
61 | | - | |
62 | | - | |
63 | 60 | | |
64 | 61 | | |
65 | 62 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
4 | 3 | | |
| |||
96 | 95 | | |
97 | 96 | | |
98 | 97 | | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
99 | 141 | | |
100 | 142 | | |
101 | 143 | | |
| |||
128 | 170 | | |
129 | 171 | | |
130 | 172 | | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | 173 | | |
178 | 174 | | |
179 | 175 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
| |||
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
13 | 20 | | |
14 | 21 | | |
15 | 22 | | |
16 | 23 | | |
17 | 24 | | |
18 | 25 | | |
| 26 | + | |
19 | 27 | | |
20 | 28 | | |
21 | 29 | | |
| |||
88 | 96 | | |
89 | 97 | | |
90 | 98 | | |
91 | | - | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
92 | 110 | | |
93 | 111 | | |
94 | 112 | | |
| |||
0 commit comments