fix: validate orbot availability before initiating recoverbull connection

Author: basantagoswami

lib/core/recoverbull/data/repository/recoverbull_repository.dart

@@ -50,7 +50,7 @@ class RecoverBullRepository {
     String salt,
     String vaultKey,
   ) async {
-    final externalProxy = await torConfigPort.getExternalTorConfig();
+    final externalProxy = await torConfigPort.getAvailableExternalTorConfig();
     await remoteDatasource.store(
       HEX.decode(identifier),
       utf8.encode(password),
@@ -65,7 +65,7 @@ class RecoverBullRepository {
     String password,
     String salt,
   ) async {
-    final externalProxy = await torConfigPort.getExternalTorConfig();
+    final externalProxy = await torConfigPort.getAvailableExternalTorConfig();
     final vaultKey = await remoteDatasource.fetch(
       HEX.decode(identifier),
       utf8.encode(password),
@@ -80,7 +80,7 @@ class RecoverBullRepository {
     String password,
     String salt,
   ) async {
-    final externalProxy = await torConfigPort.getExternalTorConfig();
+    final externalProxy = await torConfigPort.getAvailableExternalTorConfig();
     await remoteDatasource.trash(
       HEX.decode(identifier),
       utf8.encode(password),
@@ -90,7 +90,7 @@ class RecoverBullRepository {
   }
 
   Future<void> checkConnection() async {
-    final externalProxy = await torConfigPort.getExternalTorConfig();
+    final externalProxy = await torConfigPort.getAvailableExternalTorConfig();
     await remoteDatasource.checkConnection(externalProxy: externalProxy);
   }
 

lib/core/recoverbull/recoverbull_locator.dart

@@ -29,6 +29,7 @@ import 'package:bb_mobile/core/settings/domain/repositories/settings_repository.
 import 'package:bb_mobile/core/storage/sqlite_database.dart';
 import 'package:bb_mobile/core/tor/data/datasources/tor_datasource.dart';
 import 'package:bb_mobile/core/tor/domain/ports/tor_config_port.dart';
+import 'package:bb_mobile/core/tor/infrastructure/services/tor_connectivity_service.dart';
 import 'package:bb_mobile/core/tor/interface_adapters/adapters/tor_config_adapter.dart';
 import 'package:bb_mobile/core/wallet/data/repositories/wallet_repository.dart';
 import 'package:bb_mobile/core/wallet/domain/usecases/create_default_wallets_usecase.dart';
@@ -69,7 +70,10 @@ class RecoverbullLocator {
     );
 
     locator.registerLazySingleton<TorConfigPort>(
-      () => TorConfigAdapter(settingsRepository: locator<SettingsRepository>()),
+      () => TorConfigAdapter(
+        settingsRepository: locator<SettingsRepository>(),
+        torConnectivityService: locator<TorConnectivityService>(),
+      ),
     );
 
     locator.registerSingletonWithDependencies<RecoverBullRepository>(

…r_settings/domain/ports/socket_port.dart …b/core/tor/domain/ports/socket_port.dartlib/features/tor_settings/domain/ports/socket_port.dart renamed to lib/core/tor/domain/ports/socket_port.dart lib/features/tor_settings/domain/ports/socket_port.dart renamed to lib/core/tor/domain/ports/socket_port.dart

@@ -4,5 +4,5 @@ abstract class TorConfigPort {
   /// Get the Tor proxy configuration
   /// Returns null if internal Tor should be used
   /// Returns TorProxyConfig if external Tor proxy is configured
-  Future<TorProxyConfig?> getExternalTorConfig();
+  Future<TorProxyConfig?> getAvailableExternalTorConfig();
 }

lib/core/tor/domain/ports/tor_config_port.dart

@@ -0,0 +1,14 @@
+import 'package:bb_mobile/core/tor/infrastructure/services/tor_connectivity_service.dart';
+import 'package:bb_mobile/core/tor/tor_status.dart';
+
+class CheckTorProxyConnectionUsecase {
+  final TorConnectivityService _torConnectivityService;
+
+  CheckTorProxyConnectionUsecase({
+    required TorConnectivityService torConnectivityService,
+  }) : _torConnectivityService = torConnectivityService;
+
+  Future<TorStatus> execute(int port) async {
+    return _torConnectivityService.checkConnection(port);
+  }
+}

lib/core/tor/domain/usecases/check_tor_proxy_connection_usecase.dart

@@ -1,7 +1,7 @@
 import 'dart:async';
 import 'dart:io';
 
-import 'package:bb_mobile/features/tor_settings/domain/ports/socket_port.dart';
+import 'package:bb_mobile/core/tor/domain/ports/socket_port.dart';
 
 class SocketAdapter implements SocketPort {
   @override

…rastructure/adapters/socket_adapter.dart …rastructure/adapters/socket_adapter.dartlib/features/tor_settings/infrastructure/adapters/socket_adapter.dart renamed to lib/core/tor/infrastructure/adapters/socket_adapter.dart lib/features/tor_settings/infrastructure/adapters/socket_adapter.dart renamed to lib/core/tor/infrastructure/adapters/socket_adapter.dart

@@ -1,14 +1,20 @@
 import 'dart:async';
 import 'dart:io';
 
+import 'package:bb_mobile/core/tor/domain/ports/socket_port.dart';
 import 'package:bb_mobile/core/tor/tor_status.dart';
 import 'package:bb_mobile/core/utils/logger.dart';
-import 'package:bb_mobile/features/tor_settings/domain/ports/socket_port.dart';
 
-class CheckTorProxyConnectionUsecase {
+class TorConnectivityService {
   final SocketPort _socketPort;
 
-  const CheckTorProxyConnectionUsecase({required SocketPort socketPort})
+  // cache to avoid repeated connection checks
+  TorStatus? _cachedStatus;
+  int? _cachedPort;
+  DateTime? _cacheTime;
+  static const _cacheDuration = Duration(seconds: 30);
+
+  TorConnectivityService({required SocketPort socketPort})
     : _socketPort = socketPort;
 
   /// Checks if a Tor SOCKS5 proxy is running and accessible on the given port
@@ -19,7 +25,25 @@ class CheckTorProxyConnectionUsecase {
   /// 3. The app has permission to connect
   ///
   /// Returns the appropriate [TorStatus] based on the connection check
-  Future<TorStatus> execute(int port) async {
+  Future<TorStatus> checkConnection(int port) async {
+    if (_cachedStatus != null &&
+        _cachedPort == port &&
+        _cacheTime != null &&
+        DateTime.now().difference(_cacheTime!) < _cacheDuration) {
+      log.config('Using cached Tor proxy status for port $port');
+      return _cachedStatus!;
+    }
+
+    final status = await _performCheck(port);
+
+    _cachedStatus = status;
+    _cachedPort = port;
+    _cacheTime = DateTime.now();
+
+    return status;
+  }
+
+  Future<TorStatus> _performCheck(int port) async {
     try {
       // Test SOCKS5 proxy functionality by attempting SOCKS5 handshake
       // This verifies both that the port is open AND that our app can use it

…/check_tor_proxy_connection_usecase.dart …e/services/tor_connectivity_service.dartlib/features/tor_settings/domain/usecases/check_tor_proxy_connection_usecase.dart renamed to lib/core/tor/infrastructure/services/tor_connectivity_service.dart lib/features/tor_settings/domain/usecases/check_tor_proxy_connection_usecase.dart renamed to lib/core/tor/infrastructure/services/tor_connectivity_service.dart

@@ -1,18 +1,28 @@
 import 'package:bb_mobile/core/settings/domain/repositories/settings_repository.dart';
 import 'package:bb_mobile/core/tor/domain/ports/tor_config_port.dart';
 import 'package:bb_mobile/core/tor/domain/value_objects/tor_proxy_config.dart';
+import 'package:bb_mobile/core/tor/infrastructure/services/tor_connectivity_service.dart';
+import 'package:bb_mobile/core/tor/tor_status.dart';
 
 class TorConfigAdapter implements TorConfigPort {
   final SettingsRepository _settingsRepository;
+  final TorConnectivityService _torConnectivityService;
 
-  TorConfigAdapter({required SettingsRepository settingsRepository})
-    : _settingsRepository = settingsRepository;
+  TorConfigAdapter({
+    required SettingsRepository settingsRepository,
+    required TorConnectivityService torConnectivityService,
+  }) : _settingsRepository = settingsRepository,
+       _torConnectivityService = torConnectivityService;
 
   @override
-  Future<TorProxyConfig?> getExternalTorConfig() async {
+  Future<TorProxyConfig?> getAvailableExternalTorConfig() async {
     final settings = await _settingsRepository.fetch();
 
-    if (settings.useTorProxy) {
+    final status = await _torConnectivityService.checkConnection(
+      settings.torProxyPort,
+    );
+
+    if (status == TorStatus.online) {
       return TorProxyConfig(port: settings.torProxyPort);
     }
 

lib/core/tor/interface_adapters/adapters/tor_config_adapter.dart

@@ -4,6 +4,10 @@ import 'package:bb_mobile/core/tor/data/repository/tor_repository.dart';
 import 'package:bb_mobile/core/tor/data/usecases/init_tor_usecase.dart';
 import 'package:bb_mobile/core/tor/data/usecases/is_tor_required_usecase.dart';
 import 'package:bb_mobile/core/tor/data/usecases/tor_status_usecase.dart';
+import 'package:bb_mobile/core/tor/domain/ports/socket_port.dart';
+import 'package:bb_mobile/core/tor/domain/usecases/check_tor_proxy_connection_usecase.dart';
+import 'package:bb_mobile/core/tor/infrastructure/adapters/socket_adapter.dart';
+import 'package:bb_mobile/core/tor/infrastructure/services/tor_connectivity_service.dart';
 import 'package:bb_mobile/core/wallet/data/repositories/wallet_repository.dart';
 import 'package:get_it/get_it.dart';
 
@@ -15,6 +19,11 @@ class TorLocator {
       });
     }
     await locator.isReady<TorDatasource>();
+
+    locator.registerLazySingleton<SocketPort>(() => SocketAdapter());
+    locator.registerLazySingleton<TorConnectivityService>(
+      () => TorConnectivityService(socketPort: locator<SocketPort>()),
+    );
   }
 
   static Future<void> registerRepositories(GetIt locator) async {
@@ -40,5 +49,11 @@ class TorLocator {
     locator.registerFactory<TorStatusUsecase>(
       () => TorStatusUsecase(locator<TorRepository>()),
     );
+
+    locator.registerFactory<CheckTorProxyConnectionUsecase>(
+      () => CheckTorProxyConnectionUsecase(
+        torConnectivityService: locator<TorConnectivityService>(),
+      ),
+    );
   }
 }

lib/core/tor/tor_locator.dart

@@ -109,7 +109,8 @@ class RecoverBullBloc extends Bloc<RecoverBullEvent, RecoverBullState> {
     Emitter<RecoverBullState> emit,
   ) async {
     try {
-      final externalTorConfig = await _torConfigPort.getExternalTorConfig();
+      final externalTorConfig = await _torConfigPort
+          .getAvailableExternalTorConfig();
 
       if (externalTorConfig == null) {
         await _initializeTorUsecase.execute();
@@ -253,8 +254,8 @@ class RecoverBullBloc extends Bloc<RecoverBullEvent, RecoverBullState> {
       switch (event.provider) {
         case VaultProvider.googleDrive:
           await _connectToGoogleDriveUsecase.execute();
-          final encryptedVault =
-              await _fetchLatestGoogleDriveVaultUsecase.execute();
+          final encryptedVault = await _fetchLatestGoogleDriveVaultUsecase
+              .execute();
           emit(state.copyWith(vault: encryptedVault));
           return;
         case VaultProvider.customLocation: