chore: remove dead localization keys and clean up cubit

Author: wired-pasteque

lib/features/replace_by_fee/presentation/cubit.dart

@@ -47,10 +47,6 @@ class ReplaceByFeeCubit extends Cubit<ReplaceByFeeState> {
     }
   }
 
-  void clearFailure() => emit(state.copyWith(failure: null));
-
-  void reset() => emit(const ReplaceByFeeState());
-
   Future<void> broadcast() async {
     emit(state.copyWith(failure: null));
 
@@ -80,9 +76,9 @@ class ReplaceByFeeCubit extends Cubit<ReplaceByFeeState> {
   }
 
   /// A valid (above-floor) selection — from a custom keystroke or the Fastest
-  /// tile. Clears any prior below-floor flag.
+  /// tile. Clears any prior below-floor flag and any broadcast failure.
   void onChangeFee(FeeEntity fee) =>
-      emit(state.copyWith(newFeeRate: fee, customFeeBelowFloor: false));
+      emit(state.copyWith(newFeeRate: fee, customFeeBelowFloor: false, failure: null));
 
   /// The custom field went below the relay floor or was emptied. Keep
   /// [newFeeRate] (the last valid value / init sentinel) but flag the field so

localization/app_ar.arb

@@ -1150,10 +1150,6 @@
   "@swapErrorBalanceTooLow": {
     "description": "Error when balance is below minimum swap limit"
   },
-  "replaceByFeeErrorGeneric": "وقع خطأ أثناء محاولة استبدال الصفقة",
-  "@replaceByFeeErrorGeneric": {
-    "description": "Generic error message for replace-by-fee operation failures"
-  },
   "fundExchangeWarningTactic5": "يطلبون إرسال (بيتكوين) على منصة أخرى",
   "@fundExchangeWarningTactic5": {
     "description": "Fifth scammer tactic warning"
@@ -6493,10 +6489,6 @@
   "@arkSendConfirm": {
     "description": "Confirm button on send screen"
   },
-  "replaceByFeeErrorTransactionConfirmed": "تم تأكيد الصفقة الأصلية",
-  "@replaceByFeeErrorTransactionConfirmed": {
-    "description": "Error message when original transaction is already confirmed"
-  },
   "rbfErrorFeeTooLow": "تحتاج إلى زيادة معدل الرسوم على الأقل 1 سات/فبيت بالمقارنة مع الصفقة الأصلية",
   "@rbfErrorFeeTooLow": {
     "description": "Error when new fee rate is not high enough"

localization/app_as.arb

@@ -3029,14 +3029,6 @@
   "@replaceByFeeErrorNoFeeRateSelected": {
     "description": "Error message when no fee rate is selected"
   },
-  "replaceByFeeErrorTransactionConfirmed": "মূল লেনদেন নিশ্চিত হৈছে",
-  "@replaceByFeeErrorTransactionConfirmed": {
-    "description": "Error message when original transaction is already confirmed"
-  },
-  "replaceByFeeErrorGeneric": "লেনদেন প্ৰতিস্থাপন কৰিবলৈ চেষ্টা কৰোঁতে এটা ত্ৰুটি ঘটিছে",
-  "@replaceByFeeErrorGeneric": {
-    "description": "Generic error message for replace-by-fee operation failures"
-  },
   "replaceByFeeFastestDescription": "আনুমানিক সময় ~ ১০ মিনিট",
   "@replaceByFeeFastestDescription": {
     "description": "Description for fastest fee option"

localization/app_bg.arb

@@ -1165,10 +1165,6 @@
   "@swapErrorBalanceTooLow": {
     "description": "Error when balance is below minimum swap limit"
   },
-  "replaceByFeeErrorGeneric": "Възникна грешка при опита за замяна на транзакцията.",
-  "@replaceByFeeErrorGeneric": {
-    "description": "Generic error message for replace-by-fee operation failures"
-  },
   "fundExchangeWarningTactic5": "Те искат да изпратите Bitcoin на друга платформа",
   "@fundExchangeWarningTactic5": {
     "description": "Fifth scammer tactic warning"
@@ -5373,10 +5369,6 @@
   "@sendAbsoluteFees": {
     "description": "Label for absolute fee display mode (total sats)"
   },
-  "replaceByFeeErrorTransactionConfirmed": "Оригиналната транзакция е потвърдена.",
-  "@replaceByFeeErrorTransactionConfirmed": {
-    "description": "Error message when original transaction is already confirmed"
-  },
   "rbfErrorFeeTooLow": "Трябва да увеличите таксата с поне 1 сат/байт спрямо оригиналната транзакция.",
   "@rbfErrorFeeTooLow": {
     "description": "Error when new fee rate is not high enough"

localization/app_bn.arb

@@ -1199,10 +1199,6 @@
   "@swapErrorBalanceTooLow": {
     "description": "Error when balance is below minimum swap limit"
   },
-  "replaceByFeeErrorGeneric": "ট্রান্স্যাকশনটি ফি দ্বারা প্রতিস্থাপন করার চেষ্টা করার সময় একটি ত্রুটি ঘটেছে",
-  "@replaceByFeeErrorGeneric": {
-    "description": "Generic error message for replace-by-fee operation failures"
-  },
   "fundExchangeWarningTactic5": "তারা অন্য প্ল্যাটফর্মে বিটকয়েন পাঠাতে বলছে",
   "@fundExchangeWarningTactic5": {
     "description": "Fifth scammer tactic warning"
@@ -6741,10 +6737,6 @@
   "@arkSendConfirm": {
     "description": "Confirm button on send screen"
   },
-  "replaceByFeeErrorTransactionConfirmed": "মূল ট্রান্স্যাকশনটি নিশ্চিত হয়েছে",
-  "@replaceByFeeErrorTransactionConfirmed": {
-    "description": "Error message when original transaction is already confirmed"
-  },
   "rbfErrorFeeTooLow": "মূল ট্রান্স্যাকশনটির তুলনায় ফি রেট অন্তত 1 sat/vbyte বেশি করতে হবে",
   "@rbfErrorFeeTooLow": {
     "description": "Error when new fee rate is not high enough"

localization/app_cs.arb

@@ -1467,10 +1467,6 @@
   "@swapErrorBalanceTooLow": {
     "description": "Error when balance is below minimum swap limit"
   },
-  "replaceByFeeErrorGeneric": "Chyba došlo při pokusu o nahrazení transakce",
-  "@replaceByFeeErrorGeneric": {
-    "description": "Generic error message for replace-by-fee operation failures"
-  },
   "fundExchangeWarningTactic5": "Zeptají se, aby poslal Bitcoin na jinou platformu",
   "@fundExchangeWarningTactic5": {
     "description": "Fifth scammer tactic warning"
@@ -6868,10 +6864,6 @@
   "@sendAbsoluteFees": {
     "description": "Label for absolute fee display mode (total sats)"
   },
-  "replaceByFeeErrorTransactionConfirmed": "Původní transakce byla potvrzena",
-  "@replaceByFeeErrorTransactionConfirmed": {
-    "description": "Error message when original transaction is already confirmed"
-  },
   "rbfErrorFeeTooLow": "Musíte zvýšit poplatek minimálně 1 sat/vbyte ve srovnání s původní transakcí",
   "@rbfErrorFeeTooLow": {
     "description": "Error when new fee rate is not high enough"

localization/app_de.arb

@@ -418,7 +418,6 @@
   "sendSendAmount": "Betrag",
   "sendSelectedUtxosInsufficient": "Die ausgewählten UTXOs decken den erforderlichen Betrag nicht ab.",
   "swapErrorBalanceTooLow": "Guthaben zu niedrig für den Mindest-Swap-Betrag.",
-  "replaceByFeeErrorGeneric": "Beim Versuch, die Transaktion zu ersetzen, trat ein Fehler auf.",
   "fundExchangeWarningTactic5": "Sie bitten darum, Bitcoin an eine andere Plattform zu senden.",
   "rbfCustomFee": "Benutzerdefinierte Gebühren",
   "importQrDeviceFingerprint": "Fingerabdruck",
@@ -2224,7 +2223,6 @@
   "payDecodeFailed": "Rechnung konnte nicht entschlüsselt werden",
   "sendAbsoluteFees": "Gesamtgebühren",
   "arkSendConfirm": "Bestätigen",
-  "replaceByFeeErrorTransactionConfirmed": "Die ursprüngliche Transaktion wurde bestätigt.",
   "rbfErrorFeeTooLow": "Sie müssen den Gebührensatz um mindestens 1 sat/vbyte gegenüber der ursprünglichen Transaktion erhöhen.",
   "ledgerErrorMissingDerivationPathSign": "Der Ableitungspfad ist zur Anmeldung erforderlich.",
   "backupWalletTitle": "Sichern Sie Ihre Wallet",

localization/app_el.arb

@@ -1055,10 +1055,6 @@
   "@swapErrorBalanceTooLow": {
     "description": "Error when balance is below minimum swap limit"
   },
-  "replaceByFeeErrorGeneric": "Ένα λάθος συνέβη ενώ επιχειρεί να αντικαταστήσει τη συναλλαγή",
-  "@replaceByFeeErrorGeneric": {
-    "description": "Generic error message for replace-by-fee operation failures"
-  },
   "fundExchangeWarningTactic5": "Ζητούν να στείλουν Bitcoin σε άλλη πλατφόρμα",
   "@fundExchangeWarningTactic5": {
     "description": "Fifth scammer tactic warning"
@@ -5760,10 +5756,6 @@
   "@arkSendConfirm": {
     "description": "Confirm button on send screen"
   },
-  "replaceByFeeErrorTransactionConfirmed": "Η αρχική συναλλαγή έχει επιβεβαιωθεί",
-  "@replaceByFeeErrorTransactionConfirmed": {
-    "description": "Error message when original transaction is already confirmed"
-  },
   "rbfErrorFeeTooLow": "Πρέπει να αυξήσετε το ποσοστό χρέωσης κατά τουλάχιστον 1 sat/vbyte σε σύγκριση με την αρχική συναλλαγή",
   "@rbfErrorFeeTooLow": {
     "description": "Error when new fee rate is not high enough"

localization/app_en.arb

@@ -6191,14 +6191,6 @@
   "@replaceByFeeErrorNoFeeRateSelected": {
     "description": "Error message when no fee rate is selected"
   },
-  "replaceByFeeErrorTransactionConfirmed": "The original transaction has been confirmed",
-  "@replaceByFeeErrorTransactionConfirmed": {
-    "description": "Error message when original transaction is already confirmed"
-  },
-  "replaceByFeeErrorGeneric": "An error occurred while attempting to replace the transaction",
-  "@replaceByFeeErrorGeneric": {
-    "description": "Generic error message for replace-by-fee operation failures"
-  },
   "replaceByFeeFastestDescription": "Estimated delivery ~ 10 minutes",
   "@replaceByFeeFastestDescription": {
     "description": "Description for fastest fee option"

localization/app_es.arb

@@ -1775,8 +1775,6 @@
   "replaceByFeeCustomFeeTitle": "Tarifa personalizada",
   "replaceByFeeErrorFeeRateTooLow": "Necesita aumentar la tasa de tarifa en al menos 1 sat/vbyte en comparación con la transacción original",
   "replaceByFeeErrorNoFeeRateSelected": "Por favor seleccione una tasa de tarifa",
-  "replaceByFeeErrorTransactionConfirmed": "La transacción original ha sido confirmada",
-  "replaceByFeeErrorGeneric": "Ocurrió un error al intentar reemplazar la transacción",
   "replaceByFeeFastestDescription": "Entrega estimada ~ 10 minutos",
   "replaceByFeeFastestTitle": "Más rápido",
   "replaceByFeeFeeRateDisplay": "Tasa de tarifa: {feeRate} sat/vbyte",