Merge pull request #2300 from SatoshiPortal/2202-qr-scanner-fails-on-non-standard-bip21-donation-uris

fix: handle non-standard BIP21 URIs in QR scanner

Author: i5hi

integration_test/payment_request_test.dart

@@ -0,0 +1,58 @@
+import 'package:bb_mobile/core/utils/payment_request.dart';
+import 'package:bb_mobile/core/wallet/domain/entities/wallet.dart';
+import 'package:bb_mobile/main.dart';
+import 'package:flutter_test/flutter_test.dart';
+
+Future<void> main({bool isInitialized = false}) async {
+  TestWidgetsFlutterBinding.ensureInitialized();
+  if (!isInitialized) await Bull.init();
+
+  const btcAddress = 'bc1qar0srrr7xfkvy5l643lydnw9re59gtzzwf5mdq';
+
+  const lnurlStr =
+      'lnurl1dp68gurn8ghj7um9wfmxjcm99e3k7mf0v9cxj0m385ekvcenxc6r2c35xvukxefcv5'
+      'mkvv34x5ekzd3ev56nyd3hxqurzepexejxxepnxscrvwfnv9nxzcn9xq6xyefhvgcxxcmyxy'
+      'mnserxfq5fns';
+
+  const bolt11Invoice =
+      'lnbc2500u1pvjluezpp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypq'
+      'dq5xysxxatsyp3k7enxv4jsxqzpuaztrnwngzn3kdzw5hydlzf03qdgm2hdq27cqv3agm2aw'
+      'hz5se903vruatfhq77w3ls4evs3ch9zw97j25emudupq63nyw24cg27h2rspfj9srp';
+
+  group('PaymentRequest.parse', () {
+    test('BIP21 with LNURL lightning param, label, and message', () async {
+      final input =
+          'bitcoin:$btcAddress?lightning=$lnurlStr&label=Donation&message=Thanks';
+      final result = await PaymentRequest.parse(input);
+      expect(result, isA<Bip21PaymentRequest>());
+      final bip21 = result as Bip21PaymentRequest;
+      expect(bip21.address.toLowerCase(), btcAddress);
+      expect(bip21.lightning, lnurlStr);
+      expect(bip21.label, 'Donation');
+      expect(bip21.message, 'Thanks');
+      expect(bip21.network, Network.bitcoinMainnet);
+    });
+
+    test('BIP21 with Bolt11 lightning param', () async {
+      final input = 'bitcoin:$btcAddress?lightning=$bolt11Invoice';
+      final result = await PaymentRequest.parse(input);
+      expect(result, isA<Bip21PaymentRequest>());
+      final bip21 = result as Bip21PaymentRequest;
+      expect(bip21.address.toLowerCase(), btcAddress);
+      expect(bip21.lightning, bolt11Invoice);
+      expect(bip21.network, Network.bitcoinMainnet);
+    });
+
+    test('HTTPS URL with percent-encoded LNAddress in lightning param', () async {
+      const input =
+          'https://admin.bullbitcoin.com/abc'
+          '?lightning=ishi%40walletofsatoshi.com&label=pleasefundme';
+      final result = await PaymentRequest.parse(input);
+      expect(result, isA<LnAddressPaymentRequest>());
+      expect(
+        (result as LnAddressPaymentRequest).address,
+        'ishi@walletofsatoshi.com',
+      );
+    });
+  });
+}

lib/core/utils/payment_request.dart

@@ -78,6 +78,25 @@ sealed class PaymentRequest with _$PaymentRequest {
         if (result != null) return result;
       }
 
+      final re = RegExp(r'lnurl[0-9a-z]+', caseSensitive: false);
+      final m = re.firstMatch(trimmed);
+
+      if (m != null) {
+        final result = await _tryParseLnAddress(m.group(0)!);
+        if (result != null) return result;
+      }
+
+      final lnAddressRe = RegExp(
+        r'[a-zA-Z0-9._%+\-]+(?:@|%40)[a-zA-Z0-9.\-]+\.[a-zA-Z]{2,}',
+      );
+      final lnAddressMatch = lnAddressRe.firstMatch(trimmed);
+
+      if (lnAddressMatch != null) {
+        final decoded = Uri.decodeComponent(lnAddressMatch.group(0)!);
+        final result = await _tryParseLnAddress(decoded);
+        if (result != null) return result;
+      }
+
       if (trimmed.toLowerCase().startsWith('lnbc') ||
           trimmed.toLowerCase().startsWith('lntb') ||
           trimmed.toLowerCase().startsWith('lightning:')) {

lib/features/send/presentation/bloc/send_cubit.dart

@@ -236,7 +236,10 @@ class SendCubit extends Cubit<SendState> {
         emit(
           state.copyWith(
             loadingBestWallet: false,
-            invalidBitcoinStringException: InvalidBitcoinStringException(),
+            invalidBitcoinStringException:
+                state.scannedRawPaymentRequest.isNotEmpty
+                ? UnsupportedQrFormatException()
+                : InvalidBitcoinStringException(),
           ),
         );
         return;

lib/features/send/presentation/bloc/send_state.dart

@@ -472,7 +472,8 @@ class AmountlessInvoiceException extends SwapCreationException {
 }
 
 class HardwareWalletSwapException extends SwapCreationException {
-  HardwareWalletSwapException() : super('Hardware wallets cannot be used for swaps');
+  HardwareWalletSwapException()
+    : super('Hardware wallets cannot be used for swaps');
 }
 
 class ExpiredInvoiceException extends SwapCreationException {
@@ -491,6 +492,8 @@ class InvalidBitcoinStringException extends BullException {
   ]);
 }
 
+class UnsupportedQrFormatException extends InvalidBitcoinStringException {}
+
 /// Exception for swap limit violations.
 /// Stored in SendState with min/max limit values for localized error messages.
 /// UI displays context-specific messages using sendErrorAmountBelowMinimum,

lib/features/send/ui/screens/full_screen_scanner_page.dart

@@ -36,8 +36,8 @@ class _FullScreenScannerState extends State<FullScreenScannerPage> {
     } catch (e) {
       data = (qr, null);
       widget.onScannedPaymentRequest(data);
+      if (mounted) context.pop();
     }
-    setState(() {});
   }
 
   @override

lib/features/send/ui/screens/send_screen.dart

@@ -261,7 +261,9 @@ class AddressErrorSection extends StatelessWidget {
     }
     if (invalidAddress != null) {
       return BBText(
-        context.loc.sendErrorInvalidAddressOrInvoice,
+        invalidAddress is UnsupportedQrFormatException
+            ? context.loc.sendErrorUnsupportedQrCodeFormat
+            : context.loc.sendErrorInvalidAddressOrInvoice,
         style: context.font.bodyMedium,
         color: context.appColors.error,
         textAlign: .center,

localization/app_ar.arb

@@ -2345,6 +2345,7 @@
   "@sendErrorInvalidAddressOrInvoice": {
     "description": "Error when payment request is invalid"
   },
+  "sendErrorUnsupportedQrCodeFormat": "تنسيق رمز QR غير مدعوم",
   "transactionLabelAmountReceived": "المبلغ المستلم",
   "@transactionLabelAmountReceived": {
     "description": "Label for received amount"

localization/app_as.arb

@@ -4165,6 +4165,7 @@
   "@sendErrorInvalidAddressOrInvoice": {
     "description": "Error when payment request is invalid"
   },
+  "sendErrorUnsupportedQrCodeFormat": "অসমৰ্থিত QR ক'ড ফৰ্মেট",
   "sendErrorBuildFailed": "নিৰ্মাণ বিফল হৈছে",
   "@sendErrorBuildFailed": {
     "description": "Error title when transaction build fails"

localization/app_bg.arb

@@ -2125,6 +2125,7 @@
   "@sendErrorInvalidAddressOrInvoice": {
     "description": "Error when payment request is invalid"
   },
+  "sendErrorUnsupportedQrCodeFormat": "Неподдържан формат на QR код",
   "transactionLabelAmountReceived": "Получена сума",
   "@transactionLabelAmountReceived": {
     "description": "Label for received amount"

localization/app_bn.arb

@@ -2460,6 +2460,7 @@
   "@sendErrorInvalidAddressOrInvoice": {
     "description": "Error when payment request is invalid"
   },
+  "sendErrorUnsupportedQrCodeFormat": "অসমর্থিত QR কোড ফরম্যাট",
   "transactionLabelAmountReceived": "প্রাপ্ত পরিমাণ",
   "@transactionLabelAmountReceived": {
     "description": "Label for received amount"