Merge pull request #1784 from SatoshiPortal/refactor-labels

BREAKING CHANGE: refactor labels with the new architecture

Author: ethicnology

lib/core/core_locator.dart

@@ -4,7 +4,7 @@ import 'package:bb_mobile/core/blockchain/blockchain_locator.dart';
 import 'package:bb_mobile/core/electrum/frameworks/di/electrum_locator.dart';
 import 'package:bb_mobile/core/exchange/exchange_locator.dart';
 import 'package:bb_mobile/core/fees/fees_locator.dart';
-import 'package:bb_mobile/core/labels/labels_locator.dart';
+import 'package:bb_mobile/features/labels/labels_facade.dart';
 import 'package:bb_mobile/core/ledger/ledger_locator.dart';
 import 'package:bb_mobile/core/mempool/mempool_locator.dart';
 import 'package:bb_mobile/core/payjoin/payjoin_locator.dart';
@@ -24,7 +24,6 @@ class CoreLocator {
   }
 
   static Future<void> registerDatasources(GetIt locator) async {
-    LabelsLocator.registerDatasources(locator);
     await TorLocator.registerDatasources(locator);
     BlockchainLocator.registerDatasources(locator);
     await ElectrumLocator.registerDatasources(locator);
@@ -49,10 +48,10 @@ class CoreLocator {
     MempoolLocator.registerPorts(locator);
     SwapsLocator.registerPorts(locator);
     WalletLocator.registerPorts(locator);
+    LabelsLocator.registerPorts(locator);
   }
 
   static Future<void> registerRepositories(GetIt locator) async {
-    LabelsLocator.registerRepositories(locator);
     await TorLocator.registerRepositories(locator);
     BlockchainLocator.registerRepositories(locator);
     ElectrumLocator.registerRepositories(locator);
@@ -96,4 +95,12 @@ class CoreLocator {
     LedgerLocator.registerUsecases(locator);
     BitBoxCoreLocator.registerUsecases(locator);
   }
+
+  static void registerFacades(GetIt locator) {
+    LabelsLocator.registerFacade(locator);
+  }
+
+  static void registerFrameworks(GetIt locator) {
+    LabelsLocator.registerFrameworks(locator);
+  }
 }

lib/core/exchange/domain/usecases/label_exchange_orders_usecase.dart

@@ -1,22 +1,16 @@
 import 'package:bb_mobile/core/exchange/domain/entity/order.dart';
 import 'package:bb_mobile/core/exchange/domain/usecases/list_all_orders_usecase.dart';
-import 'package:bb_mobile/core/labels/data/label_datasource.dart';
-import 'package:bb_mobile/core/labels/domain/batch_labels_usecase.dart';
-import 'package:bb_mobile/core/labels/domain/label.dart';
-import 'package:bb_mobile/core/labels/label_system.dart';
 import 'package:bb_mobile/core/utils/logger.dart';
+import 'package:bb_mobile/features/labels/labels_facade.dart';
 
 class LabelExchangeOrdersUsecase {
-  final LabelDatasource _labelDatasource;
-  final BatchLabelsUsecase _batchLabelsUsecase;
+  final LabelsFacade _labelsFacade;
   final ListAllOrdersUsecase _listAllOrdersUsecase;
 
   LabelExchangeOrdersUsecase({
-    required LabelDatasource labelDatasource,
-    required BatchLabelsUsecase batchLabelsUsecase,
+    required LabelsFacade labelsFacade,
     required ListAllOrdersUsecase listAllOrdersUsecase,
-  }) : _labelDatasource = labelDatasource,
-       _batchLabelsUsecase = batchLabelsUsecase,
+  }) : _labelsFacade = labelsFacade,
        _listAllOrdersUsecase = listAllOrdersUsecase;
 
   Future<void> execute() async {
@@ -59,7 +53,7 @@ class LabelExchangeOrdersUsecase {
         }
       }
 
-      await _batchLabelsUsecase.execute(labels);
+      await _labelsFacade.store(labels);
 
       log.fine(
         '$LabelExchangeOrdersUsecase labeled ${orders.length} exchange orders',
@@ -71,11 +65,11 @@ class LabelExchangeOrdersUsecase {
 
   Future<bool> _hasExistingExchangeSystemLabels() async {
     try {
-      final allLabels = await _labelDatasource.fetchAll();
+      final allLabels = await _labelsFacade.fetch();
       return allLabels.any(
         (label) =>
-            label.label == LabelSystem.exchangeBuy.label ||
-            label.label == LabelSystem.exchangeSell.label,
+            LabelSystem.isSystemLabel(label) &&
+            LabelSystem.fromLabel(label).isExchangeRelated(),
       );
     } catch (e) {
       log.warning('$LabelExchangeOrdersUsecase: $e');

lib/core/exchange/exchange_locator.dart

@@ -35,9 +35,7 @@ import 'package:bb_mobile/core/exchange/domain/usecases/refresh_price_history_us
 import 'package:bb_mobile/core/exchange/domain/usecases/save_exchange_api_key_usecase.dart';
 import 'package:bb_mobile/core/exchange/domain/usecases/send_support_chat_message_usecase.dart';
 import 'package:bb_mobile/core/exchange/domain/usecases/save_user_preferences_usecase.dart';
-import 'package:bb_mobile/core/labels/data/label_datasource.dart';
-import 'package:bb_mobile/core/labels/data/label_repository.dart';
-import 'package:bb_mobile/core/labels/domain/batch_labels_usecase.dart';
+import 'package:bb_mobile/features/labels/labels_facade.dart';
 import 'package:bb_mobile/core/settings/data/settings_repository.dart';
 import 'package:bb_mobile/core/storage/data/datasources/key_value_storage/key_value_storage_datasource.dart';
 import 'package:bb_mobile/core/storage/sqlite_database.dart';
@@ -340,7 +338,7 @@ class ExchangeLocator {
           instanceName: 'testnetExchangeOrderRepository',
         ),
         settingsRepository: locator<SettingsRepository>(),
-        labelsRepository: locator<LabelRepository>(),
+        labelsFacade: locator<LabelsFacade>(),
       ),
     );
 
@@ -482,8 +480,7 @@ class ExchangeLocator {
 
     locator.registerFactory<LabelExchangeOrdersUsecase>(
       () => LabelExchangeOrdersUsecase(
-        labelDatasource: locator<LabelDatasource>(),
-        batchLabelsUsecase: locator<BatchLabelsUsecase>(),
+        labelsFacade: locator<LabelsFacade>(),
         listAllOrdersUsecase: locator<ListAllOrdersUsecase>(),
       ),
     );