Exchange settings by mocodesmo · Pull Request #1727 · SatoshiPortal/bullbitcoin-mobile

mocodesmo · 2026-01-05T05:38:00Z

1. New Exchange Settings Menu Items

The Exchange Settings screen now includes several new functional menu entries (previously commented out/placeholder):

Recipients — Now navigates to a fully functional Recipients screen using the existing RecipientsScreen and RecipientsBloc
Transactions — Now shows a dedicated exchange transactions view with buy/sell filtering
Default Bitcoin Wallets — Fully functional wallet address management
App Settings — User preferences (language, currency, email notifications)
Secure File Upload — KYC document upload with status indicators
Statistics — New screen showing trading statistics

2. Default Bitcoin Wallets Screen

File: lib/features/settings/ui/screens/exchange/bitcoin_wallets_screen.dart

Complete redesign with functional wallet management:

Description text explaining the purpose
Three wallet address fields: Bitcoin, Lightning, Liquid
Edit/Save/Cancel workflow for each address type
Delete functionality per address
Address truncation for display (shows first 10 and last 8 characters)
Success/Error snackbars for save operations
Loading and error states with retry button

3. App Settings Screen

File: lib/features/settings/ui/screens/exchange/app_settings_screen.dart

Enhanced with new functionality:

Email Notifications Toggle — New switch with label and description to enable/disable email notifications
Improved styling — Updated colors, shadows, and typography
Auto-refresh on screen load via initState
Fixed enum references (e.g., TextAlign.center, SnackBarBehavior.floating)

4. Secure File Upload Screen

File: lib/features/settings/ui/screens/exchange/file_upload_screen.dart

Completely redesigned with functional upload capability:

Upload option card similar to BB-Exchange styling
Status indicators:
- Upload (ready state with upload button)
- In Review (warning-styled badge)
- Accepted (success-styled badge)
Error display with dismiss button
Loading states during user fetch and file upload
Success snackbar on successful upload
Disabled state when file is already uploaded or under review

5. New Statistics Screen

File: lib/features/settings/ui/screens/exchange/statistics_screen.dart

Brand new screen showing user trading statistics:

Order Statistics Section:
- Buy/Sell Ratio card
- Buy Statistics (volume, trade count, average price)
- Sell Statistics (volume, trade count, average price)
- Total Trading Volume
Biller Statistics Section (when available):
- Stats by payment method/biller
- Total amount and trade count per biller
Loading, error, and empty states
"As of" timestamp showing when data was last updated
Formatted numbers (K/M suffixes for large values)

6. Transactions Screen Enhancements

Files:

lib/features/settings/ui/screens/exchange/transactions_screen.dart
lib/features/transactions/presentation/blocs/transactions_cubit.dart
lib/features/transactions/presentation/blocs/transactions_state.dart
lib/features/transactions/ui/widgets/txs_filter_row.dart

The exchange transactions screen now:

Uses the existing TransactionsScreen with an exchangeOnly mode
Filters limited to: All, Sell, Buy (hides Send, Receive, Swap, Payjoin filters)
Only shows order transactions (no wallet transactions)

7. Recipients Screen

File: lib/features/settings/ui/screens/exchange/recipients_screen.dart

Now fully functional using the existing recipients infrastructure:

Reuses RecipientsScreen widget
Integrates RecipientsBloc for data management
Allows navigation to pay flow when recipient is selected

8. New Localization Strings

File: localization/app_en.arb

~40+ new localization keys added for:

Email notifications labels/descriptions
Bitcoin wallets screen texts
File upload statuses and messages
Statistics screen labels (order stats, biller stats, volume, trade count, etc.)
Generic retry button label

Navigation Flow

Exchange Settings
├── Recipients → Full recipients list with pay flow
├── Transactions → Exchange-only transactions (buy/sell orders)
├── Default Bitcoin Wallets → Manage BTC/Lightning/Liquid addresses
├── App Settings → Language, Currency, Email Notifications
├── Secure File Upload → KYC document upload with status
├── Statistics → Trading statistics dashboard
├── Referrals → (existing)
├── Security → (existing)
├── Account → (existing)
└── Log Out → (existing)

…creen

…nagement - Introduced email notifications toggle in exchange app settings with corresponding localization. - Enhanced the ExchangeBitcoinWalletsScreen to manage default wallet addresses with improved UI and feedback mechanisms. - Implemented file upload functionality in ExchangeFileUploadScreen, including error handling and user feedback. - Added statistics screen for exchange with relevant data display and localization support. - Updated various models and state management to accommodate new features.

- Updated TransactionsCubit to accept an exchangeOnly parameter for filtering transactions. - Modified TransactionsState to include exchangeOnly state and adjust available filters accordingly. - Adjusted the TransactionsScreen to initialize TransactionsCubit with the new parameter. - Updated TxsFilterRow to utilize the available filters based on the exchangeOnly state.

- Added functionality to navigate to the PayRoute with the selected recipient when a recipient is chosen. - Introduced RecipientViewModel to facilitate passing recipient data during navigation.

- Added recipientType parameter to updateMyRecipient method for better API integration. - Updated deleteDefaultWallet method to include walletType and address parameters. - Adjusted related use cases and cubit to accommodate new parameters for improved wallet management.

- Enhanced the KYC document upload functionality to use base64 encoding for file data. - Updated the API request structure to include file type and size information. - Introduced new models for managing KYC document statuses and integrated them into the user summary. - Modified the file upload UI to support single file uploads and reflect the current upload status. - Added localization for success and status messages related to KYC document uploads.

kumulynja

Quickly saw these two things already, should review the rest still too.

- Changed the KYC document upload method to utilize multipart form data instead of base64 encoding. - Updated the API request structure to remove file type and size parameters, focusing on file upload via FormData. - Enhanced error handling to check for various error indicators in the API response.

- Added KYC document status handling in user summary mapping. - Updated file upload state to include user data loading status. - Improved UI interactions based on KYC document upload status, allowing re-upload for rejected files. - Localized messages for KYC upload statuses, including a new message for rejected uploads.

mocodesmo · 2026-01-12T18:31:57Z

this is ready to be merged and for testing

…and withdraw wrap it and pass their own hook, errors and loading indication to it

…ents Recipients reuse improvements

mocodesmo · 2026-01-19T13:29:42Z

@kumulynja is this pr ready to go after your changes?
let me know if anything else is required from my side

kumulynja · 2026-01-21T11:42:01Z

@kumulynja is this pr ready to go after your changes?
let me know if anything else is required from my side

Yeah, I focused the review and commits mostly on the recipients stuff and that should be good now. The rest is new and should be good for now too 👍

mocodesmo added 8 commits December 30, 2025 17:25

feat: add recipients and transactions settings to exchange settings s…

aa1580a

…creen

Merge branch 'develop' into exchange-settings

83ae0f8

feat: update ExchangeRecipientsScreen to handle recipient selection

3bb5dc4

- Added functionality to navigate to the PayRoute with the selected recipient when a recipient is chosen. - Introduced RecipientViewModel to facilitate passing recipient data during navigation.

Merge branch 'develop' into exchange-settings

c8b5189

mocodesmo requested review from ethicnology, i5hi and kumulynja January 5, 2026 05:38

kumulynja requested changes Jan 5, 2026

View reviewed changes

Comment thread lib/core/exchange/data/datasources/bullbitcoin_api_datasource.dart

Comment thread lib/features/settings/ui/screens/exchange/recipients_screen.dart Outdated

mocodesmo added 2 commits January 8, 2026 23:26

kumulynja and others added 3 commits January 17, 2026 15:16

restructured reusable recipients screen, recipients bloc and how pay …

57ae3be

…and withdraw wrap it and pass their own hook, errors and loading indication to it

remove info logs for debugging + unused gap import

e5a685b

Merge pull request #1786 from SatoshiPortal/recipients-reuse-improvem…

8efe8a4

…ents Recipients reuse improvements

mocodesmo mentioned this pull request Jan 21, 2026

Architectural Patterns: Feature Isolation and UI Integration #1817

Open

8 tasks

i5hi added 2 commits January 21, 2026 18:54

Merge branch 'develop' into exchange-settings

91a02d5

fix: remove recipients router

cb4ef9a

i5hi approved these changes Jan 21, 2026

View reviewed changes

i5hi merged commit 17a2bc2 into develop Jan 21, 2026
1 check passed

thibistaken deleted the exchange-settings branch March 19, 2026 08:52

Navigation Menu

Uh oh!

Exchange settings - #1727

Exchange settings#1727
i5hi merged 15 commits into
developfrom
exchange-settings

mocodesmo commented Jan 5, 2026

Uh oh!

kumulynja left a comment

Uh oh!

Uh oh!

Uh oh!

mocodesmo commented Jan 12, 2026

Uh oh!

mocodesmo commented Jan 19, 2026

Uh oh!

kumulynja commented Jan 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mocodesmo commented Jan 5, 2026

1. New Exchange Settings Menu Items

2. Default Bitcoin Wallets Screen

3. App Settings Screen

4. Secure File Upload Screen

5. New Statistics Screen

6. Transactions Screen Enhancements

7. Recipients Screen

8. New Localization Strings

Navigation Flow

Uh oh!

kumulynja left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mocodesmo commented Jan 12, 2026

Uh oh!

mocodesmo commented Jan 19, 2026

Uh oh!

kumulynja commented Jan 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants