Exchange Announcement Banner improvements - #1771
Merged
Merged
Conversation
Contributor
Author
Contributor
|
Bottom sheet is a good idea |
i5hi
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


1. Banner Card Improvements
Before: The banner displayed the full description text, taking up multiple lines.
After:
...) to keep the banner compactGestureDetectorto open a bottom sheet with full detailssecondary) with white text (onSecondary) — original lookoutlineat 30% opacity) and light text (onSurface)2. New Bottom Sheet (
_AnnouncementBottomSheet)A new bottom sheet component was added that appears when tapping an announcement:
Structure:
BlurredBottomSheet.show()pattern for consistent stylingonSurfacecolor — black in light mode, white in dark mode)titleLargewith bold weight)Layout Features:
maxHeightconstraint (80% of screen) to prevent overflowSingleChildScrollViewwraps the description for very long textcrossAxisAlignment: centeron the header row for proper icon/text alignmentcontext.appColors.surfacebackground — adapts to light/dark mode3. Dark Mode Support
All colors use theme-aware
context.appColorsvalues:secondary(black)surface(dark)outlineat 30% opacityonSecondary(white)onSurface(light)surface(light)surface(dark)onSurface(dark)onSurface(light)