Skip to content

fix: transfer flow should allow receive exact amount option for liquid. better errors in form validation. escalation backup warning content as a bulleted list. - #2249

Merged
i5hi merged 1 commit into
developfrom
backup-warning-updates
Jun 5, 2026
Merged

fix: transfer flow should allow receive exact amount option for liquid. better errors in form validation. escalation backup warning content as a bulleted list.#2249
i5hi merged 1 commit into
developfrom
backup-warning-updates

Conversation

@i5hi

@i5hi i5hi commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Fixes:
Transfer Flow:

  • Show the Recieve Exact Amount option when the from wallet is liquid
  • Insufficient balance should be a form validation error
  • Continue should not be clickable if form is not validated
  • Split the single large warning into two small warnings after transfer is confirmed

Backup Content:

  • Display content as a bulleted list for easier reading
Simulator Screenshot - iPhone 17 Pro - 2026-06-05 at 17 19 07

@claude

claude Bot commented Jun 5, 2026

Copy link
Copy Markdown

Claude finished @i5hi's task in 2m 14s —— View job


Code Review — PR #2249

  • Gather context (diff vs origin/develop)
  • Review Dart changes (backup_warning_overlay.dart)
  • Review localization changes (27 .arb files)
  • Validate key consistency across locales
  • Post review

Scope note

The diff against origin/develop contains only the backup-warning bullet refactor and the 27 localization files. The transfer-flow items in the PR description (receive-exact-amount for Liquid, insufficient-balance form validation, continue-disabled, split warning boxes) are not present in this diff — they appear to already be on develop. Worth confirming the PR checklist reflects what this branch actually changes.

Findings

1. ⚠️ Medium — Bottom sheet can overflow vertically (no scroll)
lib/features/wallet/ui/widgets/backup_warning_overlay.dart:64-141

The content is a Column(mainAxisSize: MainAxisSize.min) inside Align(bottomCenter) with no scrolling. This refactor grows the content substantially: intro line + 5 bullets (the keystore bullet is long) + a bold closing line + 2 big buttons. On small screens, with large accessibility text scaling, or with longer translations (e.g. German/Arabic keystore strings), this risks a RenderFlex overflow and clipped/unreachable buttons.

Recommend wrapping the text block (or the whole content) in a SingleChildScrollView with Flexible/a max-height constraint so the bullets scroll while the action buttons stay visible.

Fix this →

2. 🟢 Nit — Bullet glyph layout
backup_warning_overlay.dart:94-105

'• ' uses two trailing spaces for indentation. This is fine and RTL is handled automatically by Row Directionality, but a fixed-width leading (SizedBox(width: …)) would give more consistent alignment across font scales/locales than space characters.

Verified ✅

  • All 27 locale files contain all 7 new keys (backupWarningDescription, the 5 backupWarningLoseReason* bullets, backupWarningNoRecovery) — checked via grep, 27/27 each.
  • No duplicate backupWarningDescription keys after the relocation (the +7/-4 locales moved/retranslated the old key; the +7/-0 locales previously had no value and now do — net improvement).
  • Non-English files correctly contain only values (no @-metadata), per the template-only convention; en.arb keeps the @-descriptions.
  • Translations are real per-locale strings (not English copies) in spot-checked ar/fr.

Overall

Localization work is clean and consistent. The one substantive concern is the non-scrolling bottom sheet now that the content is much taller — worth addressing before merge to avoid overflow on small/large-text devices.

Note: I can't submit a formal GitHub PR review or true inline comments here — findings are referenced by file:line above.

@i5hi
i5hi force-pushed the backup-warning-updates branch from 91af7e1 to 4f316bc Compare June 5, 2026 12:16
…fficient balance errors should be part of form validation. continue should be disabled until form is validated. Split warning into two boxes. Split backup warning into bull points.
@i5hi
i5hi force-pushed the backup-warning-updates branch from 4f316bc to 4e6b10d Compare June 5, 2026 16:58
@i5hi
i5hi merged commit 093eb5d into develop Jun 5, 2026
1 check passed
@i5hi

i5hi commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator Author

Fixes #2264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant