You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PR adds a single 9-line SECURITY.md establishing security@bullbitcoin.com as the private vulnerability-reporting channel. The diff is exactly as described (1 file, +9/-0), there are no conflicting security-contact mentions elsewhere in the repo's markdown, and a docs-only change like this can't introduce correctness bugs or regressions. No blocking issues — LGTM with a few suggestions below.
Note: I can't submit a formal GitHub review with inline comments, so findings are listed here instead.
Suggestions (non-blocking)
No encrypted reporting channel (SECURITY.md:5). Vulnerability reports for a Bitcoin wallet can contain highly sensitive details (fund-loss exploits, key-handling flaws), but plain email is unencrypted in the reporter's mailbox and potentially in transit. Consider publishing a PGP key for security@bullbitcoin.com, and/or enabling GitHub Private Vulnerability Reporting on this repo and linking it here — GitHub also surfaces SECURITY.md in the repo's Security tab, so the two work well together. Fix this →
No response-time commitment (SECURITY.md:9). "We will acknowledge your report" has no timeframe. A concrete SLA (e.g., "we will acknowledge within 3 business days") sets reporter expectations and reduces the chance of premature public disclosure.
Consider a Supported Versions section. GitHub's SECURITY.md convention includes which versions receive security fixes — useful for a mobile app where old releases linger on devices. Optional for a first iteration.
Verify the mailbox. I can't confirm from here that security@bullbitcoin.com exists and is actively monitored — since the PR title says "with new email", please double-check the address is live before merging, as a bouncing security contact is worse than none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.