fix(swap): name the networks when the exchange rejects a swap - #2684
Merged
Conversation
The exchange rejects some routes with ERR_ORD_PO404, which surfaced as a generic error and sent users to support instead of telling them what was refused. Adds the shared PaymentNetwork primitive in lib/core/primitives so the send and receive failure families can name both networks without depending on swap's internal types.
Collaborator
|
@ethicnology, checked against an unsupported route, which now returns a specific message instead of a generic error. 
|
wired-pasteque
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exchange rejects some routes with ERR_ORD_PO404, which surfaced as a generic error and sent users to support instead of telling them what was refused. Adds the shared PaymentNetwork primitive in lib/core/primitives so the send and receive failure families can name both networks without depending on swap's internal types.