Skip to content

fix(transactions): add copy button to swap order number - #2702

Merged
ethicnology merged 1 commit into
developfrom
fix/swap-order-number-copy
Aug 20, 2026
Merged

fix(transactions): add copy button to swap order number#2702
ethicnology merged 1 commit into
developfrom
fix/swap-order-number-copy

Conversation

@wired-pasteque

Copy link
Copy Markdown
Collaborator

Fixes: #2701

Simulator Screenshot - iPhone 17e - 2026-08-20 at 16 34 27

@wired-pasteque wired-pasteque self-assigned this Aug 20, 2026
@claude

claude Bot commented Aug 20, 2026

Copy link
Copy Markdown

Claude finished @wired-pasteque's task in 1m 2s —— View job


Code Review

  • Gather context (diff vs origin/develop)
  • Read surrounding code (transaction_details_table.dart, DetailsTableItem)
  • Post review summary

LGTM — no correctness bugs, security issues, or regressions found.

This one-line change adds copyValue to the swap order-number row in lib/features/transactions/ui/widgets/transaction_details_table.dart:215, which makes DetailsTableItem render its copy icon (lib/core/widgets/tables/details_table_item.dart:79-97).

What I verified:

  • Null safety: the row is guarded by if (orderSwap.order != null), so the orderSwap.order! access is safe — identical to the displayValue on the line above.
  • Consistency: this was the only order-number row in the file without a copy button; all eight other order-number rows (buy, sell, fiat payment, etc.) already use the exact same displayValue/copyValue pair, so this brings the swap case in line rather than introducing a new pattern.
  • Copy behavior: DetailsTableItem only shows the icon when copyValue is non-empty, and orderNumber.toString() always produces a non-empty string, so the button reliably appears and copies exactly what's displayed.

One optional nit (not blocking, and the existing code has the same duplication everywhere): the orderSwap.order!.orderNumber.toString() expression is evaluated twice; a local variable would avoid that, but matching the surrounding idiom is arguably better here.

Note: I can't submit formal inline PR review comments, so findings are posted in this comment — there were none to report inline anyway.

@ethicnology
ethicnology merged commit f13af3f into develop Aug 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Order Number is missing the copy button

2 participants