You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
LGTM — no correctness bugs, security issues, or regressions found. ✅
This one-line change adds copyValue to the swap order-number row in lib/features/transactions/ui/widgets/transaction_details_table.dart:215, which makes DetailsTableItem render its copy icon (lib/core/widgets/tables/details_table_item.dart:79-97).
What I verified:
Null safety: the row is guarded by if (orderSwap.order != null), so the orderSwap.order! access is safe — identical to the displayValue on the line above.
Consistency: this was the only order-number row in the file without a copy button; all eight other order-number rows (buy, sell, fiat payment, etc.) already use the exact same displayValue/copyValue pair, so this brings the swap case in line rather than introducing a new pattern.
Copy behavior: DetailsTableItem only shows the icon when copyValue is non-empty, and orderNumber.toString() always produces a non-empty string, so the button reliably appears and copies exactly what's displayed.
One optional nit (not blocking, and the existing code has the same duplication everywhere): the orderSwap.order!.orderNumber.toString() expression is evaluated twice; a local variable would avoid that, but matching the surrounding idiom is arguably better here.
Note: I can't submit formal inline PR review comments, so findings are posted in this comment — there were none to report inline anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2701