fix(theme): stop using onPrimary as a surface or on flipping fills - #2533
Draft
BullishNode wants to merge 1 commit into
Draft
fix(theme): stop using onPrimary as a surface or on flipping fills#2533BullishNode wants to merge 1 commit into
BullishNode wants to merge 1 commit into
Conversation
onPrimary is white in both themes by design (text on the red primary). Using it as a background produced white surfaces in dark mode, and pairing it with the theme-flipping secondary fill produced white-on-white buttons. Audited all 131 onPrimary usages: - 27 background/fill uses swapped to surface. Pixel-identical in light mode (both are white there); dark mode gets the proper dark surface. 13 of these were FadingLinearProgress tracks that flashed as bright white bars across dark screens. - 4 foregrounds on secondary fills swapped to onSecondary, including the buy accelerate screen's invisible Confirm express button. - The accelerate transaction tile keeps an explicit surface fill (the themed tileColor would paint a mismatched radius-2 shape under the tile's radius-4 border) and its foregrounds move to onSurface. - The Wait for free withdrawal button gains an outline so it reads on the light scaffold as well. - Also fixes the DCA lightning-address field, which was invisible in light mode from the inverse mistake. The segmented-button thumb (bb_segmented_button.dart) is deliberately untouched: its white thumb carries a primary-red label and needs a paired design change, not a token swap. Closes #2519 Closes #2520
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
onPrimaryis white in BOTH themes by design (text on the red primary). Using it as a background produced white surfaces in dark mode; pairing it with the theme-flippingsecondaryfill produced white-on-white buttons — e.g. the invisible "Accelerate Transaction" tile (#2519) and "Confirm express" button (#2520).Changes — full audit of all 131
onPrimaryusagessurface(pixel-identical in light mode, where both are white; 13 of these wereFadingLinearProgresstracks)secondaryfills →onSecondary(matches the 62 existing correct call sites)onSurfacebb_segmented_buttonthumb (white thumb + primary-red label needs a paired design change, not a token swap — follow-up issue candidate)Validation
analyze clean; the audit table (file:line → classification → action for all 131) is available on request; reviewer independently re-inspected ~50 sites and ran exhaustive pattern hunts — no missed cases found.
Closes #2519
Closes #2520