Merge pull request #582 from ChrisRackauckas-Claude/qa-check-extensions

Make QA scan the ODEInterface extension

Author: ChrisRackauckas

ext/BoundaryValueDiffEqODEInterfaceExt.jl

@@ -3,10 +3,10 @@ module BoundaryValueDiffEqODEInterfaceExt
 using BoundaryValueDiffEq: BVPM2, BVPSOL, COLNEW
 using BoundaryValueDiffEqCore: __extract_u0, __initial_guess_length, __extract_mesh,
     __flatten_initial_guess, __get_bcresid_prototype,
-    __has_initial_guess, __initial_guess, _process_verbose_param, BVPVerbosity
+    __has_initial_guess, __initial_guess, _process_verbose_param
 using SciMLBase: SciMLBase, BVProblem, TwoPointBVProblem, ReturnCode
 using SciMLLogging: @SciMLMessage
-using ODEInterface: OptionsODE, OPT_ATOL, OPT_RTOL, OPT_METHODCHOICE, OPT_DIAGNOSTICOUTPUT,
+using ODEInterface: OptionsODE, OPT_RTOL, OPT_METHODCHOICE, OPT_DIAGNOSTICOUTPUT,
     OPT_ERRORCONTROL, OPT_SINGULARTERM, OPT_MAXSTEPS, OPT_BVPCLASS,
     OPT_SOLMETHOD, OPT_RHS_CALLMODE, OPT_COLLOCATIONPTS, OPT_ADDGRIDPOINTS,
     OPT_MAXSUBINTERVALS, RHS_CALL_INSITU, evalSolution

test/qa/Project.toml

@@ -8,6 +8,7 @@ BoundaryValueDiffEqMIRK = "1a22d4ce-7765-49ea-b6f2-13c8438986a6"
 BoundaryValueDiffEqMIRKN = "9255f1d6-53bf-473e-b6bd-23f1ff009da4"
 BoundaryValueDiffEqShooting = "ed55bfe0-3725-4db6-871e-a1dc9f42a757"
 JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
+ODEInterface = "54ca160b-1b9f-5127-a996-1867f4bc2a2c"
 SciMLBase = "0bca4576-84f4-4d90-8ffe-ffa030f20462"
 SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
@@ -22,6 +23,7 @@ BoundaryValueDiffEqMIRK = "1"
 BoundaryValueDiffEqMIRKN = "1"
 BoundaryValueDiffEqShooting = "1"
 JET = "0.9, 0.10, 0.11"
+ODEInterface = "0.5"
 SciMLBase = "3"
 SciMLTesting = "2.4"
 Test = "1.10"

test/qa/qa.jl

@@ -4,6 +4,11 @@ using SciMLBase
 using JET
 using Test
 
+# ExplicitImports only analyzes an extension module once it has been materialized,
+# which requires its trigger weakdep to be loaded. Without this, the QA checks
+# silently skip BoundaryValueDiffEqODEInterfaceExt entirely.
+using ODEInterface
+
 include("reexports.jl")
 
 run_qa(
@@ -14,4 +19,45 @@ run_qa(
     ),
     reexports_allow = ROOT_REEXPORTS,
     api_docs_kwargs = (; ignore = ROOT_REEXPORTS, rendered_ignore = ROOT_REEXPORTS),
+    ei_kwargs = (;
+        all_qualified_accesses_are_public = (;
+            ignore = (
+                # ForwardDiff declares no `public` names at all (it exports only
+                # `DiffResults`), so its documented in-place AD entry point has no
+                # public spelling to switch to.
+                :jacobian!,
+            ),
+        ),
+        all_explicit_imports_are_public = (;
+            ignore = (
+                # ODEInterface has no `export` statements and no `public`
+                # declarations anywhere; its entire documented API -- solver
+                # entry points, option keys, and solution accessors -- is
+                # non-public by ExplicitImports' definition. There is no public
+                # spelling for any of these names.
+                :Bvpm2,
+                :OPT_ADDGRIDPOINTS,
+                :OPT_BVPCLASS,
+                :OPT_COLLOCATIONPTS,
+                :OPT_DIAGNOSTICOUTPUT,
+                :OPT_ERRORCONTROL,
+                :OPT_MAXSTEPS,
+                :OPT_MAXSUBINTERVALS,
+                :OPT_METHODCHOICE,
+                :OPT_RHS_CALLMODE,
+                :OPT_RTOL,
+                :OPT_SINGULARTERM,
+                :OPT_SOLMETHOD,
+                :OptionsODE,
+                :RHS_CALL_INSITU,
+                :bvpm2_destroy,
+                :bvpm2_get_x,
+                :bvpm2_init,
+                :bvpm2_solve,
+                :bvpsol,
+                :colnew,
+                :evalSolution,
+            ),
+        ),
+    ),
 )