Remove BoundaryValueDiffEqAscher blanket reexports

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>

Author: ChrisRackauckas

lib/BoundaryValueDiffEqAscher/Project.toml

@@ -12,7 +12,6 @@ DifferentiationInterface = "a0c0ee7d-e4b9-4e03-894e-1c5f64a51d63"
 FastClosures = "9aa1b823-49e4-5ca5-8b0f-3971ec8bab6a"
 ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
-Reexport = "189a3867-3050-52da-a836-e630ba90ab69"
 SciMLBase = "0bca4576-84f4-4d90-8ffe-ffa030f20462"
 Setfield = "efcf1570-3423-57d1-acb7-fd33fddbac46"
 
@@ -29,7 +28,6 @@ ForwardDiff = "0.10.38, 1"
 LinearAlgebra = "1.10"
 Random = "1.10"
 RecursiveArrayTools = "3.27.0, 4"
-Reexport = "1.2"
 SciMLBase = "3.30"
 SciMLTesting = "2.4"
 Setfield = "1.1.1"

lib/BoundaryValueDiffEqAscher/src/BoundaryValueDiffEqAscher.jl

@@ -1,6 +1,6 @@
 module BoundaryValueDiffEqAscher
 
-using ADTypes: ADTypes, AutoSparse, AutoForwardDiff
+using ADTypes: ADTypes, AutoSparse
 using AlmostBlockDiagonals: AlmostBlockDiagonals, IntermediateAlmostBlockDiagonal
 
 using BoundaryValueDiffEqCore: BoundaryValueDiffEqCore,
@@ -20,15 +20,12 @@ using DifferentiationInterface: DifferentiationInterface, Constant
 using FastClosures: @closure
 using ForwardDiff: ForwardDiff
 using LinearAlgebra: LinearAlgebra, I, norm, rank
-using Reexport: @reexport
 using SciMLBase: SciMLBase, BVProblem, ReturnCode, StandardBVProblem,
     TwoPointBVProblem, isinplace, solve
 using Setfield: @set!
 
 const DI = DifferentiationInterface
 
-@reexport using ADTypes, BoundaryValueDiffEqCore, SciMLBase
-
 include("types.jl")
 include("utils.jl")
 include("algorithms.jl")

lib/BoundaryValueDiffEqAscher/src/algorithms.jl

@@ -5,25 +5,46 @@ for stage in (1, 2, 3, 4, 5, 6, 7)
 
     @eval begin
         """
-            $($alg)(; nlsolve = NewtonRaphson(), max_num_subintervals = 3000)
+            $($alg)(; nlsolve = nothing, optimize = nothing, zeta = Float64[],
+                jac_alg = BVPJacobianAlgorithm(), max_num_subintervals = 3000)
 
-        $($stage)th stage Gauss Legendre collocation methods with adaptivity adapted from Ascher's implementation.
+        $($stage)-stage Gauss-Legendre collocation method with Ascher error-control
+        adaptivity and mesh refinement for boundary-value problems, including problems
+        with algebraic constraints.
+
+        ## Fields
+
+          - `nlsolve`: Nonlinear solver used for the collocation system. `nothing`
+            selects the package default.
+          - `optimize`: Optimization solver used by the mesh-refinement machinery.
+            `nothing` selects the package default.
+          - `zeta`: Side-condition locations for problems that require them. The default
+            empty vector is appropriate when no side conditions are present.
+          - `jac_alg`: `BVPJacobianAlgorithm` that selects the Jacobian construction
+            strategy for the collocation system.
+          - `max_num_subintervals`: Maximum number of mesh subintervals permitted while
+            refining the solution.
 
         ## Keyword Arguments
 
-          - `nlsolve`: Internal Nonlinear solver. Any solver which conforms to the SciML
-            `NonlinearProblem` interface can be used. Note that any autodiff argument for
-            the solver will be ignored and a custom jacobian algorithm will be used.
-          - `optimize`: Internal Optimization solver. Any solver which conforms to the SciML
-            `OptimizationProblem` interface can be used. Note that any autodiff argument for
-            the solver will be ignored and a custom jacobian algorithm will be used.
-          - `max_num_subintervals`: Number of maximal subintervals, default as 3000.
-          - `zeta`: side condition points, should always be provided.
+          - `nlsolve = nothing`: Internal nonlinear solver. Any solver implementing the
+            SciML `NonlinearProblem` interface may be used. Its autodifferentiation
+            setting is ignored because this solver uses `jac_alg`.
+          - `optimize = nothing`: Internal optimization solver. Any solver implementing
+            the SciML `OptimizationProblem` interface may be used. Its
+            autodifferentiation setting is ignored because this solver uses `jac_alg`.
+          - `zeta = Float64[]`: Side-condition locations. Supply the points required by
+            the problem; leave empty when the problem has no side conditions.
+          - `jac_alg = BVPJacobianAlgorithm()`: Jacobian construction strategy. For
+            type stability, provide ForwardDiff chunk sizes in the AD types selected by
+            this value.
+          - `max_num_subintervals = 3000`: Maximum number of mesh subintervals.
 
-        !!! note
+        ## Example
 
-            For type-stability, the chunksizes for ForwardDiff ADTypes in
-            `BVPJacobianAlgorithm` must be provided.
+        ```julia
+        alg = $($alg)(zeta = [0.0, 0.5, 1.0])
+        ```
 
         ## References
 

lib/BoundaryValueDiffEqAscher/test/Core/ascher_basic_tests.jl

@@ -1,6 +1,21 @@
 using BoundaryValueDiffEqAscher
 using Test
 
+@testset "Public API" begin
+    @test Set(names(BoundaryValueDiffEqAscher)) == Set(
+        (
+            :Ascher1,
+            :Ascher2,
+            :Ascher3,
+            :Ascher4,
+            :Ascher5,
+            :Ascher6,
+            :Ascher7,
+            :BoundaryValueDiffEqAscher,
+        )
+    )
+end
+
 # Standard test BVDAE problem from the URI M. ASCHER and RAYMOND J. SPITERI paper
 @testset "Test Ascher solver on example problem 1" begin
     using BoundaryValueDiffEqAscher, SciMLBase

lib/BoundaryValueDiffEqAscher/test/qa/qa.jl

@@ -2,9 +2,6 @@ using SciMLTesting
 using BoundaryValueDiffEqAscher
 using Test
 
-const DOCS_SRC = normpath(joinpath(@__DIR__, "..", "..", "..", "..", "docs", "src"))
-include(joinpath(@__DIR__, "..", "..", "..", "..", "test", "qa", "reexports.jl"))
-
 run_qa(
     BoundaryValueDiffEqAscher;
     ei_kwargs = (;
@@ -15,9 +12,4 @@ run_qa(
         # no public replacement.
         all_qualified_accesses_are_public = (; ignore = (:Dual, :jacobian!)),
     ),
-    reexports_allow = ASCHER_REEXPORTS,
-    api_docs_kwargs = (;
-        docs_src = DOCS_SRC, ignore = ASCHER_REEXPORTS,
-        rendered_ignore = ASCHER_REEXPORTS,
-    ),
 )