Skip to content

Commit 4475c0f

Browse files
committed
Fix RAT view issue
1 parent b251ddd commit 4475c0f

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

lib/BoundaryValueDiffEqMIRK/src/mirk.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ function SciMLBase.solve!(
307307
end
308308

309309
function __perform_mirk_iteration(cache::MIRKCache, abstol, adaptive::Bool, controller::AbstractErrorControl)
310-
nlprob = __construct_problem(cache, vec(cache.y₀), copy(cache.y₀))
310+
nlprob = __construct_problem(cache, copy(vec(cache.y₀)), copy(cache.y₀))
311311
solve_alg = __concrete_solve_algorithm(nlprob, cache.alg.nlsolve, cache.alg.optimize)
312312
kwargs = __concrete_kwargs(
313313
cache.alg.nlsolve, cache.alg.optimize, cache.nlsolve_kwargs, cache.optimize_kwargs,

lib/BoundaryValueDiffEqMIRK/test/mirk_basic_tests.jl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -502,7 +502,7 @@ end
502502
)
503503
sol = solve(bvp, MIRK4(), dt = 0.05)
504504

505-
@test sol.prob.p [17.09658] atol = 1.0e-5
505+
@test sol.prob.p [17.09658] atol = 1.0e-4
506506

507507
tspan = (0.0, pi)
508508
function f!(du, u, p, t)
@@ -523,7 +523,7 @@ end
523523
)
524524
sol = solve(bvp, MIRK4(), dt = 0.05)
525525

526-
@test sol.prob.p [17.09658] atol = 1.0e-5
526+
@test sol.prob.p [17.09658] atol = 1.0e-4
527527
end
528528

529529
@testitem "Test unknown parameters estimation with SciMLStructures" begin
@@ -576,9 +576,9 @@ end
576576
)
577577
sol_struct = solve(bvp_struct, MIRK4(), dt = 0.05)
578578

579-
@test sol_vec.prob.p [17.09658] atol = 1.0e-5
579+
@test sol_vec.prob.p [17.09658] atol = 1.0e-4
580580
@test sol_struct.prob.p isa MyParams
581-
@test sol_struct.prob.p.params [17.09658] atol = 1.0e-5
581+
@test sol_struct.prob.p.params [17.09658] atol = 1.0e-4
582582
@test sol_struct.prob.p.params sol_vec.prob.p atol = 1.0e-10
583583
end
584584

@@ -596,9 +596,9 @@ end
596596
)
597597
sol_struct = solve(bvp_struct, MIRK4(; optimize = IpoptOptimizer()), dt = 0.05)
598598

599-
@test sol_vec.prob.p [17.09658] atol = 1.0e-5
599+
@test sol_vec.prob.p [17.09658] atol = 1.0e-4
600600
@test sol_struct.prob.p isa MyParams
601-
@test sol_struct.prob.p.params [17.09658] atol = 1.0e-5
601+
@test sol_struct.prob.p.params [17.09658] atol = 1.0e-4
602602
@test sol_struct.prob.p.params sol_vec.prob.p atol = 1.0e-10
603603
end
604604
end

0 commit comments

Comments
 (0)