Use deepcopy to copy initial guess

Author: ErikQQY

lib/BoundaryValueDiffEqCore/Project.toml

@@ -1,6 +1,6 @@
 name = "BoundaryValueDiffEqCore"
 uuid = "56b672f2-a5fe-4263-ab2d-da677488eb3a"
-version = "2.2.0"
+version = "2.2.1"
 authors = ["Qingyu Qu <erikqqy123@gmail.com>"]
 
 [deps]

lib/BoundaryValueDiffEqCore/src/utils.jl

@@ -617,15 +617,15 @@ as the mesh of the `DiffEqArray`.
 end
 @inline function __initial_guess_on_mesh(u₀::VectorOfArray, mesh, p; tune_parameters = false)
     tune_parameters && return VectorOfArray([vcat(vec(u), __tunable_part(p)) for u in u₀.u])
-    return copy(u₀)
+    return deepcopy(u₀)
 end
 @inline function __initial_guess_on_mesh(u₀::DiffEqArray, mesh, p; tune_parameters = false)
     tune_parameters && return DiffEqArray([vcat(vec(u), __tunable_part(p)) for u in u₀.u])
-    return copy(u₀)
+    return deepcopy(u₀)
 end
 @inline function __initial_guess_on_mesh(u₀::SciMLBase.ODESolution, mesh, p; tune_parameters = false)
     tune_parameters && return VectorOfArray([vcat(vec(u), __tunable_part(p)) for u in u₀.u])
-    return copy(VectorOfArray(u₀.u))
+    return deepcopy(VectorOfArray(u₀.u))
 end
 @inline function __initial_guess_on_mesh(u₀::AbstractArray, mesh, p; tune_parameters = false)
     tune_parameters && return VectorOfArray([vcat(vec(u₀), __tunable_part(p)) for _ in mesh])

lib/BoundaryValueDiffEqFIRK/test/expanded/firk_basic_tests.jl

@@ -566,5 +566,9 @@ end
     bvp2 = TwoPointBVProblem(f!, (bca!, bcb!), sol1, tspan; bcresid_prototype = (zeros(2), zeros(1)))
     sol2 = solve(bvp2, LobattoIIIa3(), dt = 0.1, adaptive = false, nlsolve_kwargs = (; maxiters = 0))
     @test sol2.u == u_guess
+
+    # Ensure the initial guess is not modified in-place
+    sol2 = solve(bvp2, LobattoIIIa3(), dt = 0.1, adaptive = false)
+    @test bvp2.u0 == u_guess
 end
 =#

lib/BoundaryValueDiffEqFIRK/test/nested/firk_basic_tests.jl

@@ -646,4 +646,8 @@ end
     bvp2 = TwoPointBVProblem(f!, (bca!, bcb!), sol1, tspan; bcresid_prototype = (zeros(2), zeros(1)))
     sol2 = solve(bvp2, RadauIIa5(; nested_nlsolve = true), dt = 0.1, adaptive = false, nlsolve_kwargs = (; maxiters = 0))
     @test sol2.u == u_guess
+
+    # Ensure the initial guess is not modified in-place
+    sol2 = solve(bvp2, RadauIIa5(; nested_nlsolve = true), dt = 0.1, adaptive = false)
+    @test bvp2.u0 == u_guess
 end

lib/BoundaryValueDiffEqMIRK/test/mirk_basic_tests.jl

@@ -686,4 +686,8 @@ end
     bvp2 = TwoPointBVProblem(f!, (bca!, bcb!), sol1, tspan; bcresid_prototype = (zeros(2), zeros(1)))
     sol2 = solve(bvp2, MIRK4(), dt = 0.1, adaptive = false, nlsolve_kwargs = (; maxiters = 0))
     @test sol2.u == u_guess
+
+    # Ensure the initial guess is not modified in-place
+    sol2 = solve(bvp2, MIRK4(), dt = 0.1, adaptive = false)
+    @test bvp2.u0 == u_guess
 end