Use update_eval_sol to update eval sol

Author: ErikQQY

lib/BoundaryValueDiffEqMIRK/src/interpolation.jl

@@ -377,9 +377,9 @@ always update the intermediate solution with discrete solution + discrete stages
 (Continuous MIRK: u(meshᵢ + τ*dt) = yᵢ + dt sum br(τ)*kr).
 """
 @views function update_eval_sol!(eval_sol::EvalSol, y_, cache::MIRKCache)
-    eval_sol.u[1:end] .= __restructure_sol(y_, cache.in_size)
-    eval_sol.cache.k_discrete[1:end] .= cache.k_discrete
-    eval_sol.cache.k_interp.u[1:end] .= cache.k_interp.u
+    copyto!(eval_sol.u, __restructure_sol(y_, cache.in_size))
+    copyto!(eval_sol.cache.k_discrete, cache.k_discrete)
+    copyto!(eval_sol.cache.k_interp.u, cache.k_interp.u)
     interp_setup!(eval_sol.cache)
     return nothing
 end

test/misc/allocation_tests.jl

@@ -1,4 +1,4 @@
-@testitem "MIRK Loss Function Allocations" tags=[:allocs] begin
+@testitem "MIRK Loss Function Allocations" tags = [:allocs] begin
     using BoundaryValueDiffEq, BoundaryValueDiffEqMIRK, BoundaryValueDiffEqCore, LinearAlgebra
 
     function f!(du, u, p, t)
@@ -28,17 +28,21 @@
 
     bvp = BVProblem(BVPFunction{true}(f!, bc!; bcresid_prototype = zeros(2)), u0, tspan)
     tpbvp = BVProblem(
-        BVPFunction{true}(f!, (tpbc_a!, tpbc_b!);
-            bcresid_prototype = (zeros(1), zeros(1)), twopoint = Val(true)),
-        u0, tspan)
+        BVPFunction{true}(
+            f!, (tpbc_a!, tpbc_b!);
+            bcresid_prototype = (zeros(1), zeros(1)), twopoint = Val(true)
+        ),
+        u0, tspan
+    )
 
     # Test that the loss function allocations scale sub-linearly with mesh size
     # (i.e., per-step allocations are bounded, not proportional to mesh points)
     for (name, prob) in [("StandardBVP", bvp), ("TwoPointBVP", tpbvp)]
         for alg in [MIRK4(), MIRK5(), MIRK6()]
             cache = SciMLBase.__init(prob, alg; dt = 0.1, adaptive = false)
             nlprob = BoundaryValueDiffEqMIRK.__construct_problem(
-                cache, vec(cache.y₀), copy(cache.y₀))
+                cache, vec(cache.y₀), copy(cache.y₀)
+            )
 
             u_test = copy(nlprob.u0)
             resid_test = zeros(length(nlprob.u0))

test/qa/runtests.jl

@@ -31,11 +31,13 @@ using BoundaryValueDiffEq, BoundaryValueDiffEqMIRK, BoundaryValueDiffEqCore,
         u0 = [1.0, 0.0]
         tspan = (0.0, 1.0)
         bvp = BVProblem(
-            BVPFunction{true}(_f!, _bc!; bcresid_prototype = zeros(2)), u0, tspan)
+            BVPFunction{true}(_f!, _bc!; bcresid_prototype = zeros(2)), u0, tspan
+        )
 
         cache = SciMLBase.__init(bvp, MIRK4(); dt = 0.1, adaptive = false)
         nlprob = BoundaryValueDiffEqMIRK.__construct_problem(
-            cache, vec(cache.y₀), copy(cache.y₀))
+            cache, vec(cache.y₀), copy(cache.y₀)
+        )
 
         u_test = copy(nlprob.u0)
         resid_test = zeros(length(nlprob.u0))